New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659395 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Investigate lack of support for ES3 in Chromecast GPUs

Project Member Reported by s...@chromium.org, Oct 26 2016

Issue description

Chromecast goes into a reboot loop when ES3 is enabled. Disable ES3 on Linux for now, and investigate what the long-term solution is.



 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6fcc0127ab9a0f25a5cc0e46e657438be4037d7

commit a6fcc0127ab9a0f25a5cc0e46e657438be4037d7
Author: slan <slan@chromium.org>
Date: Wed Oct 26 04:10:11 2016

[Chromecast] Add kDisableES3GLContext to command line on Cast builds.

ES3 support was recently enabled by default:
  https://codereview.chromium.org/2354423002

This causes the GPU process to fail at startup. Disable ES3 GL context
with a command-line flag on Cast builds.

BUG= 659395 

Review-Url: https://codereview.chromium.org/2387333004
Cr-Commit-Position: refs/heads/master@{#427589}

[modify] https://crrev.com/a6fcc0127ab9a0f25a5cc0e46e657438be4037d7/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/a6fcc0127ab9a0f25a5cc0e46e657438be4037d7/content/browser/gpu/gpu_process_host.cc

Comment 2 by s...@chromium.org, Mar 7 2017

Note: This change broke Cast due to this issue: https://codereview.chromium.org/2693333003

This [Local] patch was added to overcome the breakage:
https://eureka-internal-review.git.corp.google.com/#/c/68846
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33ae8cd1ee32a7aca5fc3a743d20c5a8cb0cc8e7

commit 33ae8cd1ee32a7aca5fc3a743d20c5a8cb0cc8e7
Author: Luke Halliwell <halliwell@chromium.org>
Date: Fri Sep 15 23:46:41 2017

[Chromecast] Remove kDisableES3GLContext switch

Had a longstanding TODO to investigate why this was needed.  It
seems it is not needed any more :)

Bug:  659395 
Change-Id: I14401c88d0d582c693d989b468e0cf0de6e54867
Reviewed-on: https://chromium-review.googlesource.com/669662
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502442}
[modify] https://crrev.com/33ae8cd1ee32a7aca5fc3a743d20c5a8cb0cc8e7/chromecast/browser/cast_browser_main_parts.cc

Status: Fixed (was: Assigned)

Sign in to add a comment