New issue
Advanced search Search tips

Issue 659391 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Layout Test payments/promises-keep-request-alive.html is timing out

Project Member Reported by alancutter@chromium.org, Oct 26 2016

Issue description

[Build sheriff]

The following layout test is failing on Linux Trusty

payments/promises-keep-request-alive.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=payments%2Fpromises-keep-request-alive.html&testType=webkit_tests

Flakiness dashboard points to https://chromium.googlesource.com/chromium/src/+log/67e6efd22bbef2baea0ac32fb603659f2ee93275%5E..12af52210b397d1d76c541730d95c7a0375496c4 as the regression range.
Nothing in that range looks obviously related to this test.


 
Labels: Sheriff-Chromium
 Issue 659075  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acc52fb90068531fb1b2fbd608bcfb4a71895090

commit acc52fb90068531fb1b2fbd608bcfb4a71895090
Author: alancutter <alancutter@chromium.org>
Date: Wed Oct 26 00:26:39 2016

Mark payments/promises-keep-request-alive.html as timing out for Linux

BUG= 659391 
TBR=rouslan@chromium.org
NOTRY=TRUE

Review-Url: https://codereview.chromium.org/2449323002
Cr-Commit-Position: refs/heads/master@{#427548}

[modify] https://crrev.com/acc52fb90068531fb1b2fbd608bcfb4a71895090/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by foolip@chromium.org, Oct 26 2016

Labels: -Sheriff-Chromium
Status: Started (was: Assigned)
WIP @ http://crrev.com/2456483003
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a02160012bad1d6486ddcc17966fa585fd585cbb

commit a02160012bad1d6486ddcc17966fa585fd585cbb
Author: rouslan <rouslan@chromium.org>
Date: Thu Oct 27 11:51:07 2016

Fix payments layout test timeout.

A payments layout test was timing out due to not being able to find the
mojo file that it was mocking. That file has moved from
third_party/WebKit to components/payments. Updating the location of the
mojo file fixes the timeout.

The patch also removes a stale reference to this mojo file from DEPS.

BUG= 659391 

Review-Url: https://codereview.chromium.org/2456483003
Cr-Commit-Position: refs/heads/master@{#427998}

[modify] https://crrev.com/a02160012bad1d6486ddcc17966fa585fd585cbb/chrome/browser/DEPS
[modify] https://crrev.com/a02160012bad1d6486ddcc17966fa585fd585cbb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a02160012bad1d6486ddcc17966fa585fd585cbb/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js

Status: Fixed (was: Started)

Sign in to add a comment