New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659376 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug-Regression

Blocking:
issue 644372



Sign in to add a comment

[Predator] Broken mocking of CrashWrapperPipeline

Project Member Reported by wrengr@chromium.org, Oct 25 2016

Issue description

In ./crash/test/crash_pipeline_test.py, there are three tests which currently fail due to bad mocking. All three tests call 
_TestRunningAnalysisForResult which in turn calls ScheduleNewAnalysis. The problem is, we need _TestRunningAnalysisForResult to mock the CrashWrapperPipeline class it hands to ScheduleNewAnalysis so that (a) we do not go over the wire, but (b) we test all the logic in CrashWrapperPipeline (and the other pipeline classes it calls).

I (wrengr) have no idea how to mock this appropriately. Either stgao or katesonia should be able to do it pretty easily though.
 

Comment 1 by st...@chromium.org, Oct 25 2016

Owner: kateso...@chromium.org
Status: Assigned (was: Available)
Assign to Sharu as she factored out the shared function _TestRunningAnalysisForResult.

Comment 2 by wrengr@chromium.org, Oct 27 2016

Status: Fixed (was: Assigned)
Fixed in https://codereview.chromium.org/2414523002/#ps460001

Sign in to add a comment