New issue
Advanced search Search tips

Issue 659375 link

Starred by 1 user
Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Add check for host validity in URLPattern

Project Member Reported by asargent@chromium.org, Oct 25 2016 
In https://codereview.chromium.org/2433583002, there was some tricky code in parsing externally_connectible match patterns, and a discussion arose about whether it was possible to have non-empty but "invalid" host values returned for an URLPattern. 

It looks like in general that the host of an URLPattern should either be empty (meaning it is "*", or matches all hosts), or it should be some valid host that would pass a net::CanonicalizeHost test. (The way host wildcarding like *.google.com works is that the host is set to the valid name "google.com" and match_subdomains_ is set to true). 

We could add some code to URLPattern::Parse and URLPattern::SetHost to enforce this.
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 26 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by rdevlin....@chromium.org, Oct 27 2017

Cc: -asargent@chromium.org
Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 29

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment