New issue
Advanced search Search tips

Issue 659373 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GCM-internals should surface checkin time information

Project Member Reported by zea@chromium.org, Oct 25 2016

Issue description

We should include the following:
Last checkin attempt status
Last successful checkin time
Next checkin attempt time

This will help debug cases like bug 651863 where that may be due to failure to checkin.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76342abff9abbb4413572ebb27d8a1dd6a5c91b6

commit 76342abff9abbb4413572ebb27d8a1dd6a5c91b6
Author: zea <zea@chromium.org>
Date: Tue Nov 01 17:26:04 2016

[GCM] Reset store on checkin rejection and add checkin state to internals

First, this now handles cases where checkin is rejected for a non-retryable
reason by resetting the GCM store. UMA data shows that this is happening
less than 1% of the time, and likely implies profile corruption. Currently
we do not have any way to recover from this state.

Secondly, to help diagnose other checkin issues, I've also added checkin
information to chrome://gcm-internals. Namely last checkin time and next
scheduled checkin time. Recording is now on by default to make it easier
to record checkin events.

BUG= 659373 

Review-Url: https://codereview.chromium.org/2450383003
Cr-Commit-Position: refs/heads/master@{#429033}

[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/components/gcm_driver/BUILD.gn
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/components/gcm_driver/gcm_client.h
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/components/gcm_driver/gcm_client_impl.cc
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/components/gcm_driver/gcm_client_impl.h
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/components/gcm_driver/gcm_client_impl_unittest.cc
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/components/gcm_driver/gcm_internals_constants.cc
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/components/gcm_driver/gcm_internals_constants.h
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/components/gcm_driver/gcm_internals_helper.cc
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/components/gcm_driver/resources/gcm_internals.html
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/components/gcm_driver/resources/gcm_internals.js
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/google_apis/gcm/engine/checkin_request.cc
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/google_apis/gcm/engine/checkin_request.h
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/google_apis/gcm/engine/checkin_request_unittest.cc
[modify] https://crrev.com/76342abff9abbb4413572ebb27d8a1dd6a5c91b6/google_apis/gcm/tools/mcs_probe.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6e40418c02f84417b973026ec6d7e515a4c46ba

commit e6e40418c02f84417b973026ec6d7e515a4c46ba
Author: zea <zea@chromium.org>
Date: Fri Nov 04 23:05:45 2016

[GCM] Update ResetStore histograms

Adds a new GCM.ResetStoreReason histogram, and renames the old GCM.ResetStore
histogram to GCM.ResetStoreError (for clarity).

BUG= 659373 

Review-Url: https://codereview.chromium.org/2471433003
Cr-Commit-Position: refs/heads/master@{#430056}

[modify] https://crrev.com/e6e40418c02f84417b973026ec6d7e515a4c46ba/components/gcm_driver/gcm_client_impl.h
[modify] https://crrev.com/e6e40418c02f84417b973026ec6d7e515a4c46ba/tools/metrics/histograms/histograms.xml

Comment 3 by zea@chromium.org, Nov 10 2016

Status: Fixed (was: Assigned)

Sign in to add a comment