Issue 659372 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	jianli@chromium.org
Closed:	Oct 2016
Components:	UI>Browser>Offline
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	1
Type:	Bug
M-56

SHOW_NET_ERROR_PAGE is reported even when the page is loaded OK

Project Member Reported by jianli@chromium.org, Oct 25 2016

Issue description

The UMA OfflinePagesAggregatedRequestResult shows mostly coming from SHOW_NET_ERROR_PAGE, which is not reported correctly. We should exclude net::OK.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6b6dbfd5c30edb7187b29292444e2775db2d8e3

commit c6b6dbfd5c30edb7187b29292444e2775db2d8e3
Author: jianli <jianli@chromium.org>
Date: Thu Oct 27 01:46:42 2016

Fix incorrectly reported UMA OfflinePages.AggregatedRequestResult

BUG= 659372 

Review-Url: https://codereview.chromium.org/2452593003
Cr-Commit-Position: refs/heads/master@{#427909}

[modify] https://crrev.com/c6b6dbfd5c30edb7187b29292444e2775db2d8e3/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/c6b6dbfd5c30edb7187b29292444e2775db2d8e3/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
[modify] https://crrev.com/c6b6dbfd5c30edb7187b29292444e2775db2d8e3/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/c6b6dbfd5c30edb7187b29292444e2775db2d8e3/tools/metrics/histograms/histograms.xml

Comment 2 by jianli@chromium.org, Oct 27 2016

Status: Fixed (was: Started)

►

Issue 659372 link

Issue metadata

SHOW_NET_ERROR_PAGE is reported even when the page is loaded OK

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

Comment 1 Deleted

Comment 2 by jianli@chromium.org, Oct 27 2016

Comment 2 Deleted

Sign in to add a comment