New issue
Advanced search Search tips

Issue 659357 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 679729



Sign in to add a comment

Out-of-memory in v8_serialized_script_value_fuzzer

Project Member Reported by ClusterFuzz, Oct 25 2016

Issue description

Owner: jbroman@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by mmoroz@chromium.org, Jan 20 2017

Blocking: 679729
This happens almost every time the fuzzer starts to run: https://cluster-fuzz.appspot.com/v2/fuzzer-stats/by-day/2017-01-13/2017-01-19/fuzzer/libfuzzer_v8_serialized_script_value_fuzzer/job/libfuzzer_chrome_asan

Would be super-awesome if you Jeremy can take a look or suggest another owner at least...
Yeah, I've looked a little (and will try to find more time to look). It's not apparent to me whether it's actually using a lot of memory (I don't see how) or whether V8/Oilpan just aren't convinced there's enough memory pressure to bother collecting. (After all, the 300MB limit isn't visible to it -- that's just a thread monitoring the RSS.)
Status: Started (was: Assigned)
Alright, I give up on trying to be fast here. Forcing a major GC each time does the trick for me, at the cost of a order-of-magnitude slowdown. But since the fuzzer isn't managing to run for long anyhow, that won't be worse.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd795a387b29430c851f367b2b7f3015f47a4ff6

commit bd795a387b29430c851f367b2b7f3015f47a4ff6
Author: jbroman <jbroman@chromium.org>
Date: Thu Jan 26 14:23:56 2017

Always force a major GC after each input in v8_serialized_script_value_fuzzer.

This causes a significant slowdown, but there have been persistent issues with
trying to be more clever and do infrequent collections (and doing so increases
cross-contamination between inputs).

This will have both V8 and Oilpan do one major GC each time (note that if there
is a chain of persistent objects, some objects may not be freed until a later
cycle).

BUG= 659357 

Review-Url: https://codereview.chromium.org/2658653003
Cr-Commit-Position: refs/heads/master@{#446320}

[modify] https://crrev.com/bd795a387b29430c851f367b2b7f3015f47a4ff6/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp

Project Member

Comment 7 by ClusterFuzz, Jan 27 2017

Project Member

Comment 8 by ClusterFuzz, Jan 27 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 4527890118213632 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment