New issue
Advanced search Search tips

Issue 659348 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

ManifestUpgradeDetector does not correctly read long icon Murmur2 hashes

Project Member Reported by pkotw...@chromium.org, Oct 25 2016

Issue description

icon murmur2 hashes can take on values up to 2^64 - 1. 2^64 - 1 is greater than Long#MAX_VALUE. Thus the WebApkMetaDataUtils#getLongFromMetaData() call in ManifestUpgradeDetector cannot be used to extract the hash from the WebAPK's Android <meta-data>
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaab0997ef06ae47b24670b0510a5e67ce5ff7ec

commit aaab0997ef06ae47b24670b0510a5e67ce5ff7ec
Author: pkotwicz <pkotwicz@chromium.org>
Date: Thu Oct 27 21:22:09 2016

Make ManifestUpgradeDetector correctly fetch "icon Murmur2 hash" if hash is big

Murmur2 hashes can take on values up to 2^64 - 1. 2^64 - 1 is larger than
Long#MAX_VALUE. This CL introduces
WebApkMetaDataUtils#getIconMurmur2HashFromMetaData() to extract the hash from
the meta data in the WebAPK's Android Manifest.

BUG= 659348 
TEST=WebApkMetaDataUtilsTest#testGetIconMurmur2HashFromMetaData,
     ManifestUpgradeDetectorFetcherTest.testIconMurmur2HashParsing

Review-Url: https://codereview.chromium.org/2452823002
Cr-Commit-Position: refs/heads/master@{#428140}

[modify] https://crrev.com/aaab0997ef06ae47b24670b0510a5e67ce5ff7ec/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
[modify] https://crrev.com/aaab0997ef06ae47b24670b0510a5e67ce5ff7ec/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java
[modify] https://crrev.com/aaab0997ef06ae47b24670b0510a5e67ce5ff7ec/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
[modify] https://crrev.com/aaab0997ef06ae47b24670b0510a5e67ce5ff7ec/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtilsTest.java
[add] https://crrev.com/aaab0997ef06ae47b24670b0510a5e67ce5ff7ec/chrome/test/data/banners/long_murmur2_hash_icon.png
[add] https://crrev.com/aaab0997ef06ae47b24670b0510a5e67ce5ff7ec/chrome/test/data/banners/manifest_long_icon_murmur2_hash.json

Comment 2 by hanxi@chromium.org, Oct 28 2016

Is this bug fixed now?
Status: Fixed (was: Assigned)

Sign in to add a comment