New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659346 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug-Regression

Blocking:
issue 644372



Sign in to add a comment

[Predator] Improve coverage of unittests

Project Member Reported by wrengr@chromium.org, Oct 25 2016

Issue description

Since refactoring, many of the new classes don't have 100% coverage in unittests. We should fix this.
 

Comment 1 by wrengr@chromium.org, Oct 28 2016

Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
Owner: kateso...@chromium.org
Status: Assigned (was: Untriaged)
Take care of this culprit.py code coverage in this cl https://codereview.chromium.org/2449853012/, as well as some bug fixing.

Comment 4 by st...@chromium.org, Oct 31 2016

Is there any significant classes that don't have 100% coverage?

Ideally, we should clean up all the "pragma: no cover" in the code base, although I'm OK with occasional occurrences for some obvious & non-critical edge cases.

Comment 5 by wrengr@chromium.org, Oct 31 2016

@stgao: It's tricky to really say for sure. The problem is that some of the unittests got moved to different files. Because of the unreliable way that coverage is computed, many things come up as "not covered" when they are in fact covered by the complete test suite (just not by the specific foo_test.py file).

Prime examples of this include: ./crash/crash_pipeline.py, ./crash/predator.py, ./crash/culprit.py, ./crash/findit.py, ./crash/component.py
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/e50200467b7e522a03b2d9d73d6cd27d0b49874c

commit e50200467b7e522a03b2d9d73d6cd27d0b49874c
Author: katesonia <katesonia@chromium.org>
Date: Wed Nov 02 03:08:19 2016

[Predator] Fix bug in min_distance after refactor and add back skip added/deleted deps.

Also added culprit_test for culprit.py

BUG= 660621 ,  659346 

Review-Url: https://codereview.chromium.org/2449853012

[modify] https://crrev.com/e50200467b7e522a03b2d9d73d6cd27d0b49874c/appengine/findit/crash/changelist_classifier.py
[modify] https://crrev.com/e50200467b7e522a03b2d9d73d6cd27d0b49874c/appengine/findit/crash/culprit.py
[modify] https://crrev.com/e50200467b7e522a03b2d9d73d6cd27d0b49874c/appengine/findit/crash/scorers/min_distance.py
[modify] https://crrev.com/e50200467b7e522a03b2d9d73d6cd27d0b49874c/appengine/findit/crash/scorers/test/aggregated_scorer_test.py
[modify] https://crrev.com/e50200467b7e522a03b2d9d73d6cd27d0b49874c/appengine/findit/crash/scorers/test/min_distance_test.py
[modify] https://crrev.com/e50200467b7e522a03b2d9d73d6cd27d0b49874c/appengine/findit/crash/test/changelist_classifier_test.py
[add] https://crrev.com/e50200467b7e522a03b2d9d73d6cd27d0b49874c/appengine/findit/crash/test/culprit_test.py
[modify] https://crrev.com/e50200467b7e522a03b2d9d73d6cd27d0b49874c/appengine/findit/crash/test/findit_for_chromecrash_test.py
[modify] https://crrev.com/e50200467b7e522a03b2d9d73d6cd27d0b49874c/appengine/findit/model/crash/crash_analysis.py

Components: Tools>Test>Predator
Components: -Tools>Test>FindIt>Crash
Labels: -Pri-1 Pri-3
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2017

Status: Fixed (was: Assigned)

Sign in to add a comment