New issue
Advanced search Search tips

Issue 659335 link

Starred by 1 user
Status: WontFix
Owner:
est...@chromium.org
Closed: Oct 2016
Cc:
elawrence@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

SecurityStateModel unit tests should be using a ScopedCommandLine

Project Member Reported by est...@chromium.org, Oct 25 2016 
SecurityStateModel unit tests are adding switches to the command line for the current process, but they should be using ScopedCommandLine instead to do this.

https://cs.chromium.org/chromium/src/components/security_state/security_state_model_unittest.cc?type=cs&q=security_state_model_un&sq=package:chromium&l=243

Comment 1 by elawrence@chromium.org, Oct 26 2016 

Do any of those tests need such a fine-grained change?

// Helper class to restore the original command line at the end of the scope.
// NOTE: In most unit tests, the command line is automatically restored per
//       test, so this class is not necessary if the command line applies to
//       the entire single test.
class ScopedCommandLine final

Comment 2 by est...@chromium.org, Oct 26 2016

Status: WontFix (was: Assigned)
Oh, I missed that NOTE, thanks! I guess this isn't necessary then.

Comment 3 by lafo...@chromium.org, Dec 9 2016

Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label
►

Sign in to add a comment