run_puppet error for drone role |
|||||||||
Issue descriptionrun_puppet in lab failed with following error in drone: Error: Parameter path failed on File[undef]: File paths must be fully qualified, not 'undef' at /root/chromeos-admin/puppet/modules/lab/manifests/chrome_infra_service_accounts_dir.pp:11 Wrapped exception: File paths must be fully qualified, not 'undef'
,
Oct 25 2016
$chrome_infra_service_accounts_dir is not assigned anywhere in the puppet code, did I miss anything?
,
Oct 25 2016
Sorry, should have caught that in review. Puppet tests should be ready soon, which will start catching these.
,
Oct 25 2016
one more related issue:
Error: Could not find dependency File[undef] for File[/creds/service_accounts/service_account_mon_pubsub.json] at /root/chromeos-admin/puppet/modules/lab/manifests/ts_mon.pp:14
in ts_mon.pp
file { "${dir}/service_account_mon_pubsub.json":
require => [ File[$chrome_infra_service_accounts_dir], Exec["create ${user}"] ],
ensure => present,
chrome_infra_service_accounts_dir needs to be dir too?
,
Oct 25 2016
same issue in modules/lab/manifests/datastore_writer_prod.pp
,
Oct 26 2016
done in that module too
,
Oct 26 2016
Are you referring to: https://chrome-internal-review.googlesource.com/#/c/299937/3/puppet/modules/lab/manifests/datastore_writer_prod.pp It still has: File[$chrome_infra_service_accounts_dir]
,
Nov 3 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dshi@chromium.org
, Oct 25 2016Status: Assigned (was: Untriaged)