New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659318 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

compare_samples is broken when missing metric

Project Member Reported by robert...@chromium.org, Oct 25 2016

Issue description

If the output for one of the runs does not contain the metric, compare_samples should not fail, instead it should proceed with the available data.

https://build.chromium.org/p/tryserver.chromium.perf/builders/staging_mac_10_10_perf_bisect/builds/14/steps/Re-testing%20reference%20range.Compare%20samples/logs/stdio
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d39f07766d7980d4ae46a614e85d5b37ca166e4

commit 7d39f07766d7980d4ae46a614e85d5b37ca166e4
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Oct 27 01:11:52 2016

Roll src/third_party/catapult/ 6097744b7..eeeba06a9 (6 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6097744b73fe..eeeba06a9874

$ git log 6097744b7..eeeba06a9 --date=short --no-merges --format='%ad %ae %s'
2016-10-26 rnephew [Telemetry] Move from telemetry WaitFor to py_utils WaitFor
2016-10-26 benjhayden Relax RelatedHistogramBreakdown restrictions.
2016-10-26 jbudorick [telemetry] No more raw adb calls!
2016-10-26 eakuefner [Telemetry] Remove --output-format=html2
2016-10-26 benjhayden Allow Histogram to have a singular bin.
2016-10-26 robertocn compare_samples should not fail when runs contain no data.

BUG= 623989 , 659318 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2455523003
Cr-Commit-Position: refs/heads/master@{#427901}

[modify] https://crrev.com/7d39f07766d7980d4ae46a614e85d5b37ca166e4/DEPS

Comment 2 by dtu@chromium.org, Nov 2 2016

Status: Fixed (was: Started)
Components: Speed>Bisection

Sign in to add a comment