New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 659300 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Oct 2016
Cc:
█ bradnelson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Both unit_tests and unittests are valid ninja targets

Project Member Reported by yusukes@chromium.org, Oct 25 2016 
Version: tot, r427453

What steps will reproduce the problem?

(1) $ gn gen out/Release --args='is_debug=false use_goma=true target_os="chromeos" is_component_build=true remove_webcore_debug_symbols=true'
(2) $ ninja -C out/Release -j1000 unit_tests
(3) $ ninja -C out/Release -j1000 unittests


What is the expected output?

2) succeeds but 3) fails.


What do you see instead?

Both unit_tests and unittests are valid ninja targets, and because of this, both succeed.
unit_tests are Chrome's unit tests of course, and unittests are for WASM probably?


Please use labels and text to provide additional information.

What about using a more descriptive target name like 'wasm_unittests' for the latter? It took me 10 minutes or so to figure out why 'ninja unittests' did not rebuild my Chrome tests...

I only tested with target_os=chromeos, but Windows, Mac, and Linux builds likely have the same issue.

Comment 1 by yusukes@chromium.org, Oct 25 2016 

+bradnelson
Brad, could you triage?

Comment 2 by pkasting@chromium.org, Oct 25 2016

Cc: -pkasting@chromium.org
Not sure why I was on this one?

Comment 3 by bradnelson@chromium.org, Oct 30 2016

Status: WontFix (was: Untriaged)
Wasn't able to repro this.
In any event, the unit_tests vs unittests naming difference comes from V8 general.
I.e. the wasm unittests are just included in the v8 unittest target.

It may be the case we'd want to rename v8's unittests to something else (maybe same as chrome, maybe something like v8_unittests), but on the other hand, it's been this way for quite some time and that doesn't mesh well with v8 making sense stand-alone.
►

Sign in to add a comment