New issue
Advanced search Search tips

Issue 659286 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----

Blocking:
issue 649343



Sign in to add a comment

Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose

Project Member Reported by foolip@chromium.org, Oct 25 2016

Issue description

https://w3c.github.io/webrtc-pc/#rtcpeerconnectioniceevent

Per https://bugs.chromium.org/p/chromium/issues/detail?id=649343#c13 RTCPeerConnectionIceEvent will be exposed in Edge 15, and is already shipping in Firefox.

This should be a fairly simple change.
 
Filed https://github.com/w3c/webrtc-pc/issues/910 which needs to be resolved first.
Owner: lunalu@chromium.org
Status: Assigned (was: Untriaged)
lunalu@, could you take a look at this as well? It'll be very similar to  issue 658428 . Just a few things to keep in mind. First, the spec has an url attribute on RTCPeerConnectionIceEvent, but it's not in Gecko:
https://github.com/mozilla/gecko-dev/blob/master/dom/webidl/RTCPeerConnectionIceEvent.webidl

Since it can be feature detected when added later, I think it's fine to expose the event without adding url, but it might be worth a few minutes to see if it would be trivial to support.

Second, both the RTCPeerConnectionIceEventInit candidate member and the RTCPeerConnectionIceEvent candidate attribute need to be nullable. The spec change for that has already been made in https://github.com/w3c/webrtc-pc/pull/863 but isn't live at https://w3c.github.io/webrtc-pc/#idl-def-rtcpeerconnectioniceeventinit yet.
Status: Started (was: Assigned)
Components: Blink>WebRTC>PeerConnection
Components: -Blink>WebRTC>Network
Changed label to PeerConnection, since this is more a Blink issue than an ICE protocol issue.

Comment 7 by foolip@chromium.org, Nov 11 2016

Labels: -Type-Bug OWP-Standards-OfficialSpec OWP-Type-ChangeAPI Type-Launch-OWP
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/581c687738c58a871ba5310211d8307244bf07b6

commit 581c687738c58a871ba5310211d8307244bf07b6
Author: lunalu <lunalu@chromium.org>
Date: Wed Nov 16 18:27:47 2016

Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/iMEnDLH_oJk/h2ZB9Sv8AQAJ

Note:
1. The url attribute on RTCPeerConnectionIceEvent is not added (it is
not currently in Gecko).
2. The candidate member of RTCIceCandidateEvent and RTCIceCandidateEventInit is
made nullable.
Specs:
https://w3c.github.io/webrtc-pc/#idl-def-rtcicecandidateeventinit

BUG= 659286 

Review-Url: https://codereview.chromium.org/2494553002
Cr-Commit-Position: refs/heads/master@{#432565}

[add] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html
[modify] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/Source/modules/peerconnection/BUILD.gn
[delete] https://crrev.com/a877ad3e0cc023956bd38fcf9018b028ba35f15e/third_party/WebKit/Source/modules/peerconnection/RTCIceCandidateEvent.cpp
[modify] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[add] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.cpp
[rename] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.h
[rename] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.idl
[add] https://crrev.com/581c687738c58a871ba5310211d8307244bf07b6/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEventInit.idl

Comment 9 by lunalu@chromium.org, Nov 16 2016

Status: Fixed (was: Started)
Labels: M-57
Labels: -M-57 M-56
Owner: loonyb...@chromium.org

Sign in to add a comment