net/quic/core/quic_connection.cc QuicConsumedData QuicConnection::SendStreamData No fault handler in fast path
Reported by
michael_...@hotmail.com,
Oct 25 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36 Steps to reproduce the problem: Found via static analysis What is the expected behavior? What went wrong? Possible semantic error (verification) Did this work before? N/A Chrome version: 53.0.2785.143 Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0 Is there a fault handler for packet_generator_.ConsumeDataFastPath()?
,
Oct 26 2016
Can you explain what you mean by a fault handler?
,
Nov 2 2016
Specifically:
if (id != kCryptoStreamId && !packet_generator_.HasQueuedFrames() &&
iov.total_length > kMaxPacketSize) {
// Use the fast path to send full data packets.
--> return packet_generator_.ConsumeDataFastPath(id, iov, offset, fin,
listener);
}
return packet_generator_.ConsumeData(id, iov, offset, fin, listener);
}
If this fails, is there any fall-back to handle it in the slow-path, or re-attempt it?
,
Nov 3 2017
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 7 2017
This has now been fixed, see the updated version of QuicPacketGenerator::ConsumeData https://cs.chromium.org/chromium/src/net/quic/core/quic_packet_generator.cc?q=quic_packet_gener&sq=package:chromium&l=54 |
||||
►
Sign in to add a comment |
||||
Comment 1 by kkaluri@chromium.org
, Oct 26 2016