Make WebBluetooth chooser consistent on Android and desktops |
||||||||||||||||||
Issue descriptionOn Android and desktops: 1. Remove "Not seeing your device?" string. 2. Remove the period at "No Bluetooth devices found.", "No devices found." 3. Show get help link and status text below the chooser: (a) When the Bluetooth is turned off, show "Get help" link text. (b) When scanning, show "Get help Scanning for devices...", the "Get help" is link text, "Scanning for devices..." is plain text. (c) When scanning and found some device, or scanning is complete, show "Get help or re-scan", both "Get help" and "re-scan" are link text.
,
Oct 26 2016
,
Oct 26 2016
,
Oct 26 2016
,
Oct 26 2016
Thanks for logging the bug. I would say 3b needs something between the "get help" and the "scanning" bit, otherwise they run together as a sentence. Two options: I) <a>Get help</> - Scanning for devices... II) <a>Get help</> while scanning for devices... III) <a>Get help</> | Scanning for devices... I think I like (II), even though it's longer because it sort of matches the "or" sentence structure in the re-scan. How about you? Also - do you need mocks for anything or can you work off this OK?
,
Oct 27 2016
I also think (II) is good. No mocks are needed. Thanks!
,
Oct 31 2016
,
Nov 1 2016
,
Nov 2 2016
some screenshots on ChromeOS.
,
Nov 2 2016
Look great! I can add these to the deck if you think they are ready too?
,
Nov 2 2016
,
Nov 2 2016
Yes, I think they are ready on ChromeOS. I will also implement it on Mac too and will upload the screenshots once it is done.
,
Nov 3 2016
,
Nov 4 2016
Some screenshots from Android.
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe commit 2e52a5a282f509f48e397626f5fcd30f5ab8b1fe Author: juncai <juncai@chromium.org> Date: Fri Nov 04 16:44:09 2016 Make WebBluetooth chooser consistent on Android and desktops (desktop part) This CL makes the following changes: 1. Remove "Not seeing your device?" string. 2. Remove the period at "No Bluetooth devices found.", "No devices found." 3. Show get help link and scanning status text below the chooser: (a) When the Bluetooth is turned off, show "Get help" link text. (b) When scanning, show "Get help while scanning for devices...", the "Get help" is link text, "while scanning for devices..." is plain text. (c) When scanning and found some device, or scanning is complete, show "Get help or re-scan", both "Get help" and "re-scan" are link text. I uploaded some screenshots from ChromeOS and Mac on the issue page. BUG= 659271 Review-Url: https://codereview.chromium.org/2468403002 Cr-Commit-Position: refs/heads/master@{#429914} [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/app/generated_resources.grd [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/browser/ui/cocoa/chooser_content_view_cocoa.h [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/browser/ui/views/chooser_content_view.cc [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/browser/ui/views/chooser_content_view.h [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/browser/ui/views/chooser_content_view_unittest.cc [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/browser/ui/views/extensions/chooser_dialog_view.cc [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/browser/ui/views/extensions/chooser_dialog_view.h [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc [modify] https://crrev.com/2e52a5a282f509f48e397626f5fcd30f5ab8b1fe/ui/views/controls/styled_label.h
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f17a6151a8d9d63087df4e0631e3e29b1414b7a commit 5f17a6151a8d9d63087df4e0631e3e29b1414b7a Author: juncai <juncai@chromium.org> Date: Fri Nov 04 23:04:50 2016 Make WebBluetooth chooser consistent on Android and desktops (Android part) This CL makes the following changes: 1. Remove "Not seeing your device?" string. 2. Remove the period at "No Bluetooth devices found.", "No devices found." 3. Show get help link and scanning status text below the chooser: (a) When the Bluetooth is turned off, show "Get help" link text. (b) When scanning, show "Get help while scanning for devices...", the "Get help" is link text, "while scanning for devices..." is plain text. (c) When scanning and found some device, or scanning is complete, show "Get help or re-scan", both "Get help" and "re-scan" are link text. I uploaded some screenshots on the issue page. BUG= 659271 Review-Url: https://codereview.chromium.org/2472723005 Cr-Commit-Position: refs/heads/master@{#430055} [modify] https://crrev.com/5f17a6151a8d9d63087df4e0631e3e29b1414b7a/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java [modify] https://crrev.com/5f17a6151a8d9d63087df4e0631e3e29b1414b7a/chrome/android/java/strings/android_chrome_strings.grd
,
Nov 7 2016
,
Nov 8 2016
"Chrome for Android" -Verified in 56.0.2913.4 build |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by juncai@chromium.org
, Oct 26 2016