New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 659269 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Nov 2017
Cc:
█ sureshkumari@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

content/child/web_url_loader_impl.cc void WebURLLoaderImpl::Context::Start fast path no fault handler to fall back to slow path

Reported by michael_...@hotmail.com, Oct 25 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36

Steps to reproduce the problem:
Found via static analysis

What is the expected behavior?

What went wrong?
Possible semantic error (verification)

Did this work before? N/A 

Chrome version: 53.0.2785.143  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0

In if (CanHandleDataURLRequestLocally), is there a fault handler for failure in the GetInfo?

Comment 1 by sureshkumari@chromium.org, Oct 26 2016

Labels: Needs-Feedback
Owner: sureshkumari@chromium.org
Could you please provide the steps and your expected behaviour to reproduce the issue.

Thanks.

Comment 2 by sureshkumari@chromium.org, Oct 26 2016

Cc: sureshkumari@chromium.org
Owner: ----

Comment 3 by michael_...@hotmail.com, Oct 27 2016 

Specifically in this fast path:

if (CanHandleDataURLRequestLocally()) {
    if (sync_load_response) {
      // This is a sync load. Do the work now.
      sync_load_response->url = url;
      sync_load_response->error_code =
          GetInfoFromDataURL(sync_load_response->url, sync_load_response,
                             &sync_load_response->data);
    } else {
      task_runner_->PostTask(FROM_HERE,
                             base::Bind(&Context::HandleDataURL, this));
    }
    return;
  }

If GetInfoFromDataURL can fail (implied by an error code assignment), can the fault be  handled in slow-path, or is it ok to leave it to the caller?  Currently it returns immediately regardless of the output of GetInfoFromDataURL.

Comment 4 by sureshkumari@chromium.org, Oct 28 2016 

 Issue 659268  has been merged into this issue.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 4 2016

Labels: -Needs-Feedback Needs-Review
Owner: sureshkumari@chromium.org
Thank you for providing more feedback. Adding requester "sureshkumari@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by sureshkumari@chromium.org, Nov 15 2016

Labels: -Needs-Review TE-NeedsTriageHelp
Owner: ----
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 15 2017

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment