New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 659251 link

Starred by 1 user
Status: Duplicate
Merged: issue 657946
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
█ junov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 634542



Sign in to add a comment

Display color managed canvas

Project Member Reported by zakerinasab@chromium.org, Oct 25 2016 

As observed in codereview.chromium.org/2448583002/ the linear-rgb color managed canvas is correctly displayed in chrome and content_shell binaries, but it doesn’t appear when running a layout test. This is due to the different compositing path in layout test mode. This must be fixed such that regular layout tests can be used in color managed canvas CLs.

Steps to repro:
(1) From codereview.chromium.org/2448583002/ copy the pixel test to LayoutTests directory.
(2) Remove colorSpace:'linear-rgb' from context creation part and save the page as -expected.html.
(3) Use chrome or content_shell binary (ToT) to open the layout test. Note the blue box.
(4) Run run-webkit-tests and see the output.

Result: The actual png generated by run-webkit-tests does not display the expected output (a blue box).

Comment 1 by zakerinasab@chromium.org, Nov 2 2016

Summary: Display color managed canvas (was: Display color managed canvas in layout tests)
In the description in step 3 it has been mentioned that chrome and content shell can display the color managed canvas. This is not the expected behavior and must be fixed as in this case the color space information is not spread properly. This must be fixed first and then the color space managed canvas issue must be addressed for both regular use and layout tests.

Comment 2 by zakerinasab@chromium.org, Nov 2 2016

Mergedinto: 657946
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6ca4583cfe1d240959b65a42ea52c8afb515bdb

commit c6ca4583cfe1d240959b65a42ea52c8afb515bdb
Author: zakerinasab <zakerinasab@chromium.org>
Date: Wed Nov 02 22:25:16 2016

Disable display list for 2D canvas when the canvas is color managed

For now display list is supported for 2D canvas only if the color space
is legacy-srgb. If it is not, display list must be disabled.

BUG= 659251 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2472783002
Cr-Commit-Position: refs/heads/master@{#429419}

[modify] https://crrev.com/c6ca4583cfe1d240959b65a42ea52c8afb515bdb/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/c6ca4583cfe1d240959b65a42ea52c8afb515bdb/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Comment 4 by zakerinasab@chromium.org, Nov 27 2017

Blocking: 634542
►

Sign in to add a comment