Issue metadata
Sign in to add a comment
|
WorkerProcessLauncherTest.Crash failing on dbg win/clang bots |
||||||||||||||||||||||
Issue descriptione.g. https://build.chromium.org/p/chromium.fyi/builders/CrWinClngLLDdbg%20tester/builds/1891 https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%28dbg%29%20tester/builds/2884 https://build.chromium.org/p/chromium.fyi/builders/CrWinClngLLD64dbg%20tester/builds/1905 Also failing with pinned clang, so not a clang trunk regression: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29%20tester/builds/7682 https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29%20tester/builds/3807 Only failing on dbg bots. Probably caused by https://codereview.chromium.org/2424353002 -- sammc, have you heard of breakage on other bots? Or is this clang-specific somehow?
,
Oct 25 2016
It's failing on Win7 Tests (dbg)(1) too. Definitely points to that change. I'm disabling the test now. https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29?numbuilds=50
,
Oct 25 2016
Why not revert the CL?
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4af028e242ed5275e2241f291df47557ec57101b commit 4af028e242ed5275e2241f291df47557ec57101b Author: dmazzoni <dmazzoni@chromium.org> Date: Tue Oct 25 21:48:56 2016 Disabling WorkerProcessLauncherTest.Crash It's failing on Win dbg bots BUG= 659219 TBR=sammc@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2450063002 Cr-Commit-Position: refs/heads/master@{#427493} [modify] https://crrev.com/4af028e242ed5275e2241f291df47557ec57101b/remoting/host/win/worker_process_launcher_unittest.cc
,
Oct 26 2016
@thakis is right, I should have reverted the change. Since there's no response from an owner I'm going to revert the change now and then un-disable the test.
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eca3c23df63fc990a8e65f5249a4b8d1a5ce296b commit eca3c23df63fc990a8e65f5249a4b8d1a5ce296b Author: dmazzoni <dmazzoni@chromium.org> Date: Wed Oct 26 21:33:26 2016 Revert of Disabling WorkerProcessLauncherTest.Crash (patchset #1 id:1 of https://codereview.chromium.org/2450063002/ ) Reason for revert: Re-enabling now that "Use ChannelMojo between the remoting daemon and network processes" is reverted ( https://codereview.chromium.org/2424353002/) http://crbug.com/659219 Original issue's description: > Disabling WorkerProcessLauncherTest.Crash > > It's failing on Win dbg bots > > BUG= 659219 > TBR=sammc@chromium.org > NOTRY=true > > Committed: https://crrev.com/4af028e242ed5275e2241f291df47557ec57101b > Cr-Commit-Position: refs/heads/master@{#427493} TBR=sammc@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 659219 Review-Url: https://codereview.chromium.org/2444193008 Cr-Commit-Position: refs/heads/master@{#427811} [modify] https://crrev.com/eca3c23df63fc990a8e65f5249a4b8d1a5ce296b/remoting/host/win/worker_process_launcher_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cf811aefdaae1373a2a47c8268be8c201385e72 commit 7cf811aefdaae1373a2a47c8268be8c201385e72 Author: sammc <sammc@chromium.org> Date: Thu Oct 27 23:10:00 2016 Change WorkerProcessLauncherTest to use ChannelMojo. This also fixes a race in WorkerProcessLauncherTest.Crash where the Crash IPC was received after the fake process had been killed and relaunched. This caused the new fake process to be unexpectedly killed. BUG= 604282 , 659219 Review-Url: https://codereview.chromium.org/2448243004 Cr-Commit-Position: refs/heads/master@{#428191} [modify] https://crrev.com/7cf811aefdaae1373a2a47c8268be8c201385e72/remoting/host/win/worker_process_launcher_unittest.cc
,
Nov 2 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by r...@chromium.org
, Oct 25 2016