Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 659212 Actually update FieldTrialEntry's activated field
Starred by 1 user Reported by lawrencewu@chromium.org, Oct 25 2016 Back to list
Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
Currently, each field trial entry's activated field is set only once, when the field trial has been activated. We need to create the field trial entry earlier (when the group has been chosen in FinalizeGroupChoice()), and make sure to actually update the field when the field trial gets activated.
 
Project Member Comment 1 by bugdroid1@chromium.org, Oct 26 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/986a6385750dae1120a89c49be4ddf3f6a707ce0

commit 986a6385750dae1120a89c49be4ddf3f6a707ce0
Author: lawrencewu <lawrencewu@chromium.org>
Date: Wed Oct 26 18:19:16 2016

Actually update FieldTrialEntry's activated field

This changes moves the creation of the field trial entry in shared
memory a earlier, in FinalizeGroupChoice(), and sets the "activated"
field on the entry in NotifyFieldTrialGroupSelection(). We still create
the allocator lazily.

BUG= 659212 

Review-Url: https://codereview.chromium.org/2449143002
Cr-Commit-Position: refs/heads/master@{#427749}

[modify] https://crrev.com/986a6385750dae1120a89c49be4ddf3f6a707ce0/base/metrics/field_trial.cc
[modify] https://crrev.com/986a6385750dae1120a89c49be4ddf3f6a707ce0/base/metrics/field_trial.h

Status: Fixed
Sign in to add a comment