Remove base/test/ios/wait_util |
|||||||
Issue descriptionTests should not be waiting and spinning until a condition. It would be better to have a cleaner approach with callbacks where it blocks. Other instances of Chromium spin a RunLoop, then post a QuitTask.
,
Oct 26 2016
base/test/ios/wait_util would work better under ios/testing. We should also look into removing the DCHECK on failure, though this may affect a lot of unit tests, and may not be worth the churn.
,
Oct 27 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 27 2017
I think it still makes sense to do this, but P3 is correct prioritization.
,
Oct 29
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 29
Do you know if this should be closed? This has been open since 2016.
,
Oct 30
I'd close that stale bug for couple of years, also because we are doing EG1 -> EG2 migration with refactoring. It can be re-opened if that is important.
,
Oct 30
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by baxley@chromium.org
, Oct 25 2016