New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659208 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove base/test/ios/wait_util

Project Member Reported by baxley@chromium.org, Oct 25 2016

Issue description

Tests should not be waiting and spinning until a condition. It would be better to have a cleaner approach with callbacks where it blocks. Other instances of Chromium spin a RunLoop, then post a QuitTask.
 

Comment 1 by baxley@chromium.org, Oct 25 2016

Summary: Remove base/test/ios/wait_util (was: Remove use of wait_util in tests)

Comment 2 by baxley@chromium.org, Oct 26 2016

Components: -Test Test>iOS
base/test/ios/wait_util would work better under ios/testing.

We should also look into removing the DCHECK on failure, though this may affect a lot of unit tests, and may not be worth the churn.
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 27 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by baxley@chromium.org, Oct 27 2017

Status: Available (was: Untriaged)
I think it still makes sense to do this, but P3 is correct prioritization.
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 29

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -baxley@chromium.org -liaoyuke@chromium.org -huangml@chromium.org linds...@chromium.org ericale@chromium.org
Owner: yzjr@chromium.org
Status: Assigned (was: Untriaged)
Do you know if this should be closed? This has been open since 2016.
I'd close that stale bug for couple of years, also because we are doing EG1 -> EG2 migration with refactoring.  

It can be re-opened if that is important. 
Status: WontFix (was: Assigned)

Sign in to add a comment