MacViews: After showing context menu the subsequent mouse down event will be eaten
Reported by
mbl...@yandex-team.ru,
Oct 25 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.101 YaBrowser/16.10.0.1732 (beta) Safari/537.36 Steps to reproduce the problem: 1. Open Chromium, open two tabs with some URLs 2. Close the second tab 3. Right-click the first tab and select Reopen Closed Tab 4. Click on the second tab What is the expected behavior? The second tab should be activated (or closed, if clicked on the close button). What went wrong? The first tab gets activated instead. Did this work before? N/A Chrome version: 53.0.2785.101 Channel: n/a OS Version: OS X 10.11.6 Flash Version:
,
Oct 31 2016
Assigning to tapted@ as CL reviewer.
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c329b603044633b6ff0b2f17b2dfc5a1f1200ffa commit c329b603044633b6ff0b2f17b2dfc5a1f1200ffa Author: mblsha <mblsha@yandex-team.ru> Date: Thu Nov 03 19:39:38 2016 MacViews: Clear mouse handler when showing context menus. Currently the View that invokes a menu may incorrectly retain capture and swallow subsequent mouse events. To fix we explicitly clear mouse handler when showing context menus. This same issue was previously fixed individually within ToolbarButton (r15) and Combobox (r83617) before the common fix inside MenuController (r192688). On MacViews the MenuController is not used, and we have the MenuRunnerImplCocoa which didn't contain the fix for this issue. Move the fix to the common place that's shared between all the implementations of MenuRunnerImplInterface. BUG= 659204 TEST=Open Chromium, open two tabs with non-empty URLs; Close the second tab; Right-click the first tab and select Reopen Closed Tab; Click on the second tab. Second tab should activate. See crbug.com/659204 for video. Review-Url: https://codereview.chromium.org/2450903002 Cr-Commit-Position: refs/heads/master@{#429673} [modify] https://crrev.com/c329b603044633b6ff0b2f17b2dfc5a1f1200ffa/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/c329b603044633b6ff0b2f17b2dfc5a1f1200ffa/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/c329b603044633b6ff0b2f17b2dfc5a1f1200ffa/ui/views/controls/menu/menu_controller.cc [modify] https://crrev.com/c329b603044633b6ff0b2f17b2dfc5a1f1200ffa/ui/views/controls/menu/menu_runner.cc [modify] https://crrev.com/c329b603044633b6ff0b2f17b2dfc5a1f1200ffa/ui/views/controls/menu/menu_runner_unittest.cc
,
Mar 24 2017
This seems fixed in #3. tapted@, flip the status?
,
Nov 1 2017
,
Oct 25
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mbl...@yandex-team.ru
, Oct 26 2016