New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659202 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Proposal for changing gs offloading on moblab

Project Member Reported by krk@chromium.org, Oct 25 2016

Issue description

From the email thread -

Proposal:  Extend gs_offloader so it can upload the data to GCS when the tests are one age, but delete them at some later date.

So currently gs_offloader has the param days_old - the proposal is to add 2 more upload_days_old and delete_days_old, the existing param would stay as is with the same functionality.

This will allow us to run gs_offloader with X = 0 days to immediately upload data just as soon as the test completes but not delete the data until 1 or 2 days later.


- implementation does not involve any db interaction

- implementation relies on the two discreet values for when to copy and when to delete.  The days_ago command parameter will just set these to the same value.
 

Comment 1 by krk@chromium.org, Nov 9 2016

Labels: M-56
Punting this to 56 - Keith is that OK?
We will probably ask for another 55 release when this is done but at the moment it is not ready and I understand you need to push 55

Comment 3 by krk@chromium.org, Nov 10 2016

Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5ba5fb86d92a242691def5fc87ff35e51497b2ae

commit 5ba5fb86d92a242691def5fc87ff35e51497b2ae
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Nov 09 19:39:36 2016

Autotest: change gs_offloader to seperate upload age from delete age.

Currently gs_offloader has a single param to select how old a job
should be before it is uploaded and deleted.

Introduce two new params one to select how old the job is when it is
uploaded, and a second when it is deleted.

If these params are the same or the original param is set the
functionality of gs_offloader should be the same.

BUG= chromium:659202 
TEST=local testing on moblab, ran/fixed available unit tests.

Change-Id: I91e63ba39ddbd8c0ea408c3f5111eead76eaa0f7
Reviewed-on: https://chromium-review.googlesource.com/410060
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/5ba5fb86d92a242691def5fc87ff35e51497b2ae/site_utils/gs_offloader_unittest.py
[modify] https://crrev.com/5ba5fb86d92a242691def5fc87ff35e51497b2ae/site_utils/job_directories.py
[modify] https://crrev.com/5ba5fb86d92a242691def5fc87ff35e51497b2ae/site_utils/gs_offloader.py

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16 2016

Labels: merge-merged-release-R55-8872.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/15950c5bef8226bbcdef876abb8bcb92d8b4b85c

commit 15950c5bef8226bbcdef876abb8bcb92d8b4b85c
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Nov 09 19:39:36 2016

Autotest: change gs_offloader to seperate upload age from delete age.

Currently gs_offloader has a single param to select how old a job
should be before it is uploaded and deleted.

Introduce two new params one to select how old the job is when it is
uploaded, and a second when it is deleted.

If these params are the same or the original param is set the
functionality of gs_offloader should be the same.

BUG= chromium:659202 
TEST=local testing on moblab, ran/fixed available unit tests.

Change-Id: I91e63ba39ddbd8c0ea408c3f5111eead76eaa0f7
Reviewed-on: https://chromium-review.googlesource.com/410060
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
(cherry picked from commit 5ba5fb86d92a242691def5fc87ff35e51497b2ae)
Reviewed-on: https://chromium-review.googlesource.com/412022
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/15950c5bef8226bbcdef876abb8bcb92d8b4b85c/site_utils/gs_offloader_unittest.py
[modify] https://crrev.com/15950c5bef8226bbcdef876abb8bcb92d8b4b85c/site_utils/job_directories.py
[modify] https://crrev.com/15950c5bef8226bbcdef876abb8bcb92d8b4b85c/site_utils/gs_offloader.py

Status: Fixed (was: Assigned)

Sign in to add a comment