New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 659199 link

Starred by 1 user
Status: Fixed
Owner:
s...@chromium.org
Closed: Oct 2016
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

DeviceInfoService::SendLocalData crashes when pulse triggers and signed out

Project Member Reported by s...@chromium.org, Oct 25 2016 
https://cs.chromium.org/chromium/src/components/sync/device_info/device_info_service.cc?l=406

When signed out, local_device_info_provider_->GetLocalDeviceInfo() returns nullptr. When SendLocalData triggers, we try to deref nullptr and segfault.

To manually test this, you can change pulse interval to 1 second, and then as soon as you sign out, we blow up.

Comment 1 by s...@chromium.org, Oct 25 2016 

I think this may have started when https://codereview.chromium.org/1951703002 landed, but the fault is definitely in DeviceInfoService. It was relying on a bad assumption.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f4ce13727c8054995dc2fb2cd510b706107907c

commit 5f4ce13727c8054995dc2fb2cd510b706107907c
Author: skym <skym@chromium.org>
Date: Wed Oct 26 15:07:13 2016

Sending local data avoid derefing null if the local provider no longer has data.

BUG= 659199 

Review-Url: https://codereview.chromium.org/2452523003
Cr-Commit-Position: refs/heads/master@{#427691}

[modify] https://crrev.com/5f4ce13727c8054995dc2fb2cd510b706107907c/components/sync/device_info/device_info_service.cc
[modify] https://crrev.com/5f4ce13727c8054995dc2fb2cd510b706107907c/components/sync/device_info/device_info_service_unittest.cc

Comment 3 by s...@chromium.org, Oct 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment