New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659195 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

mojo_js_integration_tests are noisy

Project Member Reported by roc...@chromium.org, Oct 25 2016

Issue description

too much logging!

<snip>
JsToCppTest.BackPointer (run #1):
<truncated (76869 bytes)>
CTED_ARRAY_HEADER
[21649:21649:1025/045349:6194913530:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194913543:ERROR:validation_errors.cc(83)] Invalid message: VALIDATION_ERROR_UNEXPECTED_ARRAY_HEADER
[21649:21649:1025/045349:6194913581:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194913595:ERROR:validation_errors.cc(83)] Invalid message: VALIDATION_ERROR_UNEXPECTED_ARRAY_HEADER
[21649:21649:1025/045349:6194913639:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194913652:ERROR:validation_errors.cc(83)] Invalid message: VALIDATION_ERROR_UNEXPECTED_ARRAY_HEADER
[21649:21649:1025/045349:6194913683:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194913696:ERROR:validation_errors.cc(83)] Invalid message: VALIDATION_ERROR_UNEXPECTED_ARRAY_HEADER
[21649:21649:1025/045349:6194913726:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194913739:ERROR:validation_errors.cc(83)] Invalid message: VALIDATION_ERROR_UNEXPECTED_ARRAY_HEADER
[21649:21649:1025/045349:6194913775:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194913796:ERROR:validation_errors.cc(83)] Invalid message: VALIDATION_ERROR_UNEXPECTED_ARRAY_HEADER
[21649:21649:1025/045349:6194913826:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194913878:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194913917:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194913956:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194913995:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194914042:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194914081:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194914118:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
[21649:21649:1025/045349:6194914157:ERROR:data_pipe_consumer_dispatcher.cc(443)] Failed to map shared buffer.
</snip>

 

Comment 1 by roc...@chromium.org, Oct 25 2016

Cc: jam@chromium.org phajdan.jr@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dafb77a4efa4ea0e6d2080ea239f401ff1c4a691

commit dafb77a4efa4ea0e6d2080ea239f401ff1c4a691
Author: rockot <rockot@chromium.org>
Date: Wed Nov 02 20:45:54 2016

Mojo: Suppress validation error logging in some tests

These errors are useful for developers when developers make mistakes,
but they make a mess of test logs. Disable them in tests which are
particularly noisy.

BUG= 659195 

Review-Url: https://codereview.chromium.org/2448203002
Cr-Commit-Position: refs/heads/master@{#429393}

[modify] https://crrev.com/dafb77a4efa4ea0e6d2080ea239f401ff1c4a691/mojo/edk/js/tests/js_to_cpp_tests.cc
[modify] https://crrev.com/dafb77a4efa4ea0e6d2080ea239f401ff1c4a691/mojo/public/cpp/bindings/lib/validation_errors.cc
[modify] https://crrev.com/dafb77a4efa4ea0e6d2080ea239f401ff1c4a691/mojo/public/cpp/bindings/lib/validation_errors.h

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3804c15d9dd121b800391b7467e5e53223d8373c

commit 3804c15d9dd121b800391b7467e5e53223d8373c
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Apr 12 17:15:17 2017

Add debugging CHECKs for data pipe serialization crash

It seems that somehow a data pipe consumer handle is losing its
internal shared buffer and this is crashing Mojo loading. This CL
adds some temporary CHECKs to attempt to pinpoint where things are
going wrong.

BUG=706689, 659195 
R=yzshen@chromium.org

Change-Id: I46d42a49ab233a1b7cacf5cd91fc57db0338ab1c
Reviewed-on: https://chromium-review.googlesource.com/474175
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464061}
[modify] https://crrev.com/3804c15d9dd121b800391b7467e5e53223d8373c/mojo/edk/embedder/platform_shared_buffer.cc
[modify] https://crrev.com/3804c15d9dd121b800391b7467e5e53223d8373c/mojo/edk/js/tests/js_to_cpp_tests.js
[modify] https://crrev.com/3804c15d9dd121b800391b7467e5e53223d8373c/mojo/edk/system/data_pipe_consumer_dispatcher.cc

Comment 4 by roc...@chromium.org, Apr 12 2017

Status: Fixed (was: Started)
The last of this spam should now be resolved.

Comment 5 by roc...@chromium.org, Apr 12 2017

For posterity, it was caused by hitting hard file descriptor limits in the Linux test environment. The CL above reduced the number of FDs used by the tests in order to unblock landing the rest of the change.

Sign in to add a comment