Migrate WorkerPool to TaskScheduler |
||||||||||
Issue descriptionWorkerPool is being deprecated in favor of TaskScheduler. TaskScheduler is a dynamic thread pool. Every task posted to TaskScheduler is associated with traits. The WithPriority() trait determines in which order tasks run. The WithShutdownBehavior() trait determines whether shutdown is blocked when a task is queued/running. The MayBlock()/WithBaseSyncPrimitives() traits determine whether a task makes blocking calls. More MayBlock()/WithBaseSyncPrimitives() tasks can be scheduled concurrently than CPU-bound tasks. TaskScheduler documentation can be found in these files: - base/task_scheduler/post_task.h - base/task_scheduler/task_traits.h TaskScheduler design doc: https://docs.google.com/document/d/1S2AAeoo1xa_vsLbDYBsDHCqhrkfiMgoIPlyRi6kxa5k/edit
,
Oct 31 2016
,
Nov 7 2016
,
Nov 28 2016
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d18421543cc20d9d37a5709e4c9d08eaa5e8e62 commit 7d18421543cc20d9d37a5709e4c9d08eaa5e8e62 Author: fdoray <fdoray@chromium.org> Date: Tue Nov 29 19:48:58 2016 Use TaskScheduler instead of WorkerPool in platform_keys.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits(). The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). No File IO (default): The task does not perform synchronous IO operations. No Wait (default): The task does not wait on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG= 659191 Review-Url: https://codereview.chromium.org/2534513002 Cr-Commit-Position: refs/heads/master@{#435057} [modify] https://crrev.com/7d18421543cc20d9d37a5709e4c9d08eaa5e8e62/chrome/browser/chromeos/platform_keys/platform_keys.cc
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ed46e5a16b6f0ce4ee88eb1a7fd1a05383261ec commit 1ed46e5a16b6f0ce4ee88eb1a7fd1a05383261ec Author: fdoray <fdoray@chromium.org> Date: Tue Nov 29 22:59:05 2016 Use TaskScheduler instead of WorkerPool in platform_keys_nss.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits(). The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). With File IO: The task waits on synchronous file IO operations. With Wait: The task waits on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG= 659191 Review-Url: https://codereview.chromium.org/2526283004 Cr-Commit-Position: refs/heads/master@{#435100} [modify] https://crrev.com/1ed46e5a16b6f0ce4ee88eb1a7fd1a05383261ec/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abd126d64704dc5e65e562d3337c311638b0439d commit abd126d64704dc5e65e562d3337c311638b0439d Author: fdoray <fdoray@chromium.org> Date: Wed Nov 30 18:28:22 2016 Use TaskScheduler instead of WorkerPool in thumbnail_cache.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits(). The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). No File IO (default): The task does not perform synchronous IO operations. No Wait (default): The task does not wait on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG= 659191 Review-Url: https://codereview.chromium.org/2531673002 Cr-Commit-Position: refs/heads/master@{#435346} [modify] https://crrev.com/abd126d64704dc5e65e562d3337c311638b0439d/chrome/browser/android/thumbnail/thumbnail_cache.cc
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c5994f99f82726f4bc6d26181f7b29f449c3416 commit 7c5994f99f82726f4bc6d26181f7b29f449c3416 Author: fdoray <fdoray@chromium.org> Date: Wed Nov 30 20:33:37 2016 Use TaskScheduler instead of WorkerPool in keystone_glue.mm. This CL replaces a base::WorkerPool::PostTask() call with a base::PostTaskWithTraits() call. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). With File IO: The task is allowed to perform synchronous IO operations. No Wait (default): The task does not wait on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG= 659191 Review-Url: https://codereview.chromium.org/2525483006 Cr-Commit-Position: refs/heads/master@{#435404} [modify] https://crrev.com/7c5994f99f82726f4bc6d26181f7b29f449c3416/chrome/browser/mac/keystone_glue.mm [modify] https://crrev.com/7c5994f99f82726f4bc6d26181f7b29f449c3416/chrome/browser/mac/keystone_glue_unittest.mm
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30824582b818b41f8b264eae2658a2878a7d9939 commit 30824582b818b41f8b264eae2658a2878a7d9939 Author: fdoray <fdoray@chromium.org> Date: Fri Dec 02 16:29:31 2016 Use TaskScheduler instead of WorkerPool in password_manager_util_win.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits() call. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). No File IO (default): The task does not perform synchronous IO operations. It spends most of its time using the CPU. With Wait: The task waits on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG= 659191 Review-Url: https://codereview.chromium.org/2527123004 Cr-Commit-Position: refs/heads/master@{#435948} [modify] https://crrev.com/30824582b818b41f8b264eae2658a2878a7d9939/chrome/browser/password_manager/password_manager_util_win.cc
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e32266ffc0f2401f27c9ac05fb0a881f899c619a commit e32266ffc0f2401f27c9ac05fb0a881f899c619a Author: fdoray <fdoray@chromium.org> Date: Fri Dec 02 19:39:17 2016 Use TaskScheduler instead of WorkerPool in sw_reporter_installer_win.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits() call. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). No File IO (default): The task does not perform synchronous IO operations. With Wait: The task waits on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG= 659191 Review-Url: https://codereview.chromium.org/2547693002 Cr-Commit-Position: refs/heads/master@{#435996} [modify] https://crrev.com/e32266ffc0f2401f27c9ac05fb0a881f899c619a/chrome/browser/component_updater/sw_reporter_installer_win.cc
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb096ca51bc796ac7916628ddbc00d8338c8340f commit cb096ca51bc796ac7916628ddbc00d8338c8340f Author: fdoray <fdoray@chromium.org> Date: Fri Dec 02 19:41:39 2016 Use TaskScheduler instead of WorkerPool in easy_unlock_tpm_key_manager.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits(). The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). With File IO: The task waits on synchronous file IO operations. With Wait: The task waits on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG= 659191 Review-Url: https://codereview.chromium.org/2528893004 Cr-Commit-Position: refs/heads/master@{#435998} [modify] https://crrev.com/cb096ca51bc796ac7916628ddbc00d8338c8340f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc [modify] https://crrev.com/cb096ca51bc796ac7916628ddbc00d8338c8340f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77c45323d49314e02224ad204cad09b8f052cf8e commit 77c45323d49314e02224ad204cad09b8f052cf8e Author: fdoray <fdoray@chromium.org> Date: Fri Dec 02 21:29:42 2016 Use TaskScheduler instead of WorkerPool in user_session_manager.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits() call. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). With file IO: The task is allowed to perform synchronous IO operations. No Wait (default): The task does not wait on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG= 659191 Review-Url: https://codereview.chromium.org/2542283002 Cr-Commit-Position: refs/heads/master@{#436033} [modify] https://crrev.com/77c45323d49314e02224ad204cad09b8f052cf8e/chrome/browser/chromeos/login/session/user_session_manager.cc
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c00462bd6aacdefa971db6a1d4c2354ccf913de commit 6c00462bd6aacdefa971db6a1d4c2354ccf913de Author: fdoray <fdoray@chromium.org> Date: Fri Dec 02 23:08:38 2016 Use TaskScheduler instead of WorkerPool in google_brand_chromeos.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits() call. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). With file IO: The task is allowed to perform synchronous IO operations. No Wait (default): The task does not wait on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG= 659191 Review-Url: https://codereview.chromium.org/2546863002 Cr-Commit-Position: refs/heads/master@{#436070} [modify] https://crrev.com/6c00462bd6aacdefa971db6a1d4c2354ccf913de/chrome/browser/google/google_brand_chromeos.cc
,
Dec 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14589e9ca09b5cf03be779b0c1158cc5388def05 commit 14589e9ca09b5cf03be779b0c1158cc5388def05 Author: fdoray <fdoray@chromium.org> Date: Sat Dec 03 00:04:30 2016 Use TaskScheduler instead of WorkerPool in client_cert_store_chromeos.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits(). The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). With File IO: The task waits on synchronous file IO operations. With Wait: The task waits on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG= 659191 Review-Url: https://codereview.chromium.org/2533473002 Cr-Commit-Position: refs/heads/master@{#436087} [modify] https://crrev.com/14589e9ca09b5cf03be779b0c1158cc5388def05/chrome/browser/chromeos/net/client_cert_store_chromeos.cc [modify] https://crrev.com/14589e9ca09b5cf03be779b0c1158cc5388def05/chrome/browser/chromeos/net/client_cert_store_chromeos_unittest.cc
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5695589b87938486b24f0e1f6dfb761ab7915ed1 commit 5695589b87938486b24f0e1f6dfb761ab7915ed1 Author: fdoray <fdoray@chromium.org> Date: Wed Dec 07 00:41:30 2016 Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits() call. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). With/without file IO: This CL contains both tasks that are allowed to perform synchronous IO operations and tasks that aren't. With/without Wait: This CL contains both tasks that wait on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system) and tasks that don't. TBR=jochen@chromium.org BUG= 659191 Review-Url: https://codereview.chromium.org/2548643002 Cr-Commit-Position: refs/heads/master@{#436787} [modify] https://crrev.com/5695589b87938486b24f0e1f6dfb761ab7915ed1/chrome/browser/component_updater/recovery_component_installer.cc
,
Dec 16 2016
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40a9803a7f6df4e31b7a1b5dbae1c800036e3e14 commit 40a9803a7f6df4e31b7a1b5dbae1c800036e3e14 Author: fdoray <fdoray@chromium.org> Date: Wed Dec 21 17:05:14 2016 Use TaskScheduler instead of WorkerPool in debug_daemon_client.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits() call. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). May block: Tasks may block. In particular, they may wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. Without sync primitives (default): Tasks are not allowed to wait on waitable events/condition variables or to join threads/processes. BUG= 659191 Review-Url: https://codereview.chromium.org/2547173002 Cr-Commit-Position: refs/heads/master@{#440132} [modify] https://crrev.com/40a9803a7f6df4e31b7a1b5dbae1c800036e3e14/chromeos/dbus/debug_daemon_client.cc
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e2697603c48a60c78ca99ad404251d2764ec9c2 commit 9e2697603c48a60c78ca99ad404251d2764ec9c2 Author: fdoray <fdoray@chromium.org> Date: Wed Dec 21 20:21:07 2016 Use TaskScheduler instead of WorkerPool in file_select_helper.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits() call. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits takes the priority of the task that creates it). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). May Block: Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. No Sync Primitives (default): Tasks are not allowed to wait on waitable events/condition variables or to join threads/processes. TBR=jochen@chromium.org BUG= 659191 Review-Url: https://codereview.chromium.org/2545723005 Cr-Commit-Position: refs/heads/master@{#440200} [modify] https://crrev.com/9e2697603c48a60c78ca99ad404251d2764ec9c2/chrome/browser/file_select_helper.cc
,
Jan 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39702ec4829b4889cc5400efb476e78d4f5eafaf commit 39702ec4829b4889cc5400efb476e78d4f5eafaf Author: fdoray <fdoray@chromium.org> Date: Mon Jan 02 21:08:31 2017 Use TaskScheduler instead of WorkerPool in url_data_manager_backend.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. Does Not Block (default): Tasks without the MayBlock() and WithBaseSyncPrimitives() traits may not block. BUG= 659191 Review-Url: https://codereview.chromium.org/2611443002 Cr-Commit-Position: refs/heads/master@{#441079} [modify] https://crrev.com/39702ec4829b4889cc5400efb476e78d4f5eafaf/content/browser/webui/url_data_manager_backend.cc
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0127fd25bd985f1f5f87c0a7c060d3159142086a commit 0127fd25bd985f1f5f87c0a7c060d3159142086a Author: fdoray <fdoray@chromium.org> Date: Tue Jan 03 17:07:03 2017 Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2609733002 Cr-Commit-Position: refs/heads/master@{#441139} [modify] https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f817d9ad97999d190dc84ec6b170c3224f20f6cd commit f817d9ad97999d190dc84ec6b170c3224f20f6cd Author: fdoray <fdoray@chromium.org> Date: Tue Jan 03 17:09:16 2017 Use TaskScheduler instead of WorkerPool in drm_display_host_manager.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2603153003 Cr-Commit-Position: refs/heads/master@{#441141} [modify] https://crrev.com/f817d9ad97999d190dc84ec6b170c3224f20f6cd/ui/ozone/platform/drm/host/drm_display_host_manager.cc
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e50d1af88c86663c21328705c890857e006ac50d commit e50d1af88c86663c21328705c890857e006ac50d Author: fdoray <fdoray@chromium.org> Date: Tue Jan 03 17:14:16 2017 Use TaskScheduler instead of WorkerPool in wallpaper_manager_base.cc. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2608953002 Cr-Commit-Position: refs/heads/master@{#441142} [modify] https://crrev.com/e50d1af88c86663c21328705c890857e006ac50d/components/wallpaper/wallpaper_manager_base.cc
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/375ad9dd131cbc748491195c7bb43bbcfefe76fa commit 375ad9dd131cbc748491195c7bb43bbcfefe76fa Author: fdoray <fdoray@chromium.org> Date: Tue Jan 03 19:18:35 2017 Use TaskScheduler instead of WorkerPool in page_handler.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. Does Not Block (default): Tasks without the MayBlock() and WithBaseSyncPrimitives() traits may not block. BUG= 659191 Review-Url: https://codereview.chromium.org/2608963002 Cr-Commit-Position: refs/heads/master@{#441180} [modify] https://crrev.com/375ad9dd131cbc748491195c7bb43bbcfefe76fa/content/browser/devtools/protocol/page_handler.cc
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e2b890a2d2663595aa141e3f70c1af94d46c897 commit 5e2b890a2d2663595aa141e3f70c1af94d46c897 Author: fdoray <fdoray@chromium.org> Date: Tue Jan 03 20:08:56 2017 Remove usage of WorkerPool from test_completion_callback_unittest.cc. WorkerPool is being deprecated. BUG= 659191 Review-Url: https://codereview.chromium.org/2606213003 Cr-Commit-Position: refs/heads/master@{#441198} [modify] https://crrev.com/5e2b890a2d2663595aa141e3f70c1af94d46c897/net/base/test_completion_callback_unittest.cc
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b818f0b639e940db0167e82e0bc071852d30dc0 commit 9b818f0b639e940db0167e82e0bc071852d30dc0 Author: fdoray <fdoray@chromium.org> Date: Wed Jan 04 04:27:15 2017 Use TaskScheduler instead of WorkerPool in navigation_entry_screenshot_manager.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. Does Not Block (default): Tasks without the MayBlock() and WithBaseSyncPrimitives() traits may not block. BUG= 659191 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2604343002 Cr-Commit-Position: refs/heads/master@{#441316} [modify] https://crrev.com/9b818f0b639e940db0167e82e0bc071852d30dc0/content/browser/frame_host/navigation_entry_screenshot_manager.cc
,
Jan 4 2017
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd81dc85f06fef7812a8f9ece1045ee556d84b8e commit fd81dc85f06fef7812a8f9ece1045ee556d84b8e Author: fdoray <fdoray@chromium.org> Date: Wed Jan 04 19:14:48 2017 Use TaskScheduler instead of WorkerPool in gesture_feedback.cc. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2611463002 Cr-Commit-Position: refs/heads/master@{#441426} [modify] https://crrev.com/fd81dc85f06fef7812a8f9ece1045ee556d84b8e/ui/events/ozone/evdev/libgestures_glue/gesture_feedback.cc
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4d76b8d9b4e8be381f8d5764de65cfdd36f8c8c commit d4d76b8d9b4e8be381f8d5764de65cfdd36f8c8c Author: fdoray <fdoray@chromium.org> Date: Wed Jan 04 19:16:50 2017 Use TaskScheduler instead of WorkerPool in xkb_keyboard_layout_engine.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2611473002 Cr-Commit-Position: refs/heads/master@{#441428} [modify] https://crrev.com/d4d76b8d9b4e8be381f8d5764de65cfdd36f8c8c/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/662d1d2635e6d2abc8d6ef9ac6918efac6e7dc4f commit 662d1d2635e6d2abc8d6ef9ac6918efac6e7dc4f Author: fdoray <fdoray@chromium.org> Date: Wed Jan 04 19:30:17 2017 Use TaskScheduler instead of WorkerPool in device_manager_manual.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2603163002 Cr-Commit-Position: refs/heads/master@{#441436} [modify] https://crrev.com/662d1d2635e6d2abc8d6ef9ac6918efac6e7dc4f/ui/events/ozone/device/device_manager_manual.cc
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b42f8092f30184dda0b785d26fdf7538c394220 commit 2b42f8092f30184dda0b785d26fdf7538c394220 Author: afakhry <afakhry@chromium.org> Date: Wed Jan 04 20:00:40 2017 Revert of Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. (patchset #2 id:20001 of https://codereview.chromium.org/2609733002/ ) Reason for revert: Causes the UI to crash on peach_pit and multiple HWTest failures on the PFQ and the informational builder. See BUG= 678296 . Original issue's description: > Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. > > The following traits are used: > > Priority: Inherited (default) > The priority is inherited from the calling context (i.e. TaskTraits > are initialized with the priority of the current task). > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > Note: Tasks that were previously posted to base::WorkerPool should > use this shutdown behavior because this is how base::WorkerPool > handles all its tasks. > > May Block: > Tasks posted with MayBlock() may block. This includes but is not > limited to tasks that wait on synchronous file I/O operations: > read or write a file from disk, interact with a pipe or a socket, > rename or delete a file, enumerate files in a directory, etc. This > trait isn't required for the mere use of locks. > > BUG= 659191 > > Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a > Cr-Commit-Position: refs/heads/master@{#441139} TBR=dnicoara@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 659191 Review-Url: https://codereview.chromium.org/2612853002 Cr-Commit-Position: refs/heads/master@{#441438} [modify] https://crrev.com/2b42f8092f30184dda0b785d26fdf7538c394220/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e199d6993db574a00ccaffdd3a292347bd10e752 commit e199d6993db574a00ccaffdd3a292347bd10e752 Author: fdoray <fdoray@chromium.org> Date: Thu Jan 05 17:16:24 2017 Use TaskScheduler instead of WorkerPool in arc_notification_item.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. Does Not Block (default): Tasks without the MayBlock() and WithBaseSyncPrimitives() traits may not block. BUG= 659191 Review-Url: https://codereview.chromium.org/2603153002 Cr-Commit-Position: refs/heads/master@{#441680} [modify] https://crrev.com/e199d6993db574a00ccaffdd3a292347bd10e752/ui/arc/notification/arc_notification_item.cc
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9be76765fef84481195dd96339c8fa011257f402 commit 9be76765fef84481195dd96339c8fa011257f402 Author: fdoray <fdoray@chromium.org> Date: Thu Jan 05 17:17:24 2017 Use TaskScheduler instead of WorkerPool in fake_auth_policy_client.cc. The following traits are used to post a task to TaskScheduler from this file: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2607273002 Cr-Commit-Position: refs/heads/master@{#441681} [modify] https://crrev.com/9be76765fef84481195dd96339c8fa011257f402/chromeos/dbus/fake_auth_policy_client.cc
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9bf2bbe370a2e4464c9cb40329f8d1c90d3196a commit a9bf2bbe370a2e4464c9cb40329f8d1c90d3196a Author: fdoray <fdoray@chromium.org> Date: Thu Jan 05 17:18:26 2017 Use TaskScheduler instead of WorkerPool in fake_permission_broker_client.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2601423002 Cr-Commit-Position: refs/heads/master@{#441682} [modify] https://crrev.com/a9bf2bbe370a2e4464c9cb40329f8d1c90d3196a/chromeos/dbus/fake_permission_broker_client.cc
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b07e290a4a4273bc516a5d5f8184793075b7f84 commit 3b07e290a4a4273bc516a5d5f8184793075b7f84 Author: fdoray <fdoray@chromium.org> Date: Thu Jan 05 17:21:35 2017 Use TaskScheduler instead of WorkerPool in session_manager_client.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2608943002 Cr-Commit-Position: refs/heads/master@{#441685} [modify] https://crrev.com/3b07e290a4a4273bc516a5d5f8184793075b7f84/chromeos/dbus/session_manager_client.cc
,
Jan 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b520619b133f1b3609461153afd0ffb81bfd5bdc commit b520619b133f1b3609461153afd0ffb81bfd5bdc Author: fdoray <fdoray@chromium.org> Date: Fri Jan 06 22:30:36 2017 Use TaskScheduler instead of WorkerPool in fake_cros_disks_client.cc. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. and Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2601413002 Cr-Commit-Position: refs/heads/master@{#442074} [modify] https://crrev.com/b520619b133f1b3609461153afd0ffb81bfd5bdc/chromeos/dbus/fake_cros_disks_client.cc [modify] https://crrev.com/b520619b133f1b3609461153afd0ffb81bfd5bdc/chromeos/disks/disk_mount_manager_unittest.cc
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fc67b4140d07a660d3b2b6d2eae7a4fd8b6c9dd commit 6fc67b4140d07a660d3b2b6d2eae7a4fd8b6c9dd Author: fdoray <fdoray@chromium.org> Date: Mon Jan 09 21:34:15 2017 Use TaskScheduler instead of WorkerPool in address_sorter_win.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2607283002 Cr-Commit-Position: refs/heads/master@{#442356} [modify] https://crrev.com/6fc67b4140d07a660d3b2b6d2eae7a4fd8b6c9dd/net/dns/address_sorter_unittest.cc [modify] https://crrev.com/6fc67b4140d07a660d3b2b6d2eae7a4fd8b6c9dd/net/dns/address_sorter_win.cc
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f8b27e9d0744d90601d0dbb87a73470a03b01f4 commit 8f8b27e9d0744d90601d0dbb87a73470a03b01f4 Author: fdoray <fdoray@chromium.org> Date: Wed Jan 11 13:49:09 2017 Use TaskScheduler instead of WorkerPool in fake_bluetooth_device_client.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2606193002 Cr-Commit-Position: refs/heads/master@{#442891} [modify] https://crrev.com/8f8b27e9d0744d90601d0dbb87a73470a03b01f4/device/bluetooth/bluez/bluetooth_adapter_profile_bluez_unittest.cc [modify] https://crrev.com/8f8b27e9d0744d90601d0dbb87a73470a03b01f4/device/bluetooth/bluez/bluetooth_socket_bluez_unittest.cc [modify] https://crrev.com/8f8b27e9d0744d90601d0dbb87a73470a03b01f4/device/bluetooth/dbus/fake_bluetooth_device_client.cc
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34db9f35de6a4531e82d3bf068f0529ca94b348b commit 34db9f35de6a4531e82d3bf068f0529ca94b348b Author: fdoray <fdoray@chromium.org> Date: Wed Jan 11 19:03:45 2017 Use TaskScheduler instead of WorkerPool in file_ios.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2608093002 Cr-Commit-Position: refs/heads/master@{#442971} [modify] https://crrev.com/34db9f35de6a4531e82d3bf068f0529ca94b348b/net/disk_cache/blockfile/file_ios.cc [modify] https://crrev.com/34db9f35de6a4531e82d3bf068f0529ca94b348b/net/disk_cache/disk_cache_test_base.h
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d1a5a1e352ee6b2aee40b42d9fdc4b6e0c97fed commit 8d1a5a1e352ee6b2aee40b42d9fdc4b6e0c97fed Author: fdoray <fdoray@chromium.org> Date: Wed Jan 11 19:45:32 2017 Use TaskScheduler instead of WorkerPool in cache_util.cc. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2610503002 Cr-Commit-Position: refs/heads/master@{#442985} [modify] https://crrev.com/8d1a5a1e352ee6b2aee40b42d9fdc4b6e0c97fed/net/disk_cache/backend_unittest.cc [modify] https://crrev.com/8d1a5a1e352ee6b2aee40b42d9fdc4b6e0c97fed/net/disk_cache/cache_util.cc
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1de27c2c277ada42068c38f4b25826061bd6bcc4 commit 1de27c2c277ada42068c38f4b25826061bd6bcc4 Author: fdoray <fdoray@chromium.org> Date: Wed Jan 11 21:50:25 2017 Use TaskScheduler instead of WorkerPool in headless_surface_factory.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2609743002 Cr-Commit-Position: refs/heads/master@{#442994} [modify] https://crrev.com/1de27c2c277ada42068c38f4b25826061bd6bcc4/ui/ozone/platform/headless/headless_surface_factory.cc
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92581e4786c05bd34bdb9cdfa0acb7de669ca6c4 commit 92581e4786c05bd34bdb9cdfa0acb7de669ca6c4 Author: dschuyler <dschuyler@chromium.org> Date: Wed Jan 11 22:16:13 2017 Revert of Use TaskScheduler instead of WorkerPool in cache_util.cc. (patchset #3 id:40001 of https://codereview.chromium.org/2610503002/ ) Reason for revert: It looks like this CL may be related to a unit test failure on this build: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/7492 - Sheriff Original issue's description: > Use TaskScheduler instead of WorkerPool in cache_util.cc. > > The following traits are used: > > Priority: BACKGROUND > User won't notice if this task takes an arbitrarily long time > to complete. > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > Note: Tasks that were previously posted to base::WorkerPool should > use this shutdown behavior because this is how base::WorkerPool > handles all its tasks. > > May Block: > Tasks posted with MayBlock() may block. This includes but is not > limited to tasks that wait on synchronous file I/O operations: > read or write a file from disk, interact with a pipe or a socket, > rename or delete a file, enumerate files in a directory, etc. This > trait isn't required for the mere use of locks. > > BUG= 659191 > > Review-Url: https://codereview.chromium.org/2610503002 > Cr-Commit-Position: refs/heads/master@{#442985} > Committed: https://chromium.googlesource.com/chromium/src/+/8d1a5a1e352ee6b2aee40b42d9fdc4b6e0c97fed TBR=gavinp@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 659191 Review-Url: https://codereview.chromium.org/2626163002 Cr-Commit-Position: refs/heads/master@{#443009} [modify] https://crrev.com/92581e4786c05bd34bdb9cdfa0acb7de669ca6c4/net/disk_cache/backend_unittest.cc [modify] https://crrev.com/92581e4786c05bd34bdb9cdfa0acb7de669ca6c4/net/disk_cache/cache_util.cc
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93605d248126928596c785734491ea7b8ea1b7cf commit 93605d248126928596c785734491ea7b8ea1b7cf Author: fdoray <fdoray@chromium.org> Date: Fri Jan 13 12:17:25 2017 Change DONT_START_THREADS to DONT_CREATE_THREADS in TestBrowserThreadBundle. In a real browser process, threads are started as BrowserThreadImpl objects are created. TestBrowserThreadBundle should do the same. This is a pre-requisite to add the option to create a real TaskScheduler in TestBrowserThreadBundle, because TaskScheduler has to be created and started at the same time. BUG= 659191 Review-Url: https://codereview.chromium.org/2628903002 Cr-Commit-Position: refs/heads/master@{#443536} [modify] https://crrev.com/93605d248126928596c785734491ea7b8ea1b7cf/chrome/browser/io_thread_unittest.cc [modify] https://crrev.com/93605d248126928596c785734491ea7b8ea1b7cf/content/public/test/test_browser_thread_bundle.cc [modify] https://crrev.com/93605d248126928596c785734491ea7b8ea1b7cf/content/public/test/test_browser_thread_bundle.h
,
Jan 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aedd3c2c977646f2fd410c8a21a107b77e9df1b8 commit aedd3c2c977646f2fd410c8a21a107b77e9df1b8 Author: fdoray <fdoray@chromium.org> Date: Sat Jan 14 00:09:32 2017 Add REAL_TASK_SCHEDULER option in TestBrowserThreadBundle. With this option, TaskScheduler tasks don't run on the main thread. This is a pre-requisite for the migration of v8 from WorkerPool to TaskScheduler. v8 currently posts tasks to WorkerPool and waits for them from the main thread using a WaitableEvent. That doesn't work if the tasks have to run on the main thread. BUG= 659191 Review-Url: https://codereview.chromium.org/2628773003 Cr-Commit-Position: refs/heads/master@{#443737} [modify] https://crrev.com/aedd3c2c977646f2fd410c8a21a107b77e9df1b8/content/public/test/test_browser_thread_bundle.cc [modify] https://crrev.com/aedd3c2c977646f2fd410c8a21a107b77e9df1b8/content/public/test/test_browser_thread_bundle.h
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ffd7f1c09ec056e0aee132e95b40df60f5ff821 commit 8ffd7f1c09ec056e0aee132e95b40df60f5ff821 Author: fdoray <fdoray@chromium.org> Date: Wed Jan 18 02:00:57 2017 Use TaskScheduler instead of WorkerPool in timezone_settings.cc. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2611433002 Cr-Commit-Position: refs/heads/master@{#444240} [modify] https://crrev.com/8ffd7f1c09ec056e0aee132e95b40df60f5ff821/chromeos/settings/timezone_settings.cc
,
Jan 31 2017
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/137677f4e89b62bb98c8007ee3eb9d9e26de1302 commit 137677f4e89b62bb98c8007ee3eb9d9e26de1302 Author: fdoray <fdoray@chromium.org> Date: Thu Feb 02 20:52:13 2017 Use TaskScheduler instead of WorkerPool in client_cert_resolver.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 wip Review-Url: https://codereview.chromium.org/2608073003 Cr-Commit-Position: refs/heads/master@{#447836} [modify] https://crrev.com/137677f4e89b62bb98c8007ee3eb9d9e26de1302/chromeos/network/auto_connect_handler_unittest.cc [modify] https://crrev.com/137677f4e89b62bb98c8007ee3eb9d9e26de1302/chromeos/network/client_cert_resolver.cc [modify] https://crrev.com/137677f4e89b62bb98c8007ee3eb9d9e26de1302/chromeos/network/client_cert_resolver.h [modify] https://crrev.com/137677f4e89b62bb98c8007ee3eb9d9e26de1302/chromeos/network/client_cert_resolver_unittest.cc
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4 commit 982a31fe2c2dc31014dfaf373c6e5da6f094dcc4 Author: fdoray <fdoray@chromium.org> Date: Fri Feb 03 20:34:34 2017 Use TaskScheduler instead of WorkerPool in nss_cert_database.cc. Also, remove NSSCertDatabase::SetSlowTaskRunnerForTest(). This method was used to run slow NSSCertDatabase tasks synchronously in tests. This is no longer useful since tasks posted through the post_task.h API within the scope of a ScopedTaskScheduler run synchronously. The following traits are used to post tasks to TaskScheduler: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2603173002 Cr-Commit-Position: refs/heads/master@{#448059} [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/chromeos/cert_loader_unittest.cc [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/chromeos/network/auto_connect_handler_unittest.cc [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/chromeos/network/client_cert_resolver_unittest.cc [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/chromeos/network/network_cert_migrator_unittest.cc [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/chromeos/network/network_connection_handler_unittest.cc [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/net/cert/nss_cert_database.cc [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/net/cert/nss_cert_database.h [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/net/cert/nss_cert_database_chromeos.cc [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/net/cert/nss_cert_database_chromeos_unittest.cc [modify] https://crrev.com/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4/net/cert/nss_cert_database_unittest.cc
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdab762270b332aeb4c38f31d2a97720665fdf1d commit cdab762270b332aeb4c38f31d2a97720665fdf1d Author: fdoray <fdoray@chromium.org> Date: Mon Feb 06 14:59:31 2017 Use TaskScheduler instead of WorkerPool in trace_log.cc. The following traits are used to post a task to TaskScheduler: .WithPriority(TaskPriority::BACKGROUND) User won't notice if this task takes an arbitrarily long time to complete. .WithShutdownBehavior(TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN) Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. .MayBlock() Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2675273002 Cr-Commit-Position: refs/heads/master@{#448248} [modify] https://crrev.com/cdab762270b332aeb4c38f31d2a97720665fdf1d/base/trace_event/trace_log.cc
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fb6b06069c3c3df224960a68ed84e33ee9e13b2 commit 6fb6b06069c3c3df224960a68ed84e33ee9e13b2 Author: fdoray <fdoray@chromium.org> Date: Mon Feb 06 21:35:46 2017 Use TaskScheduler instead of WorkerPool in lorgnette_manager_client.cc. This CL replaces base::WorkerPool::GetTaskRunner() with base::CreateTaskRunnerWithTraits(). The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2677353002 Cr-Commit-Position: refs/heads/master@{#448398} [modify] https://crrev.com/6fb6b06069c3c3df224960a68ed84e33ee9e13b2/chromeos/dbus/lorgnette_manager_client.cc
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1c82ce5d3aa4bb7401cc533a3538b8db6808d38 commit a1c82ce5d3aa4bb7401cc533a3538b8db6808d38 Author: fdoray <fdoray@chromium.org> Date: Wed Feb 08 18:45:31 2017 Fix TaskScheduler initialization in remoting processes. TaskScheduler was not initialized in ios::AppRuntime because of an inverted condition. TaskScheduler was never shutdown in remoting processes. BUG= 659191 Review-Url: https://codereview.chromium.org/2679293002 Cr-Commit-Position: refs/heads/master@{#449043} [modify] https://crrev.com/a1c82ce5d3aa4bb7401cc533a3538b8db6808d38/remoting/client/ios/app_runtime.cc [modify] https://crrev.com/a1c82ce5d3aa4bb7401cc533a3538b8db6808d38/remoting/client/jni/chromoting_jni_runtime.cc [modify] https://crrev.com/a1c82ce5d3aa4bb7401cc533a3538b8db6808d38/remoting/host/it2me/it2me_native_messaging_host_main.cc [modify] https://crrev.com/a1c82ce5d3aa4bb7401cc533a3538b8db6808d38/remoting/host/remoting_me2me_host.cc [modify] https://crrev.com/a1c82ce5d3aa4bb7401cc533a3538b8db6808d38/remoting/host/setup/me2me_native_messaging_host_main.cc
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6abc2378d27fb64de389472c5af3ac74305ea51 commit c6abc2378d27fb64de389472c5af3ac74305ea51 Author: fdoray <fdoray@chromium.org> Date: Thu Feb 09 13:26:06 2017 Use TaskScheduler instead of WorkerPool in webrtc_video_renderer_adapter.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. Does Not Block (default): Tasks without the MayBlock() and WithBaseSyncPrimitives() traits may not block. BUG= 659191 Review-Url: https://codereview.chromium.org/2610493002 Cr-Commit-Position: refs/heads/master@{#449277} [modify] https://crrev.com/c6abc2378d27fb64de389472c5af3ac74305ea51/remoting/protocol/connection_unittest.cc [modify] https://crrev.com/c6abc2378d27fb64de389472c5af3ac74305ea51/remoting/protocol/webrtc_video_renderer_adapter.cc
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/743f8d6db5bc0efd51c3e7ce0fcec1a86886a364 commit 743f8d6db5bc0efd51c3e7ce0fcec1a86886a364 Author: fdoray <fdoray@chromium.org> Date: Thu Feb 09 15:24:23 2017 Increase the number of TaskScheduler foreground threads in renderers. V8Platform::CallOnBackgroundThread() will soon post tasks to TaskScheduler instead of WorkerPool. To avoid a perf regression when this change lands, TaskScheduler should be able to run |num_cores| of these tasks in parallel. BUG= 659191 Review-Url: https://codereview.chromium.org/2681523002 Cr-Commit-Position: refs/heads/master@{#449295} [modify] https://crrev.com/743f8d6db5bc0efd51c3e7ce0fcec1a86886a364/content/renderer/render_process_impl.cc
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f0b47853110ba3becfea5ca2e447588cff39fe5 commit 9f0b47853110ba3becfea5ca2e447588cff39fe5 Author: fdoray <fdoray@chromium.org> Date: Fri Feb 10 12:55:47 2017 Use TaskScheduler in directory_lister.cc. Instead of taking an external TaskRunner, post directly to TaskScheduler. This changes removes a call to the deprecated WorkerPool::GetTaskRunner method. The following traits are used to post to TaskScheduler: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2682523002 Cr-Commit-Position: refs/heads/master@{#449599} [modify] https://crrev.com/9f0b47853110ba3becfea5ca2e447588cff39fe5/chrome/browser/file_select_helper.cc [modify] https://crrev.com/9f0b47853110ba3becfea5ca2e447588cff39fe5/net/base/directory_lister.cc [modify] https://crrev.com/9f0b47853110ba3becfea5ca2e447588cff39fe5/net/base/directory_lister.h [modify] https://crrev.com/9f0b47853110ba3becfea5ca2e447588cff39fe5/net/base/directory_lister_unittest.cc [modify] https://crrev.com/9f0b47853110ba3becfea5ca2e447588cff39fe5/net/url_request/url_request_file_dir_job.cc [modify] https://crrev.com/9f0b47853110ba3becfea5ca2e447588cff39fe5/net/url_request/url_request_file_dir_job.h [modify] https://crrev.com/9f0b47853110ba3becfea5ca2e447588cff39fe5/net/url_request/url_request_file_dir_job_unittest.cc [modify] https://crrev.com/9f0b47853110ba3becfea5ca2e447588cff39fe5/net/url_request/url_request_unittest.cc
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/937fd873bf0791a2b402a7c32a7b29749656fec8 commit 937fd873bf0791a2b402a7c32a7b29749656fec8 Author: fdoray <fdoray@chromium.org> Date: Fri Feb 10 13:58:33 2017 Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2675383002 Cr-Commit-Position: refs/heads/master@{#449607} [modify] https://crrev.com/937fd873bf0791a2b402a7c32a7b29749656fec8/chrome/browser/browser_process_impl_unittest.cc [modify] https://crrev.com/937fd873bf0791a2b402a7c32a7b29749656fec8/net/socket/tcp_socket_posix.cc
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d6746ffb3d857e3a493ab011f5d7c898a928576 commit 8d6746ffb3d857e3a493ab011f5d7c898a928576 Author: bsep <bsep@chromium.org> Date: Fri Feb 10 21:25:45 2017 Revert of Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc. (patchset #2 id:20001 of https://codereview.chromium.org/2675383002/ ) Reason for revert: Speculative revert. May be causing many test failures on the CrOS bot: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 Original issue's description: > Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc. > > The following traits are used: > > Priority: Inherited (default) > The priority is inherited from the calling context (i.e. TaskTraits > are initialized with the priority of the current task). > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > Note: Tasks that were previously posted to base::WorkerPool should > use this shutdown behavior because this is how base::WorkerPool > handles all its tasks. > > May Block: > Tasks posted with MayBlock() may block. This includes but is not > limited to tasks that wait on synchronous file I/O operations: > read or write a file from disk, interact with a pipe or a socket, > rename or delete a file, enumerate files in a directory, etc. This > trait isn't required for the mere use of locks. > > BUG= 659191 > > Review-Url: https://codereview.chromium.org/2675383002 > Cr-Commit-Position: refs/heads/master@{#449607} > Committed: https://chromium.googlesource.com/chromium/src/+/937fd873bf0791a2b402a7c32a7b29749656fec8 TBR=jochen@chromium.org,juliatuttle@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 659191 Review-Url: https://codereview.chromium.org/2689813002 Cr-Commit-Position: refs/heads/master@{#449739} [modify] https://crrev.com/8d6746ffb3d857e3a493ab011f5d7c898a928576/chrome/browser/browser_process_impl_unittest.cc [modify] https://crrev.com/8d6746ffb3d857e3a493ab011f5d7c898a928576/net/socket/tcp_socket_posix.cc
,
Feb 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdbbd9b6c286d385f03b0286e2273e188c69e4b8 commit bdbbd9b6c286d385f03b0286e2273e188c69e4b8 Author: fdoray <fdoray@chromium.org> Date: Sat Feb 11 00:12:49 2017 Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2675383002 Cr-Original-Commit-Position: refs/heads/master@{#449607} Committed: https://chromium.googlesource.com/chromium/src/+/937fd873bf0791a2b402a7c32a7b29749656fec8 Review-Url: https://codereview.chromium.org/2675383002 Cr-Commit-Position: refs/heads/master@{#449801} [modify] https://crrev.com/bdbbd9b6c286d385f03b0286e2273e188c69e4b8/chrome/browser/browser_process_impl_unittest.cc [modify] https://crrev.com/bdbbd9b6c286d385f03b0286e2273e188c69e4b8/net/socket/tcp_socket_posix.cc
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b83be4ca0e00b50b17619adf7f7de275455e9852 commit b83be4ca0e00b50b17619adf7f7de275455e9852 Author: fdoray <fdoray@chromium.org> Date: Mon Feb 13 16:39:47 2017 Use TaskScheduler instead of WorkerPool in v8_platform.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. MayBlock(): The task may block. BUG= 659191 Review-Url: https://codereview.chromium.org/2610473002 Cr-Commit-Position: refs/heads/master@{#449976} [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/chrome/test/base/v8_unit_test.h [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/content/public/test/render_view_test.h [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/content/renderer/pepper/host_var_tracker_unittest.cc [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/content/test/blink_test_environment.cc [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/extensions/renderer/api_binding_test.h [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/extensions/renderer/gc_callback_unittest.cc [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/extensions/renderer/module_system_test.h [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/gin/BUILD.gn [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/gin/shell/gin_main.cc [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/gin/shell_runner_unittest.cc [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/gin/test/file_runner.cc [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/gin/test/v8_test.h [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/gin/v8_platform.cc [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/mojo/edk/js/tests/BUILD.gn [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/mojo/edk/js/tests/js_to_cpp_tests.cc [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/net/proxy/proxy_resolver_v8_tracing_unittest.cc [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/net/proxy/proxy_resolver_v8_tracing_wrapper_unittest.cc [modify] https://crrev.com/b83be4ca0e00b50b17619adf7f7de275455e9852/net/proxy/proxy_resolver_v8_unittest.cc
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb664bc9e179ed2ac87ce32a1d862160243be48b commit cb664bc9e179ed2ac87ce32a1d862160243be48b Author: fdoray <fdoray@chromium.org> Date: Mon Feb 13 16:45:02 2017 Use TaskScheduler instead of WorkerPool in url_request_simple_job.cc. The following traits are used to post a task to TaskScheduler: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. Does Not Block (default): Tasks without the MayBlock() and WithBaseSyncPrimitives() traits may not block. BUG= 659191 Review-Url: https://codereview.chromium.org/2679583004 Cr-Commit-Position: refs/heads/master@{#449977} [modify] https://crrev.com/cb664bc9e179ed2ac87ce32a1d862160243be48b/components/update_client/request_sender_unittest.cc [modify] https://crrev.com/cb664bc9e179ed2ac87ce32a1d862160243be48b/components/update_client/update_checker_unittest.cc [modify] https://crrev.com/cb664bc9e179ed2ac87ce32a1d862160243be48b/content/browser/loader/resource_dispatcher_host_unittest.cc [modify] https://crrev.com/cb664bc9e179ed2ac87ce32a1d862160243be48b/net/url_request/url_request_simple_job.cc [modify] https://crrev.com/cb664bc9e179ed2ac87ce32a1d862160243be48b/net/url_request/url_request_simple_job.h [modify] https://crrev.com/cb664bc9e179ed2ac87ce32a1d862160243be48b/net/url_request/url_request_simple_job_unittest.cc
,
Feb 14 2017
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a16c9bad4d2c9f5a713442c7a4a0651d85780406 commit a16c9bad4d2c9f5a713442c7a4a0651d85780406 Author: fdoray <fdoray@chromium.org> Date: Fri Feb 17 17:51:39 2017 Use TaskScheduler instead of WorkerPool in polling_proxy_config_service.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits(). The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2679233003 Cr-Commit-Position: refs/heads/master@{#451335} [modify] https://crrev.com/a16c9bad4d2c9f5a713442c7a4a0651d85780406/net/proxy/polling_proxy_config_service.cc [modify] https://crrev.com/a16c9bad4d2c9f5a713442c7a4a0651d85780406/net/url_request/url_request_context_builder_unittest.cc
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4df731b9954e2973ae8e206185f3de4556a806be commit 4df731b9954e2973ae8e206185f3de4556a806be Author: jam <jam@chromium.org> Date: Wed Feb 22 15:24:58 2017 Revert of Use TaskScheduler instead of WorkerPool in v8_platform.cc. (patchset #18 id:340001 of https://codereview.chromium.org/2610473002/ ) Reason for revert: Causing extensions_unittests to hang and take 15 minutes. BUG=694828 Original issue's description: > Use TaskScheduler instead of WorkerPool in v8_platform.cc. > > The following traits are used: > > Priority: Inherited (default) > The priority is inherited from the calling context (i.e. TaskTraits > are initialized with the priority of the current task). > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > Note: Tasks that were previously posted to base::WorkerPool should > use this shutdown behavior because this is how base::WorkerPool > handles all its tasks. > > MayBlock(): > The task may block. > > BUG= 659191 > > Review-Url: https://codereview.chromium.org/2610473002 > Cr-Commit-Position: refs/heads/master@{#449976} > Committed: https://chromium.googlesource.com/chromium/src/+/b83be4ca0e00b50b17619adf7f7de275455e9852 TBR=jochen@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 659191 Review-Url: https://codereview.chromium.org/2711703002 Cr-Commit-Position: refs/heads/master@{#452058} [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/chrome/test/base/v8_unit_test.h [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/content/public/test/render_view_test.h [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/content/renderer/pepper/host_var_tracker_unittest.cc [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/content/test/blink_test_environment.cc [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/extensions/renderer/api_binding_test.h [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/extensions/renderer/gc_callback_unittest.cc [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/extensions/renderer/module_system_test.h [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/gin/BUILD.gn [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/gin/shell/gin_main.cc [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/gin/shell_runner_unittest.cc [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/gin/test/file_runner.cc [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/gin/test/v8_test.h [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/gin/v8_platform.cc [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/mojo/edk/js/tests/BUILD.gn [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/mojo/edk/js/tests/js_to_cpp_tests.cc [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/net/proxy/proxy_resolver_v8_tracing_unittest.cc [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/net/proxy/proxy_resolver_v8_tracing_wrapper_unittest.cc [modify] https://crrev.com/4df731b9954e2973ae8e206185f3de4556a806be/net/proxy/proxy_resolver_v8_unittest.cc
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f945b5f336da1fd246e2a0a24a5633547034287b commit f945b5f336da1fd246e2a0a24a5633547034287b Author: fdoray <fdoray@chromium.org> Date: Tue Feb 28 02:19:38 2017 Revert of Use TaskScheduler instead of WorkerPool in client_cert_store_chromeos.cc. (patchset #7 id:120001 of https://codereview.chromium.org/2533473002/ ) Reason for revert: Using TaskScheduler with NSS is not safe until TaskScheduler supports dynamically growing its thread pool. Original issue's description: > Use TaskScheduler instead of WorkerPool in client_cert_store_chromeos.cc. > > This CL replaces base::WorkerPool::PostTask() with > base::PostTaskWithTraits(). The following traits are used: > > Priority: Inherited (default) > The priority is inherited from the calling context (i.e. TaskTraits > are initialized with the priority of the current task). > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > With File IO: > The task waits on synchronous file IO operations. > > With Wait: > The task waits on things other than synchronous file IO > operations (e.g. WaitableEvent, ConditionVariable, join a thread, > join a process, blocking system call that doesn't involve > interactions with the file system). > > BUG= 659191 > > Committed: https://crrev.com/14589e9ca09b5cf03be779b0c1158cc5388def05 > Cr-Commit-Position: refs/heads/master@{#436087} TBR=gab@chromium.org,mattm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 659191 Review-Url: https://codereview.chromium.org/2720143003 Cr-Commit-Position: refs/heads/master@{#453460} [modify] https://crrev.com/f945b5f336da1fd246e2a0a24a5633547034287b/chrome/browser/chromeos/net/client_cert_store_chromeos.cc [modify] https://crrev.com/f945b5f336da1fd246e2a0a24a5633547034287b/chrome/browser/chromeos/net/client_cert_store_chromeos_unittest.cc
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37b8327d48552831f10e5d136f80cdac085abbc7 commit 37b8327d48552831f10e5d136f80cdac085abbc7 Author: fdoray <fdoray@chromium.org> Date: Tue Feb 28 02:42:14 2017 Revert of Use TaskScheduler instead of WorkerPool in nss_cert_database.cc. (patchset #4 id:60001 of https://codereview.chromium.org/2603173002/ ) Reason for revert: Using TaskScheduler with NSS is not safe until TaskScheduler supports dynamically growing its thread pool. Original issue's description: > Use TaskScheduler instead of WorkerPool in nss_cert_database.cc. > > Also, remove NSSCertDatabase::SetSlowTaskRunnerForTest(). This method > was used to run slow NSSCertDatabase tasks synchronously in tests. This > is no longer useful since tasks posted through the post_task.h API within > the scope of a ScopedTaskScheduler run synchronously. > > The following traits are used to post tasks to TaskScheduler: > > Priority: Inherited (default) > The priority is inherited from the calling context (i.e. TaskTraits > are initialized with the priority of the current task). > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > Note: Tasks that were previously posted to base::WorkerPool should > use this shutdown behavior because this is how base::WorkerPool > handles all its tasks. > > May Block: > Tasks posted with MayBlock() may block. This includes but is not > limited to tasks that wait on synchronous file I/O operations: > read or write a file from disk, interact with a pipe or a socket, > rename or delete a file, enumerate files in a directory, etc. This > trait isn't required for the mere use of locks. > > BUG= 659191 > > Review-Url: https://codereview.chromium.org/2603173002 > Cr-Commit-Position: refs/heads/master@{#448059} > Committed: https://chromium.googlesource.com/chromium/src/+/982a31fe2c2dc31014dfaf373c6e5da6f094dcc4 TBR=rsleevi@chromium.org,stevenjb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 659191 Review-Url: https://codereview.chromium.org/2722733002 Cr-Commit-Position: refs/heads/master@{#453475} [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/chromeos/cert_loader_unittest.cc [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/chromeos/network/auto_connect_handler_unittest.cc [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/chromeos/network/client_cert_resolver_unittest.cc [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/chromeos/network/network_cert_migrator_unittest.cc [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/chromeos/network/network_connection_handler_unittest.cc [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/net/cert/nss_cert_database.cc [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/net/cert/nss_cert_database.h [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/net/cert/nss_cert_database_chromeos.cc [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/net/cert/nss_cert_database_chromeos_unittest.cc [modify] https://crrev.com/37b8327d48552831f10e5d136f80cdac085abbc7/net/cert/nss_cert_database_unittest.cc
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/974b02737a66b77b9f58889226c5fd6f71539dce commit 974b02737a66b77b9f58889226c5fd6f71539dce Author: fdoray <fdoray@chromium.org> Date: Tue Feb 28 03:00:41 2017 Use TaskScheduler instead of WorkerPool in cache_util.cc. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Review-Url: https://codereview.chromium.org/2674163003 Cr-Commit-Position: refs/heads/master@{#453479} [modify] https://crrev.com/974b02737a66b77b9f58889226c5fd6f71539dce/net/disk_cache/cache_util.cc
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24e5d1ddee9fa61587b6f0279a25792d0208b9f1 commit 24e5d1ddee9fa61587b6f0279a25792d0208b9f1 Author: fdoray <fdoray@chromium.org> Date: Wed Apr 12 19:58:13 2017 Revert of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp (patchset #1 id:1 of https://codereview.chromium.org/2685673005/ ) Reason for revert: Reverting to see the effect on memory benchmarks. BUG= 691618 Original issue's description: > Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp > > This CL replaces base::WorkerPool::PostTask() with > base::PostTaskWithTraits(). The following traits are used: > > Priority: Inherited (default) > The priority is inherited from the calling context (i.e. TaskTraits > are initialized with the priority of the current task). > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > Note: Tasks that were previously posted to base::WorkerPool should > use this shutdown behavior because this is how base::WorkerPool > handles all its tasks. > > *No* May Block (default): > Tasks may no block on synchronous file I/O operations or on sync > primitives. > > BUG= 659191 > > Review-Url: https://codereview.chromium.org/2685673005 > Cr-Commit-Position: refs/heads/master@{#449633} > Committed: https://chromium.googlesource.com/chromium/src/+/99e56574537a8cf27af4c86f34e42fcad65e21c8 TBR=kinuko@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 659191 Review-Url: https://codereview.chromium.org/2812263003 Cr-Commit-Position: refs/heads/master@{#464121} [modify] https://crrev.com/24e5d1ddee9fa61587b6f0279a25792d0208b9f1/third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp [modify] https://crrev.com/24e5d1ddee9fa61587b6f0279a25792d0208b9f1/third_party/WebKit/Source/platform/threading/DEPS
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fd356a58dfbc3e653f2c4eb3f781cb6a88c3472 commit 2fd356a58dfbc3e653f2c4eb3f781cb6a88c3472 Author: fdoray <fdoray@chromium.org> Date: Tue May 02 18:41:29 2017 Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. This CL was reverted because it posted a task to TaskScheduler before it was initialized. This issue was addressed in https://crbug.com/690706 . The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Original-Commit-Position: refs/heads/master@{#441139} Review-Url: https://codereview.chromium.org/2609733002 Cr-Commit-Position: refs/heads/master@{#468713} [modify] https://crrev.com/2fd356a58dfbc3e653f2c4eb3f781cb6a88c3472/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c76a60b8acefc4672c60799d0a9b5e4d2b242c65 commit c76a60b8acefc4672c60799d0a9b5e4d2b242c65 Author: fdoray <fdoray@chromium.org> Date: Wed May 03 23:20:02 2017 Use TaskScheduler instead of WorkerPool in print_job.cc. WorkerPool is being deprecated in favor of TaskScheduler. BUG= 659191 Review-Url: https://codereview.chromium.org/2855543003 Cr-Commit-Position: refs/heads/master@{#469192} [modify] https://crrev.com/c76a60b8acefc4672c60799d0a9b5e4d2b242c65/chrome/browser/printing/print_job.cc
,
May 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/876959fd7694a3276cd8c22d7c2ed858a5e7fc21 commit 876959fd7694a3276cd8c22d7c2ed858a5e7fc21 Author: fdoray <fdoray@chromium.org> Date: Fri May 12 12:27:33 2017 Initialize TaskScheduler in gin_main.cc. This is a prerequisite to migrate v8_platform.cc from base::WorkerPool to base::TaskScheduler. BUG= 659191 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2877963002 Cr-Commit-Position: refs/heads/master@{#471282} [modify] https://crrev.com/876959fd7694a3276cd8c22d7c2ed858a5e7fc21/gin/shell/gin_main.cc
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4560bffcd8250247bbabe4f3f045ea7fa0d901ba commit 4560bffcd8250247bbabe4f3f045ea7fa0d901ba Author: fdoray <fdoray@chromium.org> Date: Mon May 15 15:03:33 2017 Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 TBR=danakj@chromium.org Review-Url: https://codereview.chromium.org/2860703002 Cr-Commit-Position: refs/heads/master@{#471763} [modify] https://crrev.com/4560bffcd8250247bbabe4f3f045ea7fa0d901ba/content/browser/compositor/software_output_device_ozone_unittest.cc [modify] https://crrev.com/4560bffcd8250247bbabe4f3f045ea7fa0d901ba/ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc [modify] https://crrev.com/4560bffcd8250247bbabe4f3f045ea7fa0d901ba/ui/compositor/test/test_suite.cc [modify] https://crrev.com/4560bffcd8250247bbabe4f3f045ea7fa0d901ba/ui/compositor/test/test_suite.h [modify] https://crrev.com/4560bffcd8250247bbabe4f3f045ea7fa0d901ba/ui/events/platform/x11/x11_hotplug_event_handler.cc
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b87bcfb8c3b17bbcad020186a94e935e2fd0d162 commit b87bcfb8c3b17bbcad020186a94e935e2fd0d162 Author: fdoray <fdoray@chromium.org> Date: Wed May 24 17:49:40 2017 [reland] Use TaskScheduler instead of WorkerPool in v8_platform.cc. A first version of this CL landed as https://codereview.chromium.org/2610473002/. It was reverted because of hangs in extensions_unittests. These hangs should have been fixed by the addition of a call to TaskScheduler::FlushForTesting() in the destructors of ScopedTaskEnvironment and ScopedAsyncTaskScheduler. The following traits are used: Priority: USER_VISIBLE This task affects UI or responsiveness of future user interactions. It is not an immediate response to a user interaction. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. MayBlock(): The task may block. BUG= 659191 Review-Url: https://codereview.chromium.org/2876523002 Cr-Commit-Position: refs/heads/master@{#474346} [modify] https://crrev.com/b87bcfb8c3b17bbcad020186a94e935e2fd0d162/gin/v8_platform.cc
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6552fc43089472109de62975dbb91553d7dc19df commit 6552fc43089472109de62975dbb91553d7dc19df Author: jonross <jonross@chromium.org> Date: Wed May 24 22:22:15 2017 Revert "Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc." The change being reverted has led to failures in mash_browser_tests and mus_browser_tests. These are currently failing on the Mojo FYI bots. We are attempting to bring up more tests on the CQ, but cannot as they are failing with this change. This has led to bugs landing that would have normally been caught by the test suite. Revert "Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc." This reverts commit 4560bffcd8250247bbabe4f3f045ea7fa0d901ba. TBR=sadrul@chromium.org, danakj@chromium.org TEST=mash_browser_tests BUG= 725505 , 659191 Review-Url: https://codereview.chromium.org/2899313003 Cr-Commit-Position: refs/heads/master@{#474447} [modify] https://crrev.com/6552fc43089472109de62975dbb91553d7dc19df/content/browser/compositor/software_output_device_ozone_unittest.cc [modify] https://crrev.com/6552fc43089472109de62975dbb91553d7dc19df/ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc [modify] https://crrev.com/6552fc43089472109de62975dbb91553d7dc19df/ui/compositor/test/test_suite.cc [modify] https://crrev.com/6552fc43089472109de62975dbb91553d7dc19df/ui/compositor/test/test_suite.h [modify] https://crrev.com/6552fc43089472109de62975dbb91553d7dc19df/ui/events/platform/x11/x11_hotplug_event_handler.cc
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6eb5c1eb647e1709b4b03ae5148f8c03daea03fb commit 6eb5c1eb647e1709b4b03ae5148f8c03daea03fb Author: fdoray <fdoray@chromium.org> Date: Thu May 25 19:51:13 2017 Update TaskTraits in v8_platform.cc. https://codereview.chromium.org/2876523002/ landed with the wrong TaskTraits. This CL updates the TaskTraits to what was agreed on in https://codereview.chromium.org/2610473002/ BUG= 659191 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2900263004 Cr-Commit-Position: refs/heads/master@{#474762} [modify] https://crrev.com/6eb5c1eb647e1709b4b03ae5148f8c03daea03fb/gin/v8_platform.cc
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f23174882c11f77a5b58cf37ab4051a2ad68a4bf commit f23174882c11f77a5b58cf37ab4051a2ad68a4bf Author: fdoray <fdoray@chromium.org> Date: Tue May 30 17:37:56 2017 Reland of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp (patchset #4 id:200001 of https://codereview.chromium.org/2812263003/ ) Reason for revert: Relanding the patch set after the effect of reverting it has been analyzed. Original issue's description: > Revert of Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp (patchset #1 id:1 of https://codereview.chromium.org/2685673005/ ) > > Reason for revert: > Reverting to see the effect on memory benchmarks. > BUG= 691618 > > Original issue's description: > > Use TaskScheduler instead of WorkerPool in BackgroundTaskRunner.cpp > > > > This CL replaces base::WorkerPool::PostTask() with > > base::PostTaskWithTraits(). The following traits are used: > > > > Priority: Inherited (default) > > The priority is inherited from the calling context (i.e. TaskTraits > > are initialized with the priority of the current task). > > > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > > Tasks posted with this mode which have not started executing before > > shutdown is initiated will never run. Tasks with this mode running at > > shutdown will be ignored (the worker will not be joined). > > > > Note: Tasks that were previously posted to base::WorkerPool should > > use this shutdown behavior because this is how base::WorkerPool > > handles all its tasks. > > > > *No* May Block (default): > > Tasks may no block on synchronous file I/O operations or on sync > > primitives. > > > > BUG= 659191 > > > > Review-Url: https://codereview.chromium.org/2685673005 > > Cr-Commit-Position: refs/heads/master@{#449633} > > Committed: https://chromium.googlesource.com/chromium/src/+/99e56574537a8cf27af4c86f34e42fcad65e21c8 > > TBR=kinuko@chromium.org,haraken@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= 659191 > > Review-Url: https://codereview.chromium.org/2812263003 > Cr-Commit-Position: refs/heads/master@{#464121} > Committed: https://chromium.googlesource.com/chromium/src/+/24e5d1ddee9fa61587b6f0279a25792d0208b9f1 TBR=kinuko@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 691618 Review-Url: https://codereview.chromium.org/2914633002 Cr-Commit-Position: refs/heads/master@{#475582} [modify] https://crrev.com/f23174882c11f77a5b58cf37ab4051a2ad68a4bf/third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp [modify] https://crrev.com/f23174882c11f77a5b58cf37ab4051a2ad68a4bf/third_party/WebKit/Source/platform/threading/DEPS
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b1abc96c88e58386b492c65055e28ac9672bedb commit 7b1abc96c88e58386b492c65055e28ac9672bedb Author: Francois Doray <fdoray@chromium.org> Date: Thu Jun 15 13:38:58 2017 [reland] Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc. Previously landed as https://codereview.chromium.org/2860703002 https://chromium-review.googlesource.com/c/523803/ should fix the issue that caused the revert. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 , 725505 TBR=danakj@chromium.org Change-Id: Ie4177b0e7cb7d554ea9ef02dc26afd22942e59e7 Reviewed-on: https://chromium-review.googlesource.com/524023 Reviewed-by: Francois Doray <fdoray@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#479685} [modify] https://crrev.com/7b1abc96c88e58386b492c65055e28ac9672bedb/content/browser/compositor/software_output_device_ozone_unittest.cc [modify] https://crrev.com/7b1abc96c88e58386b492c65055e28ac9672bedb/ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc [modify] https://crrev.com/7b1abc96c88e58386b492c65055e28ac9672bedb/ui/compositor/test/test_suite.cc [modify] https://crrev.com/7b1abc96c88e58386b492c65055e28ac9672bedb/ui/compositor/test/test_suite.h [modify] https://crrev.com/7b1abc96c88e58386b492c65055e28ac9672bedb/ui/events/platform/x11/x11_hotplug_event_handler.cc
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4d445c92ca780eca01c4fb516eee1cb46b9ccc4 commit a4d445c92ca780eca01c4fb516eee1cb46b9ccc4 Author: Francois Doray <fdoray@chromium.org> Date: Mon Aug 28 16:36:28 2017 Migrate TPM initialization from WorkerPool to TaskScheduler. WorkerPool is being deprecated in favor of TaskScheduler. NSS functions may reenter //net via extension hooks. If the reentered code needs to synchronously wait for a task to run but the thread pool in which that task must run doesn't have enough threads to schedule it, a deadlock occurs. To prevent that, a base::ScopedBlockingCall increments the thread pool capacity for the duration of the TPM initialization. Bug: 659191 Change-Id: I4d50de7d5bcaad8d91293a535fbd7408fe7a83da Reviewed-on: https://chromium-review.googlesource.com/635956 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#497776} [modify] https://crrev.com/a4d445c92ca780eca01c4fb516eee1cb46b9ccc4/crypto/nss_util.cc
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48c811b2b097a20a98d7515161913a9d037c4d52 commit 48c811b2b097a20a98d7515161913a9d037c4d52 Author: Francois Doray <fdoray@chromium.org> Date: Tue Sep 12 13:10:41 2017 Migrate NSS client cert store from WorkerPool to TaskScheduler. WorkerPool is being deprecated in favor of TaskScheduler. NSS calls may acquire the NSS lock or reenter Chrome code via extension hooks (such as smart card UI). To ensure threads are not starved or deadlocked, base::ScopedBlockingCall instances increment the thread pool capacity when too much time is spent in a scope where an NSS call is made. Bug: 659191 Change-Id: Iaf088d84521753a3399083047a4e5733d44c472f Reviewed-on: https://chromium-review.googlesource.com/648218 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#501248} [modify] https://crrev.com/48c811b2b097a20a98d7515161913a9d037c4d52/chrome/browser/chromeos/net/client_cert_store_chromeos.cc [modify] https://crrev.com/48c811b2b097a20a98d7515161913a9d037c4d52/chrome/browser/chromeos/net/client_cert_store_chromeos_unittest.cc [modify] https://crrev.com/48c811b2b097a20a98d7515161913a9d037c4d52/net/ssl/client_cert_store_nss.cc [modify] https://crrev.com/48c811b2b097a20a98d7515161913a9d037c4d52/net/ssl/ssl_platform_key_nss.cc
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd65bb01738f2152e4801d75f41d167beec5c2cf commit cd65bb01738f2152e4801d75f41d167beec5c2cf Author: Francois Doray <fdoray@chromium.org> Date: Mon Sep 18 20:21:52 2017 Migrate NSS cert database from WorkerPool to TaskScheduler. WorkerPool is being deprecated in favor of TaskScheduler. NSS calls may acquire the NSS lock or reenter Chrome code via extension hooks (such as smart card UI). To ensure threads are not starved or deadlocked, base::ScopedBlockingCall instances increment the thread pool capacity when too much time is spent in a scope where an NSS call is made. Bug: 659191 Change-Id: I27732ea915dbd84ec6f8cdf0c8da4646be13d0ec Reviewed-on: https://chromium-review.googlesource.com/638553 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#502659} [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/chromeos/cert_loader_unittest.cc [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/chromeos/network/auto_connect_handler_unittest.cc [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/chromeos/network/client_cert_resolver_unittest.cc [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/chromeos/network/network_cert_migrator_unittest.cc [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/chromeos/network/network_connection_handler_impl_unittest.cc [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/net/cert/nss_cert_database.cc [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/net/cert/nss_cert_database.h [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/net/cert/nss_cert_database_chromeos.cc [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/net/cert/nss_cert_database_chromeos_unittest.cc [modify] https://crrev.com/cd65bb01738f2152e4801d75f41d167beec5c2cf/net/cert/nss_cert_database_unittest.cc
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2d01bae3fbe6fd4c6433ef1163350d25945b298 commit a2d01bae3fbe6fd4c6433ef1163350d25945b298 Author: Francois Doray <fdoray@chromium.org> Date: Mon Sep 25 19:17:40 2017 Migrate DNS lookups from WorkerPool to TaskScheduler. WorkerPool is being deprecated in favor of TaskScheduler. DNS lookups can block for a long time. This CL uses ScopedBlockingCall to increase the thread pool capacity and thus avoid reducing the program's CPU contention during a DNS lookup. TBR=bengr@chromium.org,stevenjb@chromium.org Bug: 659191 Change-Id: I57818e26aa719483a5bd4f25a0aa81952bb63ba3 Reviewed-on: https://chromium-review.googlesource.com/637023 Reviewed-by: Francois Doray <fdoray@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#504124} [modify] https://crrev.com/a2d01bae3fbe6fd4c6433ef1163350d25945b298/chromeos/network/host_resolver_impl_chromeos_unittest.cc [modify] https://crrev.com/a2d01bae3fbe6fd4c6433ef1163350d25945b298/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc [modify] https://crrev.com/a2d01bae3fbe6fd4c6433ef1163350d25945b298/net/dns/fuzzed_host_resolver.cc [modify] https://crrev.com/a2d01bae3fbe6fd4c6433ef1163350d25945b298/net/dns/host_resolver_impl.cc [modify] https://crrev.com/a2d01bae3fbe6fd4c6433ef1163350d25945b298/net/dns/host_resolver_impl.h [modify] https://crrev.com/a2d01bae3fbe6fd4c6433ef1163350d25945b298/net/dns/host_resolver_impl_unittest.cc [modify] https://crrev.com/a2d01bae3fbe6fd4c6433ef1163350d25945b298/net/dns/host_resolver_proc.cc
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/becd1ef70bf814f9bc75524ad064bab21c5e16fc commit becd1ef70bf814f9bc75524ad064bab21c5e16fc Author: Francois Doray <fdoray@chromium.org> Date: Mon Sep 25 20:58:45 2017 Migrate SerialWorker from TaskScheduler to WorkerPool. WorkerPool is being deprecated in favor of TaskScheduler. Bug: 659191 Change-Id: I6b0455425ef6e2f7ea899ca0b2634aa7768d63b7 Reviewed-on: https://chromium-review.googlesource.com/637024 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#504161} [modify] https://crrev.com/becd1ef70bf814f9bc75524ad064bab21c5e16fc/net/dns/dns_config_service_posix.cc [modify] https://crrev.com/becd1ef70bf814f9bc75524ad064bab21c5e16fc/net/dns/dns_config_service_win.cc [modify] https://crrev.com/becd1ef70bf814f9bc75524ad064bab21c5e16fc/net/dns/serial_worker.cc [modify] https://crrev.com/becd1ef70bf814f9bc75524ad064bab21c5e16fc/net/dns/serial_worker.h [modify] https://crrev.com/becd1ef70bf814f9bc75524ad064bab21c5e16fc/net/dns/serial_worker_unittest.cc
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/524a99e5ca3aa7df42d743db73fee483f624c1e3 commit 524a99e5ca3aa7df42d743db73fee483f624c1e3 Author: Francois Doray <fdoray@chromium.org> Date: Tue Sep 26 18:48:17 2017 Migrate multi-threaded cert verifier from WorkerPool to TaskScheduler. WorkerPool is being deprecated in favor of TaskScheduler. NSS functions may reenter //net via extension hooks. If the reentered code needs to synchronously wait for a task to run but the thread pool in which that task must run doesn't have enough threads to schedule it, a deadlock occurs. To prevent that, calls to NSS functions are made within the scope of a MAY_BLOCK base::ScopedBlockingCall which increments the thread pool capacity after a short timeout. Bug: 659191 Change-Id: I2a2719f7c104f1ecf8cac7e4019836920c777261 Reviewed-on: https://chromium-review.googlesource.com/648328 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#504439} [modify] https://crrev.com/524a99e5ca3aa7df42d743db73fee483f624c1e3/base/threading/thread_restrictions.h [modify] https://crrev.com/524a99e5ca3aa7df42d743db73fee483f624c1e3/net/cert/cert_verify_proc.cc [modify] https://crrev.com/524a99e5ca3aa7df42d743db73fee483f624c1e3/net/cert/multi_threaded_cert_verifier.cc [modify] https://crrev.com/524a99e5ca3aa7df42d743db73fee483f624c1e3/net/cert_net/nss_ocsp.cc
,
Sep 26 2017
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3d1fac07f11ac72488779fd03cf55310e7f2458 commit f3d1fac07f11ac72488779fd03cf55310e7f2458 Author: Francois Doray <fdoray@chromium.org> Date: Wed Sep 27 16:59:40 2017 Remove base::WorkerPool. This class is deprecated and no longer used. TBR=agl@chromium.org,holte@chromium.org Bug: 659191 , 251774 Change-Id: I111c334d3feac302abd14aa9d4d142aa237a00b4 Reviewed-on: https://chromium-review.googlesource.com/650368 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#504708} [modify] https://crrev.com/f3d1fac07f11ac72488779fd03cf55310e7f2458/base/BUILD.gn [modify] https://crrev.com/f3d1fac07f11ac72488779fd03cf55310e7f2458/base/threading/post_task_and_reply_impl.h [modify] https://crrev.com/f3d1fac07f11ac72488779fd03cf55310e7f2458/base/threading/sequenced_worker_pool.h [delete] https://crrev.com/4d50fe026a4f7e1da89ad90770500867282c3b2e/base/threading/worker_pool.cc [delete] https://crrev.com/4d50fe026a4f7e1da89ad90770500867282c3b2e/base/threading/worker_pool.h [delete] https://crrev.com/4d50fe026a4f7e1da89ad90770500867282c3b2e/base/threading/worker_pool_posix.cc [delete] https://crrev.com/4d50fe026a4f7e1da89ad90770500867282c3b2e/base/threading/worker_pool_posix.h [delete] https://crrev.com/4d50fe026a4f7e1da89ad90770500867282c3b2e/base/threading/worker_pool_posix_unittest.cc [delete] https://crrev.com/4d50fe026a4f7e1da89ad90770500867282c3b2e/base/threading/worker_pool_unittest.cc [delete] https://crrev.com/4d50fe026a4f7e1da89ad90770500867282c3b2e/base/threading/worker_pool_win.cc [modify] https://crrev.com/f3d1fac07f11ac72488779fd03cf55310e7f2458/components/metrics/file_metrics_provider.cc [modify] https://crrev.com/f3d1fac07f11ac72488779fd03cf55310e7f2458/content/browser/loader/resource_dispatcher_host_unittest.cc [modify] https://crrev.com/f3d1fac07f11ac72488779fd03cf55310e7f2458/crypto/nss_util.cc
,
Sep 27 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by fdoray@chromium.org
, Oct 25 2016