External link icons incongruous in context of Get Help app |
||||||||
Issue descriptionLinks with Off-Site Icons - Triggered by Target=Blank, set in gKMS article links and assigned icon within Get Help app CSS. - For Online help, usage makes sense such that off-site icon appears with links for content outside of online help. But, for Get Help app, meaning of off-site icon is confusing when some links that have it point to online resources outside of Get Help app and some that don’t have it also point to online resources. e.g. For Getting online > Set up virtual private networks (VPNs) > VPN apps, see "force install" and "upload a config file" links. Both are off-site, relative to Get Help, but they don't both have external link icons.
,
Oct 25 2016
,
Nov 15 2016
,
Nov 18 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/8dbfd4f980a372545f4900f194342c2cd8fce7d3 commit 8dbfd4f980a372545f4900f194342c2cd8fce7d3 Author: David Morse <morsed@google.com> Date: Wed Nov 16 00:56:49 2016
,
Nov 19 2016
This landed with 9001.0.0/56.0.2923.0/3502314 and I believe it missed the M56 release branch, so now requesting a mergeback to M56.
,
Nov 19 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 30 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 30 2016
,
Jan 18 2017
,
May 9 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by morsed@google.com
, Oct 25 2016