Add a field to cert reports for Finch information |
|||
Issue descriptionIn investigating issue 589700 , UMA data has some biases that we might want to avoid: namely, we only receive UMA data from clients who can make HTTPS connections to Google. This makes the data a bit hard to reason about when trying to understand behaviors for clients with bad clocks. It would be nice to use certificate reports to investigate the effectiveness of the secure time service in showing the bad clock interstitial, but to do so we need to distinguish users who are in the secure time field trial from those who aren't. To do so, we can add a 'field_trial_info' message to cert_logger.proto. At the moment, the only field trial we care about is whether the NetworkTimeServiceQuerying feature is enabled, though it would be nice to also report the experiment params associated with that feature.
,
Nov 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40d0800b0956677f82cb7ba32085ac2907f792af commit 40d0800b0956677f82cb7ba32085ac2907f792af Author: estark <estark@chromium.org> Date: Sat Nov 12 00:13:43 2016 Add experimental feature info to certificate reports In poking around certificate reports and UMA, I've noticed that certificate reports give somewhat different data than UMA about how often the bad clock interstitial is shown. (This is likely due to the fact that users have to connect to Google over HTTPS to report UMA data, whereas certificate reports are sent encrypted over HTTP.) This CL adds a field to the cert report to contain information about Finch features that affect certificate validation warnings, such as the network time service experiment. This will allow us to measure the results of the network time service via cert reports data, not just via UMA. BUG= 659179 , 589700 TBR=battre@chromium.org Review-Url: https://codereview.chromium.org/2448943004 Cr-Commit-Position: refs/heads/master@{#431688} [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/chrome/browser/ssl/cert_report_helper.cc [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/chrome/browser/ssl/ssl_browser_tests.cc [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/chrome/browser/ssl/ssl_error_handler_unittest.cc [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/certificate_reporting/BUILD.gn [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/certificate_reporting/DEPS [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/certificate_reporting/cert_logger.proto [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/certificate_reporting/error_report.cc [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/certificate_reporting/error_report.h [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/certificate_reporting/error_report_unittest.cc [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/network_time/BUILD.gn [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/network_time/network_time_test_utils.cc [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/network_time/network_time_test_utils.h [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/network_time/network_time_tracker.cc [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/network_time/network_time_tracker.h [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/network_time/network_time_tracker_unittest.cc [modify] https://crrev.com/40d0800b0956677f82cb7ba32085ac2907f792af/components/ssl_errors/error_classification_unittest.cc
,
Nov 21 2016
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
|||
►
Sign in to add a comment |
|||
Comment 1 by est...@chromium.org
, Oct 25 2016Status: Started (was: Available)