New issue
Advanced search Search tips

Issue 659161 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 603386



Sign in to add a comment

MacViews - Cookies dialog disappears when Chrome is hidden

Project Member Reported by shrike@chromium.org, Oct 25 2016

Issue description

Version: 56.0.2900.0
OS: 10.11

What steps will reproduce the problem?
(1) Bring up the collected cookies dialog
(2) Hide Chrome
(3) Switch back to Chrome

What is the expected output?
The cookies dialog should still be visible.

What do you see instead?
The cookies dialog is no longer visible. The dialog is still "present" because keyboard shortcuts like Cmd W and Cmd Q silently fail. If you click the lock icon and then in the page info dialog click the link to display the cookies dialog, the page info dialog disappears but the cookies dialog does not appear.

 
Status: Assigned (was: Untriaged)

Comment 2 by tapted@chromium.org, Oct 26 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2448243003
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c06b0559798ae1120beb416075cffb88ea92874

commit 6c06b0559798ae1120beb416075cffb88ea92874
Author: tapted <tapted@chromium.org>
Date: Thu Oct 27 12:26:56 2016

MacViews: Reattach children of native windows when they are exposed.

Since NSWindow's childWindow breaks when windows are ordered out (except
via -[NSApp hide] it seems), we detach child windows in all cases where
a Widget becomes hidden. Currently they're only re-attached for
NSWindows backed by views::Widget.

To fix, watch for the parent window being exposed, and update
relationships accordingly. This is done implicitly, by making the child
Widget visible again, if it wants to be.

BUG= 659161 

Review-Url: https://codereview.chromium.org/2448243003
Cr-Commit-Position: refs/heads/master@{#428002}

[modify] https://crrev.com/6c06b0559798ae1120beb416075cffb88ea92874/ui/views/cocoa/bridged_native_widget.h
[modify] https://crrev.com/6c06b0559798ae1120beb416075cffb88ea92874/ui/views/cocoa/widget_owner_nswindow_adapter.h
[modify] https://crrev.com/6c06b0559798ae1120beb416075cffb88ea92874/ui/views/cocoa/widget_owner_nswindow_adapter.mm
[modify] https://crrev.com/6c06b0559798ae1120beb416075cffb88ea92874/ui/views/widget/native_widget_mac_unittest.mm

Comment 4 by tapted@chromium.org, Jan 27 2017

Blocking: 603386
Labels: Phase3 Proj-MacViews
Status: Fixed (was: Started)
fixed.

Sign in to add a comment