New issue
Advanced search Search tips

Issue 659159 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

FFmpegGlue::OpenContext() does not expose AVERROR information on failure

Reported by jwalc...@opera.com, Oct 25 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/53.0.2785.143 Chrome/53.0.2785.143 Safari/537.36

Steps to reproduce the problem:
Call FFmpegGlue::OpenContext() on URL with corrupted content

What is the expected behavior?
It should be possible to get the actual AVERROR code to determine the cause of the failure.

What went wrong?
FFmpegGlue::OpenContext() returns a boolean flag and the actual information about AVERROR code is lost.

Did this work before? N/A 

Chrome version: 53.0.2785.143  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 11.2 r999

I would suggest to update FFmpegGlue::OpenContext() to return the actual result of avformat_open_input() instead of simple boolean flag.
 
Labels: TE-NeedsTriageHelp
Components: Internals>Media>FFmpeg
Owner: chcunningham@chromium.org
Status: Assigned (was: Unconfirmed)
chris, can you take this one? or re-assign appropriately. thanks
jwalczak, do you want the error to just be logged, or are you hoping to do specific error handling? I think we just treat all errors the same for now - so bool is all we've needed. Feel free to send an illustrative patch.

Comment 5 by jwalc...@opera.com, Nov 8 2016

I would suggest to update FFmpegGlue::OpenContext() to return the actual result of avformat_open_input() (i.e. int instead of bool). This way all the places like FFmpegDemuxer could distinguish what has actually happened e.g.:
- there was an IO error
- given container is not supported
- content is corrupted
- etc.
This sounds fine, but I'm curious how you will respond to the different error types? Do you have some recovery in mind? Do you just want a more verbose error message logged to chrome://media-internals?

Comment 7 by jwalc...@opera.com, Nov 14 2016

At the beginning just proper logs in media. Additionally we have a downstream project that needs to distinguish more error codes. But in general it seems incorrect to hide error codes from users of the glue code.
Status: WontFix (was: Assigned)
Marking as WontFix unless someone wants to do something with these error codes; it's fine to hide stuff like this unless we actually have a use for it.

Sign in to add a comment