in progress...

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/300be765de46941accbb0d12fee1dba27fd06bb0

commit 300be765de46941accbb0d12fee1dba27fd06bb0
Author: xidachen <xidachen@chromium.org>
Date: Tue Nov 01 13:18:12 2016

Consolidate implementation of ImageBitmapRenderingContext

To prepare for the shipping of ImageBitmapRenderingContext, we need more
layout test coverage. When we add more tests, we found that there are
some problem in our implementation.

1. transferFromImageBitmap API should be capable of throwing DOMException.
2. After calling transferFromImageBitmap(bitmap), the bitmap should be
   detached.
3. When calling transferFromImageBitmap(bitmap), if bitmap has already
   detached, this call should throw an InvalidStateError DOMException.

The corresponding layout test cases are added.

BUG= 659156 

Review-Url: https://codereview.chromium.org/2459233002
Cr-Commit-Position: refs/heads/master@{#428988}

[modify] https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0/third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-drawImage.html
[modify] https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0/third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-nullability.html
[modify] https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0/third_party/WebKit/LayoutTests/fast/canvas/webgl/offscreenCanvas-transferToImageBitmap-texImage2D.html
[modify] https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp
[modify] https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h
[modify] https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f411b5fe4cd193d6a8e88d990beea4ad0b604de

commit 4f411b5fe4cd193d6a8e88d990beea4ad0b604de
Author: rouslan <rouslan@chromium.org>
Date: Tue Nov 01 14:51:25 2016

Revert of Consolidate implementation of ImageBitmapRenderingContext (patchset #3 id:40001 of https://codereview.chromium.org/2459233002/ )

Reason for revert:
Speculative revert to fix offscreenCanvas-transferToImageBitmap-texImage2D.html.

Failed build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1347

Error message is not helpful: "renderer crashed."

Original issue's description:
> Consolidate implementation of ImageBitmapRenderingContext
>
> To prepare for the shipping of ImageBitmapRenderingContext, we need more
> layout test coverage. When we add more tests, we found that there are
> some problem in our implementation.
>
> 1. transferFromImageBitmap API should be capable of throwing DOMException.
> 2. After calling transferFromImageBitmap(bitmap), the bitmap should be
>    detached.
> 3. When calling transferFromImageBitmap(bitmap), if bitmap has already
>    detached, this call should throw an InvalidStateError DOMException.
>
> The corresponding layout test cases are added.
>
> BUG= 659156 
>
> Committed: https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0
> Cr-Commit-Position: refs/heads/master@{#428988}

TBR=junov@chromium.org,xidachen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 659156 

Review-Url: https://codereview.chromium.org/2464093002
Cr-Commit-Position: refs/heads/master@{#429002}

[modify] https://crrev.com/4f411b5fe4cd193d6a8e88d990beea4ad0b604de/third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-drawImage.html
[modify] https://crrev.com/4f411b5fe4cd193d6a8e88d990beea4ad0b604de/third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-nullability.html
[modify] https://crrev.com/4f411b5fe4cd193d6a8e88d990beea4ad0b604de/third_party/WebKit/LayoutTests/fast/canvas/webgl/offscreenCanvas-transferToImageBitmap-texImage2D.html
[modify] https://crrev.com/4f411b5fe4cd193d6a8e88d990beea4ad0b604de/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp
[modify] https://crrev.com/4f411b5fe4cd193d6a8e88d990beea4ad0b604de/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h
[modify] https://crrev.com/4f411b5fe4cd193d6a8e88d990beea4ad0b604de/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl

The tests are upstreamed here:

https://github.com/w3c/web-platform-tests/pull/4167

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/807358546cf4a8451044f63c3198039004f80de1

commit 807358546cf4a8451044f63c3198039004f80de1
Author: xidachen <xidachen@chromium.org>
Date: Wed Nov 09 17:01:12 2016

Consolidate implementation of ImageBitmapRenderingContext

To prepare for the shipping of ImageBitmapRenderingContext, we need more
layout test coverage. When we add more tests, we found that there are
some problem in our implementation.

1. transferFromImageBitmap API should be capable of throwing DOMException.
2. After calling transferFromImageBitmap(bitmap), the bitmap should be
   detached.
3. When calling transferFromImageBitmap(bitmap), if bitmap has already
   detached, this call should throw an InvalidStateError DOMException.

The corresponding layout test cases are added.

BUG= 659156 

Committed: https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0
Review-Url: https://codereview.chromium.org/2459233002
Cr-Original-Commit-Position: refs/heads/master@{#428988}
Cr-Commit-Position: refs/heads/master@{#430954}

[modify] https://crrev.com/807358546cf4a8451044f63c3198039004f80de1/third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-drawImage.html
[modify] https://crrev.com/807358546cf4a8451044f63c3198039004f80de1/third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-nullability.html
[modify] https://crrev.com/807358546cf4a8451044f63c3198039004f80de1/third_party/WebKit/LayoutTests/fast/canvas/webgl/offscreenCanvas-transferToImageBitmap-texImage2D.html
[modify] https://crrev.com/807358546cf4a8451044f63c3198039004f80de1/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp
[modify] https://crrev.com/807358546cf4a8451044f63c3198039004f80de1/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h
[modify] https://crrev.com/807358546cf4a8451044f63c3198039004f80de1/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl

The test is now on web-platform-tests

Closing this bug.