New issue
Advanced search Search tips

Issue 659152 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Oct 31
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

DevTools: Autocompletion for ES6 Maps

Reported by timotij...@gmail.com, Oct 25 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36

Steps to reproduce the problem:
1. Create a plain object and a 'new Map' with various keys and values.
2. Where 'obj.' will autocomplete keys, 'map.' only autocompletes the native methods and properties. 'map.get(' does not autocomplete.

What is the expected behavior?

What went wrong?
This is understandable as from a technical perspective these are not own keys and in fact don't even have to be primitive strings, but can by any unique object.

However from an end-user perspective of the Dev Tools, it is a regression compared to the same concept expressed as a plain object. Since Maps are sometimes preferred over a plajn object for storing values at arbitrary string keys, it'd be nice if Dev Tools could make these easier to interact with.

Dev Tools Console recently gained the ability to autocomplete keys without triggering property accessors. It also gained the ability to keep history and therefore autocomplete arbitrary commands including method  string parameters etc.

Perhaps this logic can be extended to also inspect a Map and for the common case of where keys are primitives (numbers, strings, ..) provide intelligent autocompletion.

Did this work before? No 

Chrome version: 54.0.2840.71  Channel: stable
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 23.0 r0
 

Comment 1 by kayce@google.com, Oct 25 2016

Labels: DevTools-User-Facing
Components: Platform>DevTools>JavaScript
Labels: -Type-Bug -OS-Mac OS-All Type-Feature
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: DevTools: Autocompletion for ES6 Maps (was: Autocompletion for ES6 Maps)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22b7b42602956cc363a44cddf41c8bbeff1757d7

commit 22b7b42602956cc363a44cddf41c8bbeff1757d7
Author: chenwilliam <chenwilliam@chromium.org>
Date: Tue Jan 24 22:46:01 2017

Revert of DevTools: Console: Provide autocompletions for Maps (patchset #6 id:100001 of https://codereview.chromium.org/2639703002/ )

Reason for revert:
Causing closure compilation failure on main waterfall

Original issue's description:
> DevTools: Console: Provide autocompletions for Maps
>
> BUG= 659152 
>
> Review-Url: https://codereview.chromium.org/2639703002
> Cr-Commit-Position: refs/heads/master@{#445811}
> Committed: https://chromium.googlesource.com/chromium/src/+/a2ab5d688b1b01c2fa805a57762aa9d1e2c4499c

TBR=dgozman@chromium.org,luoe@chromium.org,einbinder@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 659152 

Review-Url: https://codereview.chromium.org/2656683003
Cr-Commit-Position: refs/heads/master@{#445846}

[modify] https://crrev.com/22b7b42602956cc363a44cddf41c8bbeff1757d7/third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions-expected.txt
[modify] https://crrev.com/22b7b42602956cc363a44cddf41c8bbeff1757d7/third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html
[modify] https://crrev.com/22b7b42602956cc363a44cddf41c8bbeff1757d7/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
[modify] https://crrev.com/22b7b42602956cc363a44cddf41c8bbeff1757d7/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

Status: Archived (was: Assigned)
Bulk closing low-priority issues with no activity. Please re-file and refer to the closed issue if it's essential to fix.

Sign in to add a comment