New issue
Advanced search Search tips

Issue 659150 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 659147



Sign in to add a comment

[ARC] Convert ios/chrome/app to ARC

Project Member Reported by stkhapugin@chromium.org, Oct 25 2016

Issue description

Convert all objc code in following files to ARC:

./chrome/app/BUILD.gn
./chrome/app/resources/BUILD.gn
./chrome/app/strings/BUILD.gn
./chrome/app/theme/BUILD.gn
 
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c729d2352ac75ddef20681351074810de122c559

commit c729d2352ac75ddef20681351074810de122c559
Author: mohsen <mohsen@chromium.org>
Date: Wed Oct 26 17:24:11 2016

Revert of [ObjC ARC] Converts ios/chrome/app to ARC. (patchset #1 id:1 of https://codereview.chromium.org/2449063002/ )

Reason for revert:
Compile failure on ios-device builder: https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-device/builds/26773

Original issue's description:
> [ObjC ARC] Converts ios/chrome/app to ARC.
>
> Notable changes:none.
>
> BUG= 659150 
> TEST=None.
>
> Committed: https://crrev.com/7a1f218b33faf5d0dd637f6a6854566e6cd80a3d
> Cr-Commit-Position: refs/heads/master@{#427722}

TBR=eugenebut@chromium.org,thestig@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 659150 

Review-Url: https://codereview.chromium.org/2453033002
Cr-Commit-Position: refs/heads/master@{#427729}

[modify] https://crrev.com/c729d2352ac75ddef20681351074810de122c559/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/c729d2352ac75ddef20681351074810de122c559/ios/chrome/app/application_delegate/memory_warning_helper.mm
[modify] https://crrev.com/c729d2352ac75ddef20681351074810de122c559/ios/chrome/app/deferred_initialization_runner.mm
[modify] https://crrev.com/c729d2352ac75ddef20681351074810de122c559/ios/chrome/app/safe_mode_crashing_modules_config.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96c43169eb84d09f2fe89cb628591b8008d4d543

commit 96c43169eb84d09f2fe89cb628591b8008d4d543
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Nov 15 15:40:32 2016

[ObjC ARC] Converts ios/chrome/app/application_delegate to ARC.

Notable changes: none

BUG= 659150 

Review-Url: https://codereview.chromium.org/2500953002
Cr-Commit-Position: refs/heads/master@{#432184}

[modify] https://crrev.com/96c43169eb84d09f2fe89cb628591b8008d4d543/ios/chrome/app/application_delegate/BUILD.gn
[modify] https://crrev.com/96c43169eb84d09f2fe89cb628591b8008d4d543/ios/chrome/app/application_delegate/memory_warning_helper.mm

Components: Platform>ARC

Comment 5 by uekawa@google.com, Mar 30 2017

Components: -Platform>ARC
wrong ARC
Components: Infra>Client>ARC
Components: -Infra>Client>ARC Internals
Status: Verified (was: Assigned)

Sign in to add a comment