Using e.g. https://developer.apple.com/reference/coreimage/cidetector
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad251159eb951b5433a8dca6c1c4d2cce407b091 commit ad251159eb951b5433a8dca6c1c4d2cce407b091 Author: xianglu <xianglu@chromium.org> Date: Tue Nov 22 19:22:38 2016 ShapeDetection: Add FaceDetectorOptions for fastMode and maxDetectedFaces This CL adds FaceDetectorOptions to FaceDetector constructor, and changed mojo interface accordingly. It also adds two Layoutests to test correct propagation of FaceDetectorOptions. Naming style is fixed in shapedetection.mojom. BUG= 659139 , 646083 TEST= third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html third_party/WebKit/LayoutTests/shapedetection/shapedetection-options.html Review-Url: https://codereview.chromium.org/2502763005 Cr-Commit-Position: refs/heads/master@{#433940} [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/content/public/android/java/src/org/chromium/content/browser/shapedetection/ShapeDetectionImpl.java [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/LayoutTests/shapedetection/detectshape-HTMLImageElement.html [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/LayoutTests/shapedetection/resources/mock-shapedetection.js [add] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/LayoutTests/shapedetection/shapedetection-options.html [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/modules_idl_files.gni [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl [add] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/FaceDetectorOptions.idl [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/public/platform/modules/shapedetection/shapedetection.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f93d7bf6eaabf65f21875d4d609097e5fd2ba216 commit f93d7bf6eaabf65f21875d4d609097e5fd2ba216 Author: xianglu <xianglu@chromium.org> Date: Wed Nov 23 17:24:11 2016 This CL moves initialization of m_options from FaceDetector to its superclass ShapeDetector. BUG= 659139 , 646083 Review-Url: https://codereview.chromium.org/2527503003 Cr-Commit-Position: refs/heads/master@{#434196} [modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/LayoutTests/shapedetection/shapedetection-options.html [modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h [modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/public/platform/modules/shapedetection/shapedetection.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf153f33a517e34fdc48026c45a87bd3314b9400 commit cf153f33a517e34fdc48026c45a87bd3314b9400 Author: xianglu <xianglu@chromium.org> Date: Wed Dec 07 04:10:58 2016 This CL includes only code refactoring. Eliminate DetectorType enum in ShapeDetector.cpp. The real work (calling through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector respectively, so that ShapeDetector only does the shared work of processing image source. BUG= 646083 , 659139 Review-Url: https://codereview.chromium.org/2557513003 Cr-Commit-Position: refs/heads/master@{#436856} [modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp [modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3 commit b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3 Author: xianglu <xianglu@chromium.org> Date: Wed Jan 11 20:49:52 2017 Shape Detection: Move mojom interface to //services This CL moves Shape Detection mojo interfaces to //services, which exposes them to public instead of just Blink. No new code added. Blocking: https://codereview.chromium.org/2460723003/ TBR=haraken@chromium.org (mechanical move) BUG= 646083 , 659139 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2620083002 Cr-Commit-Position: refs/heads/master@{#442991} [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/BUILD.gn [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionFactory.java [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/browser/BUILD.gn [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/browser/DEPS [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/browser/BUILD.gn [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/browser/DEPS [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/android/BUILD.gn [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionProviderFactory.java [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionProviderImpl.java [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/app/mojo/content_browser_manifest.json [add] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/BUILD.gn [rename] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/OWNERS [rename] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/barcodedetection.mojom [rename] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/facedetection.mojom [rename] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/facedetection_provider.mojom [rename] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/textdetection.mojom [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/BUILD.gn [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/DEPS [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/TextDetector.h [modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/public/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb commit 6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb Author: xianglu <xianglu@chromium.org> Date: Wed Jan 25 04:30:41 2017 Shape Detection: Implement FaceDetection on Mac as out-of-process service This CL implements FaceDetection in //services/shape_detection. The Browser forwards requests from the Renderer process to a Utility process, which detects faces using Mac native CoreImage library and returns detection result. DESIGN_DOC=http://tinyurl.com/shape-detection-in-chromium BUG= 659139 TEST=content/browser/shapedetection/shapedetection_browsertest.cc CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2528743002 Cr-Commit-Position: refs/heads/master@{#445942} [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/content/browser/BUILD.gn [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/content/browser/service_manager/service_manager_context.cc [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/content/browser/shapedetection/face_detection_service_dispatcher.h [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/content/browser/shapedetection/shapedetection_browsertest.cc [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/content/public/app/BUILD.gn [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/content/utility/BUILD.gn [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/content/utility/DEPS [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/content/utility/utility_service_factory.cc [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/service_manager/public/cpp/connector.h [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/BUILD.gn [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/DEPS [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/README.md [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/face_detection_impl_mac.h [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/face_detection_impl_mac.mm [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/face_detection_provider_impl.cc [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/face_detection_provider_impl.h [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/manifest.json [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/public/interfaces/BUILD.gn [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/public/interfaces/constants.mojom [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/shape_detection_service.cc [add] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/services/shape_detection/shape_detection_service.h [modify] https://crrev.com/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3764134e53831644d51c780f3d9b3a50f8d43865 commit 3764134e53831644d51c780f3d9b3a50f8d43865 Author: mcasas <mcasas@chromium.org> Date: Mon Feb 13 20:14:20 2017 Shape detection unittests mac (QR and Face) in GPU bots This CL adds {Barcode,Face}Detection Mac unittests as part of service_unittests. These new tests are run in the gpu bots, bc the normal Mac bots don't have GPUs and that seems to screw the CoreImage library (FTR I tried loading the lib and symbols in runtime and/or using a software rendering context, see PS2, but that didn't solve the problem). BUG= 665150 , 659139 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2677553003 Cr-Commit-Position: refs/heads/master@{#450061} [modify] https://crrev.com/3764134e53831644d51c780f3d9b3a50f8d43865/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/3764134e53831644d51c780f3d9b3a50f8d43865/services/BUILD.gn [modify] https://crrev.com/3764134e53831644d51c780f3d9b3a50f8d43865/services/shape_detection/BUILD.gn [modify] https://crrev.com/3764134e53831644d51c780f3d9b3a50f8d43865/services/shape_detection/DEPS [add] https://crrev.com/3764134e53831644d51c780f3d9b3a50f8d43865/services/shape_detection/PRESUBMIT.py [modify] https://crrev.com/3764134e53831644d51c780f3d9b3a50f8d43865/services/shape_detection/barcode_detection_impl_mac.mm [add] https://crrev.com/3764134e53831644d51c780f3d9b3a50f8d43865/services/shape_detection/barcode_detection_impl_mac_unittest.mm [modify] https://crrev.com/3764134e53831644d51c780f3d9b3a50f8d43865/services/shape_detection/face_detection_impl_mac.mm [add] https://crrev.com/3764134e53831644d51c780f3d9b3a50f8d43865/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/3764134e53831644d51c780f3d9b3a50f8d43865/testing/buildbot/chromium.gpu.fyi.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcc0e7acd0729e980c81a73ba7968045470711e2 commit bcc0e7acd0729e980c81a73ba7968045470711e2 Author: gcasto <gcasto@chromium.org> Date: Mon Feb 13 21:24:44 2017 Revert of Shape detection unittests mac (QR and Face) in GPU bots (patchset #6 id:280001 of https://codereview.chromium.org/2677553003/ ) Reason for revert: This causes a failure in service_unittest for Mac 10.10: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests Original issue's description: > Shape detection unittests mac (QR and Face) in GPU bots > > This CL adds {Barcode,Face}Detection Mac unittests as part of > service_unittests. These new tests are run in the gpu bots, bc > the normal Mac bots don't have GPUs and that seems to screw > the CoreImage library (FTR I tried loading the lib and symbols in > runtime and/or using a software rendering context, see PS2, but > that didn't solve the problem). > > BUG= 665150 , 659139 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2677553003 > Cr-Commit-Position: refs/heads/master@{#450061} > Committed: https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b3a50f8d43865 TBR=rockot@chromium.org,kbr@chromium.org,rsesek@chromium.org,bajones@chromium.org,erg@chromium.org,bsalomon@chromium.org,bsalomon@google.com,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 665150 , 659139 Review-Url: https://codereview.chromium.org/2692123002 Cr-Commit-Position: refs/heads/master@{#450094} [modify] https://crrev.com/bcc0e7acd0729e980c81a73ba7968045470711e2/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/bcc0e7acd0729e980c81a73ba7968045470711e2/services/BUILD.gn [modify] https://crrev.com/bcc0e7acd0729e980c81a73ba7968045470711e2/services/shape_detection/BUILD.gn [modify] https://crrev.com/bcc0e7acd0729e980c81a73ba7968045470711e2/services/shape_detection/DEPS [delete] https://crrev.com/cda5197c6532a6ff59171f0bbcb5b34e0652b3db/services/shape_detection/PRESUBMIT.py [modify] https://crrev.com/bcc0e7acd0729e980c81a73ba7968045470711e2/services/shape_detection/barcode_detection_impl_mac.mm [delete] https://crrev.com/cda5197c6532a6ff59171f0bbcb5b34e0652b3db/services/shape_detection/barcode_detection_impl_mac_unittest.mm [modify] https://crrev.com/bcc0e7acd0729e980c81a73ba7968045470711e2/services/shape_detection/face_detection_impl_mac.mm [delete] https://crrev.com/cda5197c6532a6ff59171f0bbcb5b34e0652b3db/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/bcc0e7acd0729e980c81a73ba7968045470711e2/testing/buildbot/chromium.gpu.fyi.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f59d2c0512aae8b641dab53f6a44c407c5f8086 commit 7f59d2c0512aae8b641dab53f6a44c407c5f8086 Author: mcasas <mcasas@chromium.org> Date: Tue Feb 14 02:50:42 2017 RELAND: Shape detection unittests mac (QR and Face) in GPU bots The original CL got reverted due to failing in the Mac10.10Tests bot, which was not adequately filtered out because it wasn't in the CQ :-) This reland uses --use-gpu-in-tests like all other GPU-specific tests, checking its presence in the added files. TBR=rockot@chromium.org, rsesek@chromium.org, kbr@chromium.org, bsalomon@chromium.org, erg@chromium.org since the changes are straightforward and only affect tests. Original CL description ------------------------------------------------ Shape detection unittests mac (QR and Face) in GPU bots This CL adds {Barcode,Face}Detection Mac unittests as part of service_unittests. These new tests are run in the gpu bots, bc the normal Mac bots don't have GPUs and that seems to screw the CoreImage library (FTR I tried loading the lib and symbols in runtime and/or using a software rendering context, see PS2, but that didn't solve the problem). BUG= 665150 , 659139 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2677553003 Cr-Commit-Position: refs/heads/master@{#450061} Committed: https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b3a50f8d43865 patch from issue 2677553003 at patchset 280001 (http://crrev.com/2677553003#ps280001) Review-Url: https://codereview.chromium.org/2690253002 Cr-Commit-Position: refs/heads/master@{#450213} [modify] https://crrev.com/7f59d2c0512aae8b641dab53f6a44c407c5f8086/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/7f59d2c0512aae8b641dab53f6a44c407c5f8086/services/BUILD.gn [modify] https://crrev.com/7f59d2c0512aae8b641dab53f6a44c407c5f8086/services/shape_detection/BUILD.gn [modify] https://crrev.com/7f59d2c0512aae8b641dab53f6a44c407c5f8086/services/shape_detection/DEPS [add] https://crrev.com/7f59d2c0512aae8b641dab53f6a44c407c5f8086/services/shape_detection/PRESUBMIT.py [modify] https://crrev.com/7f59d2c0512aae8b641dab53f6a44c407c5f8086/services/shape_detection/barcode_detection_impl_mac.mm [add] https://crrev.com/7f59d2c0512aae8b641dab53f6a44c407c5f8086/services/shape_detection/barcode_detection_impl_mac_unittest.mm [modify] https://crrev.com/7f59d2c0512aae8b641dab53f6a44c407c5f8086/services/shape_detection/face_detection_impl_mac.mm [add] https://crrev.com/7f59d2c0512aae8b641dab53f6a44c407c5f8086/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/7f59d2c0512aae8b641dab53f6a44c407c5f8086/testing/buildbot/chromium.gpu.fyi.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e48e4fcb452ba756a04f1b163123cbd54c485ed commit 2e48e4fcb452ba756a04f1b163123cbd54c485ed Author: kbr <kbr@chromium.org> Date: Wed Feb 15 07:06:40 2017 Disable service_unittests on Mac Pros. They're failing on these machines. I don't have time to investigate why. BUG= 659139 , 665150 TBR=zmo@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2694193005 Cr-Commit-Position: refs/heads/master@{#450620} [modify] https://crrev.com/2e48e4fcb452ba756a04f1b163123cbd54c485ed/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/2e48e4fcb452ba756a04f1b163123cbd54c485ed/testing/buildbot/chromium.gpu.fyi.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a7e01bdad5216e739c2a18d1f0ff907641f6609 commit 2a7e01bdad5216e739c2a18d1f0ff907641f6609 Author: kbr <kbr@chromium.org> Date: Fri Feb 17 00:38:17 2017 Convert remaining PostUploadHooks to use EnsureCQIncludeTrybotsAreAdded. BUG= 665150 , 659139 ,688765 TBR=dbeam@chromium.org,clamy@chromium.org,rockot@chromium.org,mcasas@chromium.org,dpranke@chromium.org,pdr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2701603004 Cr-Commit-Position: refs/heads/master@{#451158} [modify] https://crrev.com/2a7e01bdad5216e739c2a18d1f0ff907641f6609/chrome/browser/resources/PRESUBMIT.py [modify] https://crrev.com/2a7e01bdad5216e739c2a18d1f0ff907641f6609/content/browser/frame_host/PRESUBMIT.py [modify] https://crrev.com/2a7e01bdad5216e739c2a18d1f0ff907641f6609/services/shape_detection/PRESUBMIT.py [modify] https://crrev.com/2a7e01bdad5216e739c2a18d1f0ff907641f6609/third_party/WebKit/PRESUBMIT.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff90d3219a44a5b97d83ea1d1d7704efe32a5e91 commit ff90d3219a44a5b97d83ea1d1d7704efe32a5e91 Author: horo <horo@chromium.org> Date: Tue Mar 21 05:21:27 2017 Add shapedetection-cross-origin.html of mojo-loading virtual tests to TestExpectations BUG= 659139 TBR=xianglu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2762073002 Cr-Commit-Position: refs/heads/master@{#458319} [modify] https://crrev.com/ff90d3219a44a5b97d83ea1d1d7704efe32a5e91/third_party/WebKit/LayoutTests/TestExpectations
Comment 1 by mcasas@chromium.org
, Nov 14 2016Summary: Implement Face Detection API for Mac (was: Implement Shape Detection API for Mac)