New issue
Advanced search Search tips

Issue 659137 link

Starred by 2 users
Status: Duplicate
Merged: issue webrtc:7064
Owner:
hbos@chromium.org
Closed: Jan 2017
Cc:
hta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue webrtc:6757
issue 669877
Blocking:
issue 657854
issue 627816
issue 660827



Sign in to add a comment

RTCPeerConnection.getStats: RTCMediaStreamTrackStats

Project Member Reported by hbos@chromium.org, Oct 25 2016 
Add RTCMediaStreamTrackStats and all of its members.
https://w3c.github.io/webrtc-stats/#mststats-dict*

dictionary RTCMediaStreamTrackStats : RTCStats {
    DOMString           trackIdentifier;
    boolean             remoteSource;
    boolean             ended;
    boolean             detached;
    sequence<DOMString> ssrcIds;
    unsigned long       frameWidth;
    unsigned long       frameHeight;
    double              framesPerSecond;
    unsigned long       framesSent;
    unsigned long       framesReceived;
    unsigned long       framesDecoded;
    unsigned long       framesDropped;
    unsigned long       framesCorrupted;
    unsigned long       partialFramesLost;
    unsigned long       fullFramesLost;
    double              audioLevel;
    double              echoReturnLoss;
    double              echoReturnLossEnhancement;
};

Comment 1 by hbos@chromium.org, Oct 31 2016

Blocking: 660827

Comment 3 by hbos@webrtc.org, Nov 23 2016

Blockedon: webrtc:6757

Comment 4 by anatolid@chromium.org, Nov 29 2016

Labels: M-57

Comment 5 by hbos@chromium.org, Nov 30 2016

Blockedon: 669877
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60

commit 1f8239ca6f887ecb8c2c8347c00b5ac681e83c60
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 16 12:24:10 2017

TrackMediaInfoMap added.

This maps, in both directions, [Audio/Video]TrackInterface with
[Voice/Video][Sender/Receiver]Info.

This mapping is necessary for RTCStatsCollector to know the relationship
between RTCMediaStreamTrackStats and RTC[In/Out]boundRTPStreamStats, and
to be able to collect several RTCMediaStreamTrackStats stats.

BUG= webrtc:6757 ,  chromium:659137 ,  chromium:657854 ,  chromium:627816 

Review-Url: https://codereview.webrtc.org/2611983002
Cr-Commit-Position: refs/heads/master@{#16090}

[modify] https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/BUILD.gn
[add] https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/test/mock_rtpreceiver.h
[add] https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/test/mock_rtpsender.h
[add] https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/trackmediainfomap.cc
[add] https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/trackmediainfomap.h
[add] https://crrev.com/1f8239ca6f887ecb8c2c8347c00b5ac681e83c60/webrtc/api/trackmediainfomap_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d28adf3696a330580b5fb705531322ca4f9f3297

commit d28adf3696a330580b5fb705531322ca4f9f3297
Author: hbos <hbos@chromium.org>
Date: Mon Jan 16 12:56:26 2017

RTCPeerConnection.getStats whitelist updated due to recent spec changes.

RTCRTPStreamStats.mediaTrackId renamed trackId: https://github.com/w3c/webrtc-stats/issues/113#issuecomment-271548836
RTCMediaStreamTrackStats.kind added: https://github.com/w3c/webrtc-stats/pull/127
RTCPeerConnectionStats.dataChannels[Opened/Closed/Requested/Accepted] added: https://github.com/w3c/webrtc-stats/pull/125/files
RTCTransportStats.activeConnection replaced by dtlsState: https://github.com/w3c/webrtc-stats/pull/122/files

BUG= chromium:657854 ,  chromium:659137 ,  chromium:679741 ,  chromium:653873 ,  chromium:627816 

Review-Url: https://codereview.chromium.org/2621733004
Cr-Commit-Position: refs/heads/master@{#443879}

[modify] https://crrev.com/d28adf3696a330580b5fb705531322ca4f9f3297/chrome/test/data/webrtc/peerconnection_getstats.js
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/9e30274c03c8e812abeb37c7876648e3cae0805a

commit 9e30274c03c8e812abeb37c7876648e3cae0805a
Author: hbos <hbos@webrtc.org>
Date: Fri Jan 20 10:47:10 2017

RTCMediaStreamTrackStats collected on a per-attachment basis.

According to recent spec change:
https://github.com/w3c/webrtc-stats/pull/138/files

This establishes the relationship between tracks and
[Voice/Video][Sender/Receiver]Info(s). Follow-up CLs will easily be able
to collect more stats from them.

BUG= webrtc:6757 ,  chromium:659137 ,  chromium:627816 

Review-Url: https://codereview.webrtc.org/2641763003
Cr-Commit-Position: refs/heads/master@{#16181}

[modify] https://crrev.com/9e30274c03c8e812abeb37c7876648e3cae0805a/webrtc/api/rtcstats_integrationtest.cc
[modify] https://crrev.com/9e30274c03c8e812abeb37c7876648e3cae0805a/webrtc/api/rtcstatscollector.cc
[modify] https://crrev.com/9e30274c03c8e812abeb37c7876648e3cae0805a/webrtc/api/rtcstatscollector_unittest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61

commit 50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 23 15:21:55 2017

RTCMediaStreamTrackStats.framesDropped collected by RTCStatsCollector.

Spec: https://w3c.github.io/webrtc-stats/#dom-rtcmediastreamtrackstats-framesdropped
Implemented as frames_received - frames_rendered.

Part of this CL is adding frames_rendered to VideoReceiveStream::Stats
and updating it at ReceiveStatisticsProxy::OnRenderedFrame.

BUG= webrtc:6757 ,  chromium:659137 ,  chromium:627816 
NOTRY=True

Review-Url: https://codereview.webrtc.org/2607933002
Cr-Commit-Position: refs/heads/master@{#16213}

[modify] https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/api/stats/rtcstats_objects.h
[modify] https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/media/base/mediachannel.h
[modify] https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/pc/rtcstats_integrationtest.cc
[modify] https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/pc/rtcstatscollector.cc
[modify] https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/pc/rtcstatscollector_unittest.cc
[modify] https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/video/receive_statistics_proxy.cc
[modify] https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/video/receive_statistics_proxy_unittest.cc
[modify] https://crrev.com/50cfe1fda7f2b4a6a449fe7234f4c1aa2a475c61/webrtc/video_receive_stream.h

Comment 15 by hbos@chromium.org, Jan 26 2017

Labels: -M-57
Mergedinto: webrtc:7064
Status: Duplicate (was: Started)
This stats dictionary is partially supported (see landed CLs in this thread).
To better track what's left, a webrtc bug has been created to track the remaining work related to this dictionary - merging into that one.
►

Sign in to add a comment