New issue
Advanced search Search tips

Issue 659127 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Bug



Sign in to add a comment

rebaseline-cl failed on android_blink_rel in _check_configuration_and_target

Project Member Reported by liyuqian@google.com, Oct 25 2016

Issue description

When I run "third_party/WebKit/Tools/Scripts/webkit-patch rebaseline-cl" on my Goobuntu, I got the following error. The error will be gone if I exclude the android_blink_rel by modifying third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.py



Rebaselining virtual/android/fullscreen/video-scrolled-iframe.html
Traceback (most recent call last):
  File "third_party/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "third_party/WebKit/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py", line 122, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py", line 110, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py", line 83, in execute
    self.rebaseline(options, test_prefix_list)
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 506, in rebaseline
    test_prefix_list, options)
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 343, in _rebaseline_commands
    builders_to_fetch_from = self._builders_to_fetch_from(self._builder_names(test_prefix_list[test_prefix]))
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 315, in _builders_to_fetch_from
    port = self._tool.port_factory.get_from_builder_name(builder)
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 187, in get_from_builder_name
    return self.get(port_name, _builder_options(builder_name))
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 169, in get
    return cls(self._host, port_name, options=options, **kwargs)
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py", line 274, in __init__
    self._host_port = factory.PortFactory(host).get(**kwargs)
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 152, in get
    _check_configuration_and_target(self._host.filesystem, options)
  File "/usr/local/google/home/liyuqian/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 76, in _check_configuration_and_target
    raise ValueError('Configuration does not match the GN build args.')
ValueError: Configuration does not match the GN build args.
 
Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
Interesting! Thanks for filing this bug.

In this part of the code in (_rebaseline_commands) it's actually only deciding which builders it should fetch baselines from, and in theory, it shouldn't need to check anything on the local filesystem to do that...
Summary: rebaseline-cl failed on android_blink_rel in _check_configuration_and_target (was: rebaseline-cl failed on android_blink_rel)
Owner: ----
Status: Archived (was: Assigned)
Haven't seen this again in the past 6 months, maybe it has been fixed somehow, should refile or reopen if we see something similar later.

Sign in to add a comment