New issue
Advanced search Search tips

Issue 659117 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue webrtc:7061
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue webrtc:6754

Blocking:
issue 627816
issue 657854



Sign in to add a comment

RTCPeerConnection.getStats: RTCCodecStats

Project Member Reported by hbos@chromium.org, Oct 25 2016

Issue description

Add RTCCodecStats and all of its members.
https://w3c.github.io/webrtc-stats/#codec-dict*

dictionary RTCCodecStats : RTCStats {
    unsigned long payloadType;
    DOMString     codec;
    unsigned long clockRate;
    unsigned long channels;
    DOMString     parameters;
    DOMString     implementation;
};
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/a65704b5c905c97970f28eb3d1df7369a700efdf

commit a65704b5c905c97970f28eb3d1df7369a700efdf
Author: hbos <hbos@webrtc.org>
Date: Mon Nov 14 10:28:16 2016

Expose RtpCodecParameters to VideoMediaInfo stats.

Payload type -> RtpCodecParameters maps added for sender and receiver
side. It contains information that will be needed for RTCCodecStats[1]
dictionaries.

Video[Sender/Receiver]Info is updated with current codec payload type
for every stream which can be used to look up the codec in
VideoMediaInfo.

A similar change should be made for VoiceMediaInfo and
Voice[Sender/Receiver]Info.

[1] https://w3c.github.io/webrtc-stats/#codec-dict*

BUG= chromium:659117 

Review-Url: https://codereview.webrtc.org/2484193002
Cr-Commit-Position: refs/heads/master@{#15060}

[modify] https://crrev.com/a65704b5c905c97970f28eb3d1df7369a700efdf/webrtc/media/base/mediachannel.h
[modify] https://crrev.com/a65704b5c905c97970f28eb3d1df7369a700efdf/webrtc/media/base/videoengine_unittest.h
[modify] https://crrev.com/a65704b5c905c97970f28eb3d1df7369a700efdf/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/a65704b5c905c97970f28eb3d1df7369a700efdf/webrtc/media/engine/webrtcvideoengine2.h

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/1acfbd22cc30bc72af53187f25f3c389792968d3

commit 1acfbd22cc30bc72af53187f25f3c389792968d3
Author: hbos <hbos@webrtc.org>
Date: Fri Nov 18 07:43:29 2016

Expose RtpCodecParameters to VoiceMediaInfo stats.

Payload type -> RtpCodecParameters maps added for sender and receiver.
This is a follow-up to https://codereview.webrtc.org/2484193002/ which
did the same thing for VideoMediaInfo. This information will be used to
produce RTCCodecStats[1].

Voice[Sender/Receiver]Info is updated with current codec payload type
for every stream which can be used to look up the codec in
VoiceMediaInfo.

[1] https://w3c.github.io/webrtc-stats/#codec-dict*

BUG= chromium:659117 

Review-Url: https://codereview.webrtc.org/2503383002
Cr-Commit-Position: refs/heads/master@{#15144}

[modify] https://crrev.com/1acfbd22cc30bc72af53187f25f3c389792968d3/webrtc/api/call/audio_receive_stream.h
[modify] https://crrev.com/1acfbd22cc30bc72af53187f25f3c389792968d3/webrtc/api/call/audio_send_stream.cc
[modify] https://crrev.com/1acfbd22cc30bc72af53187f25f3c389792968d3/webrtc/api/call/audio_send_stream.h
[modify] https://crrev.com/1acfbd22cc30bc72af53187f25f3c389792968d3/webrtc/audio/audio_receive_stream.cc
[modify] https://crrev.com/1acfbd22cc30bc72af53187f25f3c389792968d3/webrtc/audio/audio_send_stream.cc
[modify] https://crrev.com/1acfbd22cc30bc72af53187f25f3c389792968d3/webrtc/media/base/mediachannel.h
[modify] https://crrev.com/1acfbd22cc30bc72af53187f25f3c389792968d3/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/1acfbd22cc30bc72af53187f25f3c389792968d3/webrtc/media/engine/webrtcvoiceengine.cc
[modify] https://crrev.com/1acfbd22cc30bc72af53187f25f3c389792968d3/webrtc/media/engine/webrtcvoiceengine_unittest.cc

Comment 4 by hbos@webrtc.org, Nov 23 2016

Blockedon: webrtc:6754
Labels: M-57
Labels: -M-57 M-58
Bumping this to M58. Please correct if that's wrong.

Comment 7 by hbos@chromium.org, Jan 26 2017

Labels: -M-58
Mergedinto: webrtc:7061
Status: Duplicate (was: Started)
This stats dictionary is partially supported (see landed CLs in this thread).
To better track what's left, a webrtc bug has been created to track the remaining work related to this dictionary - merging into that one.

Sign in to add a comment