New issue
Advanced search Search tips

Issue 659110 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Jan 10
Cc:
rdevlin....@chromium.org
adamk@chromium.org
haraken@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

extensions should use the intrinsics list to store original v8 methods instead of an v8-extension

Project Member Reported by jochen@chromium.org, Oct 25 2016 
There's currently just one exposed, but it's easy to expose all needed intrinsics:

https://cs.chromium.org/chromium/src/v8/include/v8.h?rcl=0&l=4613

The advantage of using them is that they don't need to be copied out during context creation, but the chrome extension system can get them whenever it needs them.

Comment 1 by adamk@chromium.org, Oct 25 2016 

I believe the current API only makes the intrinsics usable with v8::Templates; does the extension system use templates to store the intrinsics it copies over?

Comment 2 by eisinger@google.com, Oct 25 2016 

ah, ok

extensions copy out the objects, see here: https://cs.chromium.org/chromium/src/extensions/renderer/safe_builtins.h?sq=package:chromium

Comment 3 by jochen@chromium.org, Oct 27 2016 

actually, the extensions system could just create an object template that has all the intrinsics it needs, and instantiate the object once for itself to get to them

Comment 4 by benhenry@google.com, Jan 10

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.
►

Sign in to add a comment