Issue 659099 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Apr 2017
Cc:	gambard@chromium.org olivierrobin@chromium.org █ jif@chromium.org ios-bugs@chromium.org
Components:	UI>Browser>ReaderMode
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	3
Type:	Bug
Hotlist-ReadingList

Store all ReadingListEntries in a single container.

Project Member Reported by jif@chromium.org, Oct 25 2016

Issue description

Things would be cleaner in the ReadingListModel if we didn't maintain the Read and Unread entries in 2 different containers.

Also, the API we currently expose is misleading: GetUnreadEntryAtIndex and GetReadEntryAtIndex should return pointers (that can be null), instead of references.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad74ddb4727198767e957dd95d073969f92bcdb9

commit ad74ddb4727198767e957dd95d073969f92bcdb9
Author: jif <jif@chromium.org>
Date: Tue Oct 25 15:40:58 2016

Add GetEntryFromURL method to the ReadingListModel.

BUG=  659099 

Review-Url: https://codereview.chromium.org/2436743002
Cr-Commit-Position: refs/heads/master@{#427362}

[modify] https://crrev.com/ad74ddb4727198767e957dd95d073969f92bcdb9/ios/chrome/browser/reading_list/reading_list_model.h
[modify] https://crrev.com/ad74ddb4727198767e957dd95d073969f92bcdb9/ios/chrome/browser/reading_list/reading_list_model_impl.cc
[modify] https://crrev.com/ad74ddb4727198767e957dd95d073969f92bcdb9/ios/chrome/browser/reading_list/reading_list_model_impl.h
[modify] https://crrev.com/ad74ddb4727198767e957dd95d073969f92bcdb9/ios/chrome/browser/reading_list/reading_list_model_unittest.cc

Comment 2 by linds...@chromium.org, Mar 30 2017

Components: UI>Browser>ReaderMode
Labels: Hotlist-ReadingList

Comment 3 by olivierrobin@chromium.org, Apr 3 2017

Status: Fixed (was: Available)

►

Issue 659099 link

Issue metadata

Store all ReadingListEntries in a single container.

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 25 2016

Comment 1 Deleted

Comment 2 by linds...@chromium.org, Mar 30 2017

Comment 2 Deleted

Comment 3 by olivierrobin@chromium.org, Apr 3 2017

Comment 3 Deleted

Sign in to add a comment