New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659069 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 659094



Sign in to add a comment

1.4% regression in memory.top_10_mobile at 426329:426445

Project Member Reported by alexclarke@chromium.org, Oct 25 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=659069

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgnbHspAoM


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 25 2016

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1757
Failure reason: the build has failed due to infrastructure failure.

Blockedon: 659094
Status: WontFix (was: Untriaged)
regression is followed by an improvement of the same magnitude at r426687. Closing.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Apr 11 2017

Cc: kainino@chromium.org
Owner: kainino@chromium.org

=== Auto-CCing suspected CL author kainino@chromium.org ===

Hi kainino@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : kainino
  Commit : 884e8e8ad9cf667829d80f4bd222a0369baa088b
  Date   : Wed Oct 19 23:46:14 2016
  Subject: Implement a prototype for the proposed getBufferSubDataAsync entry point specified in this WebGL PR:

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:ashmem:proportional_resident_size_avg/background/after_http_en_m_wikipedia_org_wiki_Science
  Change       : 0.97% | 1265664.0 -> 1277952.0

Revision             Result              N
chromium@426328      1265664 +- 0.0      6      good
chromium@426332      1265664 +- 0.0      6      good
chromium@426334      1265664 +- 0.0      6      good
chromium@426335      1277952 +- 0.0      6      bad       <--
chromium@426336      1277952 +- 0.0      6      bad
chromium@426343      1277952 +- 0.0      6      bad
chromium@426358      1277952 +- 0.0      6      bad
chromium@426387      1277952 +- 0.0      6      bad
chromium@426445      1277952 +- 0.0      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982667370030370416

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4997956195844096


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
The only memory increase should have been:
 893   HeapHashSet<Member<WebGLGetBufferSubDataAsyncCallback>>
 894       m_getBufferSubDataAsyncCallbacks;
https://chromiumcodereview.appspot.com/2379203002/diff/420001/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

which should have been really small.
Per #5 I guess I can ignore this? If it's reopened I'll investigate.

Sign in to add a comment