Issue metadata
Sign in to add a comment
|
1.4% regression in memory.top_10_mobile at 426329:426445 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 25 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8997836004233953392
,
Oct 25 2016
Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1757 Failure reason: the build has failed due to infrastructure failure.
,
Oct 25 2016
,
Dec 9 2016
regression is followed by an improvement of the same magnitude at r426687. Closing.
,
Apr 10 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982667370030370416
,
Apr 11 2017
=== Auto-CCing suspected CL author kainino@chromium.org === Hi kainino@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : kainino Commit : 884e8e8ad9cf667829d80f4bd222a0369baa088b Date : Wed Oct 19 23:46:14 2016 Subject: Implement a prototype for the proposed getBufferSubDataAsync entry point specified in this WebGL PR: Bisect Details Configuration: android_one_perf_bisect Benchmark : memory.top_10_mobile Metric : memory:chrome:all_processes:reported_by_os:system_memory:ashmem:proportional_resident_size_avg/background/after_http_en_m_wikipedia_org_wiki_Science Change : 0.97% | 1265664.0 -> 1277952.0 Revision Result N chromium@426328 1265664 +- 0.0 6 good chromium@426332 1265664 +- 0.0 6 good chromium@426334 1265664 +- 0.0 6 good chromium@426335 1277952 +- 0.0 6 bad <-- chromium@426336 1277952 +- 0.0 6 bad chromium@426343 1277952 +- 0.0 6 bad chromium@426358 1277952 +- 0.0 6 bad chromium@426387 1277952 +- 0.0 6 bad chromium@426445 1277952 +- 0.0 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8982667370030370416 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=4997956195844096 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 11 2017
The only memory increase should have been: 893 HeapHashSet<Member<WebGLGetBufferSubDataAsyncCallback>> 894 m_getBufferSubDataAsyncCallbacks; https://chromiumcodereview.appspot.com/2379203002/diff/420001/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h which should have been really small. Per #5 I guess I can ignore this? If it's reopened I'll investigate. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by alexclarke@chromium.org
, Oct 25 2016