Issue metadata
Sign in to add a comment
|
26.7%-50% regression in blink_perf.dom at 426306:426445 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 25 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8997836196751791344
,
Oct 25 2016
=== Auto-CCing suspected CL author nainar@chromium.org === Hi nainar@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Move Layout Tree Construction code into Element::rebuildLayoutTree() Author : nainar Commit description: This patch uses the two dirty bits (NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree) on Node and adds the relevant getters/setters for them. It makes rebuildLayoutTree() public to be accessed in Document.cpp. It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and uses dirtyBits to call either reattachLayoutTree() on node itself or call rebuildLayoutTree() on children nodes. Also added some comments explaining some design decisions. Will be removed upon completion of separation. BUG= 595137 Review-Url: https://chromiumcodereview.appspot.com/2398293003 Cr-Commit-Position: refs/heads/master@{#426353} Commit : 09b7a8cf0647abca732b3718987a629d12a67fee Date : Thu Oct 20 00:33:46 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@426349 33.9939 1.41323 5 good chromium@426352 35.2363 0.296607 5 good chromium@426353 25.1237 0.281029 4 bad <-- chromium@426354 25.2293 0.15723 5 bad Bisect job ran on: android_nexus5X_perf_bisect Bug ID: 659054 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom Test Metric: select-single-remove/select-single-remove Relative Change: 25.78% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/792 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997836196751791344 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5231287139303424 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Oct 25 2016
This patch was reverted due to bug 658322. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by alexclarke@chromium.org
, Oct 25 2016