New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659042 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3% regression in thread_times.key_idle_power_cases at 426993:426995

Project Member Reported by alexclarke@chromium.org, Oct 25 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=659042

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg3YaJtgsM


Bot(s) for this bug's original alert(s):

android-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 25 2016

Cc: fdoray@chromium.org
Owner: fdoray@chromium.org

=== Auto-CCing suspected CL author fdoray@chromium.org ===

Hi fdoray@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Use TRACE_TASK_EXECUTION in SequencedWorkerPool.
Author  : fdoray
Commit description:
  
With this CL, SequencedWorkerPool generates an event in the "toplevel"
category when it runs a task. This is the same behavior as MessageLoop,
TaskScheduler and WorkerPool.

BUG= 611818 

Review-Url: https://chromiumcodereview.appspot.com/2429863002
Cr-Commit-Position: refs/heads/master@{#426994}
Commit  : af4072ecf86c2c8ff7ec217e4830e2c2e5964cf7
Date    : Sun Oct 23 13:41:49 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev     N  Good?
chromium@426992  2.97212  0.0121816   5  good
chromium@426993  2.96586  0.0163412   5  good
chromium@426994  3.03704  0.0187683   5  bad    <--
chromium@426995  3.05498  0.00898794  5  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 659042

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.key_idle_power_cases
Test Metric: tasks_per_second_total_all/set-timeout.html (Long Idle)
Relative Change: 2.79%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/789
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997836767099528192


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6374517910274048

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by fdoray@chromium.org, Oct 25 2016

Status: WontFix (was: Untriaged)
This is expected.

https://chromiumcodereview.appspot.com/2429863002 didn't cause a regression. It simply made the metric more accurate by generating tracing events for tasks running in SequencedWorkerPools.

See the BrowserBlockingWorker/* and SimpleCacheWorker/* threads shown in https://00e9e64bace1b5e163014926f3b5b680dd2572746d77c8f1fb-apidata.googleusercontent.com/download/storage/v1/b/chrome-telemetry-output/o/trace-file-id_5-2016-10-23_08-22-15-68373.html?qk=AD5uMEsioM7azD78UFX6B-uGTjF8PcwfiaupDIurcKUlOIc1ZvjRZxUp1Fd9xva4jwE1rpOMxaRpemMW6kTZdQ0kpSfBmVw8TwlISYnTKGKoBHtk02_cA-a5JawmTcBaRYnWy5x4rPvH3y8mWWJJcq0jkbqZaHF2O0TN1PhnAjrZURD_DZOvrbhLmJVxI6N-nJz9lM2Z4Lp1FNVC5q9wUuZDedBbCrYHF1NtvCENQI7rZOwXIE61hUqwviVc5z4mTtkT6gsmWTo9w38ZeOLCPOysDzU6U_y1HusVyD84iCV90h66XoC_xJOJM2-2LygZqDiqZf92iMkMXNxW-XS9-6XSlS2Bp7YSnkRwS0TeCKgWXtDXhAXd5Q7qHS6qnOUrZGGz4aODPi3RfttjXlL9Af8U3HMZgtATxWl0gohoWn4zeMJlF9J3FeOMmmCjGAutfymZQm4U-MOhm-db7y1vCNIzQhcGg0LqhXJxx3d_dv9Rptc22uYADm0UmVG-q6MnaUicqd3hVALNwLOCA9tnHdMCfOKsMLyFgeOAnVBd1e5R1NvQp46FO5K9M1O-ehzF4-0JvDhnENdAqEqMOn2KagllHzVETfhgobU8spF7KpalJE6twSfxRfjqueLrd7fz6ywns50nIDm-iSXvwKqEbXkgVtTMvXfmYAQGd54IOG19F8emfpCfJOOgYQDa8NNm42lIf6-94T5Myzxs35vdCcytvbgAj2WDEtgDHOnAKUZKcHojXuHzDAhoDcScKQ0a7GkB0Qy2zHmyxC22bXmjfwb1rfxg0Eg1pGZ3XIRvivxldc-rrKGNA3YB70Ms5GSxH0TJgZV39WagZq-u0RHeu0LxC_I6EIuC5A but not in https://00e9e64bac0bd2982ac8a451d8921275e99a6d25d6d6cabeb0-apidata.googleusercontent.com/download/storage/v1/b/chrome-telemetry-output/o/trace-file-id_5-2016-10-22_21-52-40-75851.html?qk=AD5uMEuedTx4EjuYZYZJd5Gob7wVRjjJLc6xV3VwukK2f52zDzWAgNBSU8qcvcHOpoErnSbSrp7qnTfiUldlASj8w5kCluwMFfL8U47j9O19S5BNxX_bwrkUoKNHkL8Cz_LVRWzLY9COONPksl6R39On0HQKJ6TcCp6moSq3OdYSDXcDzZOnlPTMojqbcx8fvi9DK2As89eFNX3MwD5-6ITr2yvZLvrxBYT2yCsZo8zffYbEaKLuSI-iWqtdJOLE9HVTAD8T2xSyNr2IpP0-jh39cTPmJlzUR0jJcjkMz74kBkSgttKstMxgmn3Uf3Mi9HtpAXIWq4bSxdG7zve-BK9wLtw5IqwZWTh3KMccI7Gms_RZG-D9MPw1bSWXqNhn-3iCTZ0AnrcZEJePKUtTSMmGM0Oeo7Txp-naAOuoGLmVcd4QFo6M2Shs1YKxUjY8N3HBx1yUouDP9cjthDz6GUlIpFVgLMh9a_pVFTIXM2kd7j6uYATQYP1T7nWffBZLrW9vYtRDF2dS-oSbLL4HpxQTaymJVHgRAbACJq-OLDPR2PXbJDJjnXdtveXoD0qaJUP5d0k81HU9Zt4WJHftGV1ZJEUUNi5494Q2ZcC_8ZXcEEwvtqSjRZ77cmKguTfGUJ5mcS9Xt1XapjrvDFspDYCB3S-txceuc7LAw0WE-gXge5su52RiO2SQTvjT8W4UZ46YuxjIuBL7HMW_2yIMlG7pd9GJ6y_fPGsS2JB4RlrzeMdWdyqjnqGt_kf1SfUXryRei4DLy7eJN93H3SAKRKkrKrfqBI9oQxk1urDFtoibNetLrghsstw6Fcy1_oRgOdawbTBqftWrC_J81dJ9rjfxiQC99_huvg

Sign in to add a comment