New issue
Advanced search Search tips

Issue 659036 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

authpolicy: Autogenerate cloud policy proto

Project Member Reported by ljusten@chromium.org, Oct 25 2016

Issue description

The current version of cloud_policy.proto in authpolicy is hard-coded. Autogenerate it from policy_templates.json similar to how Chromium does it.
 
 
Components: Enterprise

Comment 2 Deleted

Labels: M-57
Labels: Enterprise-Triaged
Status: Started (was: Assigned)

Comment 6 by tnagel@chromium.org, Nov 21 2016

Labels: Vnone CodeHealth
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cd4159f948d5b8edf251fbef7daad09aea5f026d

commit cd4159f948d5b8edf251fbef7daad09aea5f026d
Author: Lutz Justen <ljusten@chromium.org>
Date: Tue Nov 15 13:22:25 2016

Pull source files for user policy generation

Grab policy_templates.json and generate_policy_source.py from a git
repo. Right now, the authpolicy project has a hard-coded version of
the user policy proto file (cloud_policy.proto). The py script will
be used to generate the proto from the json file just like it works
in Chromium.

Also stored a hard-coded version of chrome/VERSION that is required
for generating the protobuf. This version must be kept in sync with
with the policy git repos referenced in the ebuild.

BUG= chromium:659036 
TEST=Builds, works fine

CQ-DEPEND=CL:411820

Change-Id: I21b7cdea1bdffc8a646bf5d054a0b6bb81df5ad4
Reviewed-on: https://chromium-review.googlesource.com/411781
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>

[add] https://crrev.com/cd4159f948d5b8edf251fbef7daad09aea5f026d/chromeos-base/protofiles/protofiles-0.0.2.ebuild
[add] https://crrev.com/cd4159f948d5b8edf251fbef7daad09aea5f026d/chromeos-base/protofiles/protofiles-0.0.2-r1.ebuild
[modify] https://crrev.com/cd4159f948d5b8edf251fbef7daad09aea5f026d/chromeos-base/authpolicy/authpolicy-9999.ebuild
[delete] https://crrev.com/0a1311e016dd40bb689ed6c1f0a033282319ff15/chromeos-base/protofiles/protofiles-0.0.1-r26.ebuild
[add] https://crrev.com/cd4159f948d5b8edf251fbef7daad09aea5f026d/chromeos-base/protofiles/files/VERSION

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3ec2d2df6cff05a49de3e351e6b76b5660de24be

commit 3ec2d2df6cff05a49de3e351e6b76b5660de24be
Author: Lutz Justen <ljusten@chromium.org>
Date: Tue Nov 15 13:42:56 2016

Generate and use user policy proto

Removes the checked-in hard-coded version of cloud_policy.proto used
by the authpolicy project and autogenerates it, just like it is done
in Chromium.

BUG= chromium:659036 
TEST=Authpolicy emerges and packages build fine

CQ-DEPEND=CL:411781

Change-Id: I754ea9be2d696536099212be6f62d2b45f4d641b
Reviewed-on: https://chromium-review.googlesource.com/411820
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/3ec2d2df6cff05a49de3e351e6b76b5660de24be/authpolicy/authpolicy.gyp
[modify] https://crrev.com/3ec2d2df6cff05a49de3e351e6b76b5660de24be/authpolicy/policy/user_policy_encoder_gen.cc
[modify] https://crrev.com/3ec2d2df6cff05a49de3e351e6b76b5660de24be/authpolicy/policy/user_policy_encoder.cc
[modify] https://crrev.com/3ec2d2df6cff05a49de3e351e6b76b5660de24be/authpolicy/authpolicy.cc
[modify] https://crrev.com/3ec2d2df6cff05a49de3e351e6b76b5660de24be/common-mk/external_dependencies.gyp
[delete] https://crrev.com/f0954864be59c4957d2b733c584aa0063d137972/authpolicy/policy/proto/cloud_policy.proto

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment