New issue
Advanced search Search tips

Issue 659020 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

authpolicy: Autogenerate policy_constants

Project Member Reported by ljusten@chromium.org, Oct 25 2016

Issue description

The current version of policy_constants in authpolicy is hard-coded. Aut-generate them from policy_templates.json similar to how Chromium does it.
 
Components: Enterprise
Labels: M-57
Labels: Enterprise-Triaged

Comment 4 by tnagel@chromium.org, Nov 21 2016

Labels: Vnone CodeHealth
Labels: -M-57 M-58
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc39ee6eb556261f1bcff11bf658eacea0ee4572

commit dc39ee6eb556261f1bcff11bf658eacea0ee4572
Author: ljusten <ljusten@chromium.org>
Date: Tue Mar 28 10:39:21 2017

Generate code for encoding cloud policy protobufs

Modifies the script that generates code from policy_templates.json to
output policy code that make it easy to iterate over all user policies
to encode data in a cloud policy protobuf.

The code is not used in Chromium. It will be used in Chrome OS's
authpolicy project. Right now, authpolicy uses similar, checked in
code, see policy_keys and in user_policy_encoder_gen.cc
platform2/authpolicy/policy.

This CL is implemented in Chromium, as opposed to a script in Chrome
OS, to facilitate maintainance. A script in Chrome OS would have many
dependencies on the Chromium script and it would be messy to maintain.
Changing the script in Chromium cannot break Chrome OS because it is
guarded by an uprev step in the protofiles project.

BUG= chromium:659020 ,  chromium:659078 
TEST=Compiled Chromium, tested autogenerated code in Chrome OS

Review-Url: https://codereview.chromium.org/2726103004
Cr-Commit-Position: refs/heads/master@{#460056}

[modify] https://crrev.com/dc39ee6eb556261f1bcff11bf658eacea0ee4572/components/policy/tools/generate_policy_source.py

Status: Started (was: Assigned)
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment