New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659015 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Regression] DevTools:Blackbox Patterns Page Missing In Devtools Settings

Reported by vrunj...@gmail.com, Oct 25 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2900.0 Safari/537.36

Steps to reproduce the problem:
1. Open devtools
2. Go to devtools settings
3. Blackboxing options is missing from the settings options

What is the expected behavior?
The settings should have an option for blackboxing, where we can set blackbox patterns

What went wrong?
The blackbox patterns settings page doesn't exist in the settings options

Did this work before? N/A 

Chrome version: 56.0.2900.0  Channel: canary
OS Version: OS X 10.11.6
Flash Version:
 

Comment 1 by woxxom@gmail.com, Oct 25 2016

History of changes:

1. https://crrev.com/444923002 Blackboxing out of experiments
2. https://crrev.com/2204903003 Inadvertently moves blackboxing settings back into experiments enabled only via chrome://flags
Cc: kozyatinskiy@chromium.org
Labels: -Type-Bug -OS-Mac OS-All Type-Bug-Regression
Owner: pfeldman@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: [Regression] DevTools:Blackbox Patterns Page Missing In Devtools Settings (was: Blackbox Patterns Page Missing In Devtools Settings)
Cc: -kozyatinskiy@chromium.org dgozman@chromium.org
Owner: kozyatinskiy@chromium.org
Cc: paulir...@chromium.org
Labels: -Pri-2 Pri-1
Increased priority since this is a regression.
It s only a matter of removing this line, I believe -
https://chromium.googlesource.com/chromium/src/+/fab3447f6dc8633b0468fc7f40031e122d339629/third_party/WebKit/Source/devtools/front_end/settings/module.json#83
Status: Started (was: Assigned)
Nice catch, thank you.
https://codereview.chromium.org/2470803002/
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee4adb422759028efe143c435d5bd58a9c01a48b

commit ee4adb422759028efe143c435d5bd58a9c01a48b
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Nov 01 21:14:46 2016

[DevTools] Show blackbox tab in settings always

BUG= chromium:659015 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2470803002
Cr-Commit-Position: refs/heads/master@{#429112}

[modify] https://crrev.com/ee4adb422759028efe143c435d5bd58a9c01a48b/third_party/WebKit/Source/devtools/front_end/settings/module.json

Labels: Merge-Request-55
Status: Fixed (was: Started)

Comment 8 by phistuck@gmail.com, Nov 2 2016

Can you add tests for this kind of things?
I bet most of the Developer Tools team enable the experiments, which is probably why it slipped through for so long...

Comment 9 by phistuck@gmail.com, Nov 2 2016

Also, please merge this to any channel you can...

Comment 10 by dimu@chromium.org, Nov 2 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 2 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa35eda35efe9b463e30923ba79381ad25b8c9b4

commit fa35eda35efe9b463e30923ba79381ad25b8c9b4
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Nov 02 21:14:19 2016

[DevTools] Show blackbox tab in settings always

BUG= chromium:659015 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2470803002
Cr-Commit-Position: refs/heads/master@{#429112}
(cherry picked from commit ee4adb422759028efe143c435d5bd58a9c01a48b)

Review URL: https://codereview.chromium.org/2469363003 .

Cr-Commit-Position: refs/branch-heads/2883@{#427}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/fa35eda35efe9b463e30923ba79381ad25b8c9b4/third_party/WebKit/Source/devtools/front_end/settings/module.json

Cc: hdodda@chromium.org
Labels: TE-Verified-55.0.2883.44 TE-Verified-M55
Verified this issue on Mac OS 10.11.6 ,Ubuntu 14.04 and Windows-10 using chrome latest Beta M55-55.0.2883.44 by following steps mentioned in the original comment.

Dev tools settings have an option for blackboxing, where we can set blackbox patterns.

Hence adding TE-Verified label.
659015.png
202 KB View Download
Cc: kozyatinskiy@chromium.org
 Issue 668470  has been merged into this issue.
 Issue 673650  has been merged into this issue.

Sign in to add a comment