New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659003 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : ‘More Settings’ button doesn’t work after changing the printing ‘Destination’ to 'Fax' or 'MS XPS document writer'.

Reported by yfulgaon...@etouch.net, Oct 25 2016

Issue description

Chrome Version : 56.0.2900.0 (Official Build) 1e4fbec3b5701d9f605e88f14dafa442be98b648-refs/heads/master@{#427219} 64-bit
OS : Mac(10.10.5, 10.11.4, 10.11.5), Linux(14.04 LTS)

Precondition : Sign in to Gmail using an account that has Synced ‘google cloud’ printers.

What steps will reproduce the problem?
1. Launch chrome and open NTP and hit ‘Cmd + P’.
2. Click on ‘Destination’ button and select any printer having ‘Copies’ option (In this case ‘HP Universal Printing’ is selected)
3. Now again click on ‘Destination’ button and change it to ‘Fax’.
4. Click on ‘More Settings’ button and observe.

Actual : ‘More Settings’ button doesn’t work after changing the printing ‘Destination’.
Expected : ‘More Settings’ button should work after changing the printing ‘Destination’.

This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update bisect info.
Good build : 56.0.2895.0
Bad build : 56.0.2896.0

Note : Issue is seen on Mac & Linux OS but the same is working fine on Windows OS.
 
Actual_Print_Result.mov
7.5 MB Download
Expected_Print_Result.mov
7.7 MB Download
Components: UI>Browser>History
Components: -UI>Browser>History
Whoops, wrong bug.
I'm not seeing this on Linux. I also don't have the "Fax" cloud printer, which may or may not be needed to reproduce the bug.

It will be helpful to have a narrower bisect.
@ thestig : Issue is reproducible on Linux (14.04 LTS).

And if you don't have "Fax' cloud printer, then in step 3 select 'Microsoft XPS document writer' instead of 'Fax' as a destination and follow step 4. Issue is reproducible after changing the destination to 'Microsoft XPS document writer' as well. Kindly review an screen cast. Thank you!
Actual.mov
7.8 MB Download
Cc: thestig@chromium.org
Cc: -thestig@chromium.org skau@chromium.org
Labels: hasbisect
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression : ‘More Settings’ button doesn’t work after changing the printing ‘Destination’ to 'Fax' or 'MS XPS document writer'. (was: Regression : ‘More Settings’ button doesn’t work after changing the printing ‘Destination’ to 'Fax'.)
Narrow Bisect info :
https://chromium.googlesource.com/chromium/src/+log/987cf79c0d88104a3d491760b1b3b3294bb1d80a..f004634d8e9b7b9dafa72faf1d0239e9c7d4d8e9?pretty=fuller&n=10000

Suspecting : r 426311 or 426317 ? from Narrow Bisect

@thestig : Please help to re-assign if your change is not the cause for this issue.
Labels: ReleaseBlock-Beta
Adding RB label as this is a recent regression.
I still cannot reproduce this. It may be helpful to share the cloud printer from the test account if possible:

1) Go to https://www.google.com/cloudprint/#printers
2) Select the "Fax" printer
3) Press the "Share" button
4) Fill out the form
@ thestig : I've shared both i.e "Fax" and "Microsoft XPS document writer" printers with your chromium account(thestig@chromium.org). Please try to reproduce using these shared printers. Thank you!
Status: Started (was: Assigned)
Thank you, that was very helpful. I can reproduce the problem now and I'll have a fix soon. https://codereview.chromium.org/2450163002
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dc2dbbd01010135633d1d0cfafda11a12aabf73

commit 6dc2dbbd01010135633d1d0cfafda11a12aabf73
Author: thestig <thestig@chromium.org>
Date: Wed Oct 26 23:20:16 2016

Print Preview: Handle printer media without name fields.

BUG= 659003 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2450163002
Cr-Commit-Position: refs/heads/master@{#427871}

[modify] https://crrev.com/6dc2dbbd01010135633d1d0cfafda11a12aabf73/chrome/browser/resources/print_preview/data/destination_store.js

Status: Fixed (was: Started)
Above issue is not reproducible in latest Mac Canary 56.0.2902.0 build and it is working as intended. Kindly review an attached screen cast.
Thank you!
Canary_behaviour.mov
8.1 MB Download
Labels: TE-Verified-M56 TE-Verified-56.0.2902.0
As per Comment# 13, adding TE-Verified Labels.
Thank You.

Sign in to add a comment