New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 678905
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 595993

Blocking:
issue 678905
issue 602693



Sign in to add a comment
link

Issue 658997: Some tests in external/wpt/service-workers time out with Release build

Reported by shimazu@chromium.org, Oct 25 2016 Project Member

Issue description

Currently the following tests are failing by timeout.
This happens only with release build, and doesnt with debug build.

# Mark as P1 due to blocking    Issue 602693    which is P1.

Link: https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Linux%20-%20WPTServe/builds/6013

Tests (updated May 2017):
 crbug.com/658997  external/wpt/service-workers/service-worker/client-navigate.https.html [ Skip ]
 crbug.com/658997  external/wpt/service-workers/service-worker/clients-get-cross-origin.https.html [ Skip ]
 crbug.com/658997  external/wpt/service-workers/service-worker/clients-matchall-client-types.https.html [ Skip ]
 crbug.com/658997  external/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ Skip ]
 crbug.com/658997  external/wpt/service-workers/service-worker/fetch-request-xhr.https.html [ Failure Timeout ]
 crbug.com/658997  external/wpt/service-workers/service-worker/invalid-blobtype.https.html [ Skip ]
 crbug.com/658997  external/wpt/service-workers/service-worker/invalid-header.https.html [ Skip ]
 

Comment 1 by bugdroid1@chromium.org, Oct 26 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74e0e4302ff524635ecbef0e45cecbda268e8552

commit 74e0e4302ff524635ecbef0e45cecbda268e8552
Author: shimazu <shimazu@chromium.org>
Date: Wed Oct 26 05:43:02 2016

Mark several w3c tests for service workers [ Slow ]

Several web platform tests introduced at https://crrev.com/2441963002 are passed
with longer timeout. This patch is to keep the bots green.

BUG= 602693 , 658997 

Review-Url: https://codereview.chromium.org/2443073002
Cr-Commit-Position: refs/heads/master@{#427600}

[modify] https://crrev.com/74e0e4302ff524635ecbef0e45cecbda268e8552/third_party/WebKit/LayoutTests/SlowTests

Comment 2 by falken@chromium.org, Nov 4 2016

Labels: -Pri-1 Pri-2
Summary: 16 web-platform-tests in imported/wpt/service-workers timeouts with Release build (was: 16 web-platform-tests in improted/wpt/service-workers timeouts with Release build)

Comment 3 by tkent@chromium.org, Nov 15 2016

imported/wpt/service-workers consumes 30% of imported/wpt because of these timeout.

http://test-results.appspot.com/dashboards/treemap.html#treemapfocus=AllTests%2Fimported%2Fwpt&builder=chromium.webkit%3AWebKit%20Linux%20Precise

If we don't fix this anytime soon, please skip them.

Comment 4 by nhiroki@chromium.org, Nov 15 2016

Cc: shimazu@chromium.org
Owner: horo@chromium.org
horo@, can you update the TestExpectations?

Comment 5 by nhiroki@chromium.org, Nov 16 2016

Cc: horo@chromium.org
Owner: nhiroki@chromium.org
Status: Started (was: Assigned)
horo@ is now super busy. I'll work on it.

Comment 6 by nhiroki@chromium.org, Nov 16 2016

It looks like that these timeouts started after https://codereview.chromium.org/2500053002 that disabled testharness.js timeout. Anyway, I'll mark them as SKIP.

Comment 8 by bugdroid1@chromium.org, Nov 16 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14b49db68dab332e121ca8ef6fb0e78e153c26ef

commit 14b49db68dab332e121ca8ef6fb0e78e153c26ef
Author: nhiroki <nhiroki@chromium.org>
Date: Wed Nov 16 08:06:54 2016

ServiceWorker: Mark imported/wpt/service-workers/service-worker/ with [ Skip ]

These tests constantly time out and are time-consuming.

BUG= 658997 
TBR=nhiroki@chromium.org

Review-Url: https://codereview.chromium.org/2507663002
Cr-Commit-Position: refs/heads/master@{#432420}

[modify] https://crrev.com/14b49db68dab332e121ca8ef6fb0e78e153c26ef/third_party/WebKit/LayoutTests/TestExpectations

Comment 9 by nhiroki@chromium.org, Nov 16 2016

Cc: -shimazu@chromium.org nhiroki@chromium.org
Owner: shimazu@chromium.org
Status: Assigned (was: Started)
Updated the expectations. Let me return ownership to shimazu@.

Comment 10 by shimazu@chromium.org, Nov 16 2016

Thank you for updating that:)
I'll investigate next week why these tests failed after https://crrev.com/2500053002 has landed.

Comment 11 by mek@chromium.org, Nov 16 2016

The tests were already failing before that CL landed. Just before they were failing because the internal testharness.js timeout timed out, and now they're failing because the test runner timeout times out. Either way these tests are timing out.

Comment 12 by falken@chromium.org, Nov 16 2016

Right, the tests were "passing" but with TIMEOUT in the -expected.html files. Now the timeout mechanism has moved to the test runner.

Comment 13 by shimazu@chromium.org, Dec 6 2016

I quickly looked at client-navigate.https.html and found two problems.

One is a wrong return value of is_service_worker() in testharness.js:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources/testharness.js?q=RemoteWorker&sq=package:chromium&dr=CSs&l=1588

fetch_tests_from_worker(frame.contentWindow.navigator.serviceWorker.controller) is executed in client-navigate.https.html, and the controller will be passed to the RemoteWorker.
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/client-navigate.https.html?q=client-navigate.https.html&sq=package:chromium&dr&l=46

is_service_worker(worker) returns false on chrome though |worker| in the ctor of RemoteWorker seems an instance of ServiceWorker.
I also tried that on firefox and the function returns true.

The other is that a promise returned by client.navigate() wouldn't be resolved:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigate-worker.js?type=cs&q=%22Navigating+to+different+origin+should+reject%22&sq=package:chromium&l=46

Comment 14 by shimazu@chromium.org, Jan 16 2017

Mergedinto: 678905
Status: Duplicate (was: Assigned)

Comment 15 by falken@chromium.org, Feb 10 2017

Blocking: 678905
Cc: shimazu@chromium.org
Owner: ----
Status: Available (was: Duplicate)

Comment 16 by bke...@mozilla.com, Mar 30 2017

I think this one is a bug in the test:

https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigate-worker.js?type=cs&q=%22Navigating+to+different+origin+should+reject%22&sq=package:chromium&l=46

I'm re-writing the firefox client.navigate() code and I don't see any spec text requiring rejecting a cross-origin URL.  Instead it should resolve null like you check in the chrome test:

https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html?l=51

I'll get firefox and this part of the test fixed and uplifted from the gecko side.

Comment 17 by bugdroid1@chromium.org, Apr 24 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5cd9b369845c99709d101b09c350170b34fd51f

commit b5cd9b369845c99709d101b09c350170b34fd51f
Author: mike <mike@mikepennisi.com>
Date: Mon Apr 24 18:39:05 2017

Upstream service worker `fetch` tests to WPT

The Web Platform Tests project includes equivalent versions of the
following tests:

- third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-canvas-tainting.html
- third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-cors-xhr.html

Remove the above Chromium-specific files to promote the use of the more
widely shared versions.

The following test file is more thorough than the equivalent version in
WPT. It contains the same assertions as those found in the WPT version,
but it also includes versions with an alternative value of the `img-src`
CSP directive.

- third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-csp.html

Extend the WPT version with the new assertions and remove the
Chromium-specific file. Also remove infrastructure configuration which
previously prevented the WPT version from being executed.

BUG= 688116 ,  658997 
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2805313003
Cr-Commit-Position: refs/heads/master@{#466697}

[modify] https://crrev.com/b5cd9b369845c99709d101b09c350170b34fd51f/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/b5cd9b369845c99709d101b09c350170b34fd51f/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt
[add] https://crrev.com/b5cd9b369845c99709d101b09c350170b34fd51f/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-cors-xhr.https-expected.txt
[modify] https://crrev.com/b5cd9b369845c99709d101b09c350170b34fd51f/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-csp.https.html
[modify] https://crrev.com/b5cd9b369845c99709d101b09c350170b34fd51f/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-csp-iframe.html
[rename] https://crrev.com/b5cd9b369845c99709d101b09c350170b34fd51f/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-canvas-tainting.html
[rename] https://crrev.com/b5cd9b369845c99709d101b09c350170b34fd51f/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-cors-xhr.html
[rename] https://crrev.com/b5cd9b369845c99709d101b09c350170b34fd51f/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-csp-expected.txt
[rename] https://crrev.com/b5cd9b369845c99709d101b09c350170b34fd51f/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-csp.html

Comment 18 by bugdroid1@chromium.org, May 1 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b

commit 07b83d70ca740271a8acaa3c3e9b32eb01d5c48b
Author: mike <mike@mikepennisi.com>
Date: Mon May 01 17:25:21 2017

Upstream service worker `fetch` tests to WPT

Reconcile the remaining Service Worker tests that concern the Fetch
standard. As noted below, some tests must be persisted in the Chromium
project due to unresolved timeout issues in the build environment (see
 https://crbug.com/658997 ).

**fetch-event-async-respond-with**

The Chromium-specific version of this test is almost identical to the
version provided by the Web Platform Test suite, though it suffers from
timeout issues in the build environment.

Rename the Chromium-specific version to document its deprecated status
and improve the upstream version to defer frame removal and omit
unnecessary resource.

**fetch-event-network-error**

The upstream version of this test is almost identical to the
Chromium-specific version.

The Chromium-specific version of this test is almost identical to the
version available upstream. The upstream version is preferable because
it contains an additional assertion not found in the Chromium version.

Remove the Chromium-specific version of this test, and update the
upstream version to omit an unnecessary resource.

**fetch-event-respond-with-argument**

Re-locate Chromium-specific test to the Web Platform Test suite
directory so that it may be included in that project.

**fetch-event-respond-with-stops-propagation**

The Chromium-specific version of this test is almost identical to the
version provided by the Web Platform Test suite, though it suffers from
timeout issues in the build environment.

Rename the Chromium-specific version to reflect its deprecated status,
and improve the upstream version to defer frame removal and omit
unnecessary resource.

**fetch-event**

Remove sub-tests from the Chromium-specific version that are present in
the upstream version. Rename the test file to reflect the
implementation-specific nature of the test.

Extend the upstream version with a relaxed version of Chromium's
sub-test for request headers.

In both versions, formalize tear down logic to ensure consistent frame
removal and subsequent client de-registration.

BUG= 688116 ,  658997 
R=mek@chromium.org

Review-Url: https://codereview.chromium.org/2836233002
Cr-Commit-Position: refs/heads/master@{#468341}

[modify] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-async-respond-with.https.html
[modify] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-network-error.https.html
[rename] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-argument.https.html
[modify] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html
[modify] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt
[modify] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https.html
[rename] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-event-respond-with-argument-iframe.html
[rename] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-event-respond-with-argument-worker.js
[modify] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-event-test-worker.js
[rename] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-event-async-respond-with.html
[add] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-event-headers.html
[rename] https://crrev.com/07b83d70ca740271a8acaa3c3e9b32eb01d5c48b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-event-respond-with-stops-propagation.html
[delete] https://crrev.com/76aca77545743215506fc9e9eb0c1299e89553ae/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event-network-error.html
[delete] https://crrev.com/76aca77545743215506fc9e9eb0c1299e89553ae/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html
[delete] https://crrev.com/76aca77545743215506fc9e9eb0c1299e89553ae/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-event-network-error-controllee-iframe.html
[delete] https://crrev.com/76aca77545743215506fc9e9eb0c1299e89553ae/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-event-network-error-worker.js

Comment 19 by bugdroid1@chromium.org, May 3 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d4ce2a062601d712fcc1dc52f4e106fe4618579

commit 4d4ce2a062601d712fcc1dc52f4e106fe4618579
Author: mike <mike@mikepennisi.com>
Date: Wed May 03 19:26:39 2017

Upstream service worker registration tests to WPT

The test for `getRegistration` in Chromium is identical to the
corresponding test in the Web Platform Tests project and may therefore
be removed.

The test for `getRegistrations` is likewise highly similar.
Schedule iframe removal to consistently occur following
sub-test completion (regardless of test results).

BUG= 688116 ,  658997 
R=mek@chromium.org

Review-Url: https://codereview.chromium.org/2853383004
Cr-Commit-Position: refs/heads/master@{#469071}

[modify] https://crrev.com/4d4ce2a062601d712fcc1dc52f4e106fe4618579/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4d4ce2a062601d712fcc1dc52f4e106fe4618579/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/getregistrations.https.html
[rename] https://crrev.com/4d4ce2a062601d712fcc1dc52f4e106fe4618579/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.getregistrations.html
[delete] https://crrev.com/9a3f5f993acb59b16a6e1d5f157a46f6c7a11df8/third_party/WebKit/LayoutTests/http/tests/serviceworker/getregistration.html

Comment 20 by bugdroid1@chromium.org, May 9 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a3e413c07f490356a2a9b5cf623954ed9d35827

commit 6a3e413c07f490356a2a9b5cf623954ed9d35827
Author: mike <mike@mikepennisi.com>
Date: Tue May 09 18:51:55 2017

Upstream service worker `fetch` tests to WPT

**fetch-request-css-base-url**

The Chromium-specific version of this test is almost identical to the
version provided by the Web Platform Test suite. The upstream version
differs only in its use of Promises for control flow. However, the
upstream version also suffers from timeout issues in the build
environment.

Rename the Chromium-specific version to reflect its deprecated status,
and re-enable the upstream version as an expected timeout.

**fetch-request-xhr**

Update the upstream version to improve failure reporting and to include
novel tests from the Chromium version for HTTP header values (modified
to comply with the Fetch specification).

Update the Chromium-specific version to document its deprecated status
and invalid assertions.

Update both versions to improve state management via `Test#add_cleanup`.

**fetch-response-xhr**

Update the upstream version to avoid a race condition.

Update the Chromium-specific version to document its deprecated status.

Update both versions to improve state management via `Test#add_cleanup`.

BUG= 688116 , 595993,  658997 
R=mek@chromium.org

Review-Url: https://codereview.chromium.org/2862353002
Cr-Commit-Position: refs/heads/master@{#470395}

[modify] https://crrev.com/6a3e413c07f490356a2a9b5cf623954ed9d35827/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/6a3e413c07f490356a2a9b5cf623954ed9d35827/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6a3e413c07f490356a2a9b5cf623954ed9d35827/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html
[modify] https://crrev.com/6a3e413c07f490356a2a9b5cf623954ed9d35827/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-response-xhr.https.html
[modify] https://crrev.com/6a3e413c07f490356a2a9b5cf623954ed9d35827/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-xhr-iframe.https.html
[modify] https://crrev.com/6a3e413c07f490356a2a9b5cf623954ed9d35827/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-response-xhr-iframe.https.html
[rename] https://crrev.com/6a3e413c07f490356a2a9b5cf623954ed9d35827/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-css-base-url.html
[rename] https://crrev.com/6a3e413c07f490356a2a9b5cf623954ed9d35827/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-xhr.html
[rename] https://crrev.com/6a3e413c07f490356a2a9b5cf623954ed9d35827/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-response-xhr.html
[modify] https://crrev.com/6a3e413c07f490356a2a9b5cf623954ed9d35827/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html

Comment 21 by bugdroid1@chromium.org, May 16 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb6d3be1ab6a20735406528fecb19ec718ae110

commit 2fb6d3be1ab6a20735406528fecb19ec718ae110
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 16 02:09:01 2017

Remove flaky expectations for tests that no longer appear flaky.

Again, done with update-test-expectations.

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual/gpu/fast/canvas/painting-on-bad-canvas.html,fast/events/message-port-start-and-close-different-microtask.html,virtual/mojo-loading/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html,virtual/threaded/animations/display-inline-style-adjust.html,fast/selectors/007a.html,http/tests/workers/terminate-during-sync-operation-file.html,virtual/mojo-loading/http/tests/workers/terminate-during-sync-operation-file.html,virtual/threaded/inspector/tracing/decode-resize.html,external/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html,external/wpt/service-workers/service-worker/fetch-cors-xhr.https.html,external/wpt/service-workers/service-worker/fetch-csp.https.html,external/wpt/service-workers/service-worker/fetch-event-async-respond-with.https.html,external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html,external/wpt/service-workers/service-worker/fetch-request-css-base-url.https.html,external/wpt/service-workers/service-worker/fetch-response-xhr.https.html,external/wpt/service-workers/service-worker/getregistrations.https.html,http/tests/security/link-crossorigin-preload-no-cors.html,virtual/mojo-loading/http/tests/inspector/tracing/timeline-script-parse.html,tables/mozilla/bugs/bug113424.html,fast/backgrounds/background-image-relative-url-in-iframe.html,crypto/subtle/worker-subtle-crypto-concurrent.html,fast/workers/termination-early.html,fast/dnd/dropEffect-for-effectAllowed.html

BUG= 404597 , 520174 , 520194 , 596752 , 619539 , 619539 , 638693 , 658997 ,664839, 678489 , 708934 , 713050 ,713419, 713509 , 713685 , 719298 

Review-Url: https://codereview.chromium.org/2884793002
Cr-Commit-Position: refs/heads/master@{#471981}

[modify] https://crrev.com/2fb6d3be1ab6a20735406528fecb19ec718ae110/third_party/WebKit/LayoutTests/TestExpectations

Comment 22 by bugdroid1@chromium.org, May 18 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74008fbe10dff1e03e4d5a9c941d6700705231df

commit 74008fbe10dff1e03e4d5a9c941d6700705231df
Author: mike <mike@mikepennisi.com>
Date: Thu May 18 19:35:35 2017

Upstream service worker "referer" tests to WPT

**referer**

This test exists in both WPT and the Chromium project tree. They differ
only in implementation details of the testing infrastructure.  However,
the upstream version suffers from timeout issues in the build
environment.

Rename the Chromium-specific version to reflect its deprecated status,
and re-enable the upstream version as an expected timeout.

**referrer-policy-header**

Move test file for automated contribution to the Web Platform Tests
project. Update URLs to use contextual values. Express asynchronous
sub-test using the `promise_test` function. Consistently remove iframe
regardless of sub-test result. Specify necessary HTTP headers in a
format that is supported by the Web Platform Tests project.

BUG= 688116 ,  658997 
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2883373002
Cr-Commit-Position: refs/heads/master@{#472902}

[modify] https://crrev.com/74008fbe10dff1e03e4d5a9c941d6700705231df/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/74008fbe10dff1e03e4d5a9c941d6700705231df/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html
[add] https://crrev.com/74008fbe10dff1e03e4d5a9c941d6700705231df/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-rewrite-worker-referrer-policy.js
[add] https://crrev.com/74008fbe10dff1e03e4d5a9c941d6700705231df/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-rewrite-worker-referrer-policy.js.headers
[rename] https://crrev.com/74008fbe10dff1e03e4d5a9c941d6700705231df/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/referrer-policy-iframe.html
[rename] https://crrev.com/74008fbe10dff1e03e4d5a9c941d6700705231df/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.referer.html
[delete] https://crrev.com/9258f1b1b8e234f289aaf7bd2031c208ecca58ce/third_party/WebKit/LayoutTests/http/tests/serviceworker/referrer-policy-header.html
[delete] https://crrev.com/9258f1b1b8e234f289aaf7bd2031c208ecca58ce/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-rewrite-worker.php

Comment 23 by qyears...@chromium.org, May 21 2017

Labels: Test-Layout
Summary: 16 tests in external/wpt/service-workers times out with Release build (was: 16 web-platform-tests in imported/wpt/service-workers timeouts with Release build)

Comment 24 by falken@chromium.org, May 22 2017

Description: Show this description

Comment 25 by falken@chromium.org, May 22 2017

Summary: Some tests in external/wpt/service-workers time out with Release build (was: 16 tests in external/wpt/service-workers times out with Release build)

Comment 27 by falken@chromium.org, May 23 2017

Description: Show this description

Comment 28 by leon....@intel.com, May 26 2017

Hi, can I take this issue and start investigation right now? Thanks.

Comment 29 by leon....@intel.com, May 26 2017

Cc: leon....@intel.com

Comment 30 by falken@chromium.org, May 26 2017

Cc: -leon....@intel.com
Owner: leon....@intel.com
Status: Assigned (was: Available)
That'd be great!

Comment 31 by bugdroid1@chromium.org, Jun 12 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c433e7dca949e4df3ce288475d2cc5a6d134787

commit 3c433e7dca949e4df3ce288475d2cc5a6d134787
Author: leon.han <leon.han@intel.com>
Date: Mon Jun 12 07:42:44 2017

[ServiceWorker] Fix bugs of wpt tests for Client.navigate

This CL
 - modifies is_service_worker() in external/wpt/resources/testharness.js
   so that frame.contentWindow.navigator.serviceWorker.controller CAN be
   identified correctly as ServiceWorker object within main frame's
   execution context, this ensures success of fetch_tests_from_worker,
   which is called by several tests in client-navigate.https.html.
 - throws TypeError if navigation failed for Client.navigate,
   E.g. mixed-content violation.

BUG= 658997 
TEST=blink_tests
external/wpt/service-workers/service-worker/client-navigate.https.html

Review-Url: https://codereview.chromium.org/2912593003
Cr-Commit-Position: refs/heads/master@{#478561}

[modify] https://crrev.com/3c433e7dca949e4df3ce288475d2cc5a6d134787/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/3c433e7dca949e4df3ce288475d2cc5a6d134787/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3c433e7dca949e4df3ce288475d2cc5a6d134787/third_party/WebKit/LayoutTests/external/wpt/resources/testharness.js
[modify] https://crrev.com/3c433e7dca949e4df3ce288475d2cc5a6d134787/third_party/WebKit/LayoutTests/fast/dom/custom/svg-use-shadow-tree-expected.txt
[modify] https://crrev.com/3c433e7dca949e4df3ce288475d2cc5a6d134787/third_party/WebKit/LayoutTests/http/tests/webaudio/autoplay-crossorigin-expected.txt
[modify] https://crrev.com/3c433e7dca949e4df3ce288475d2cc5a6d134787/third_party/WebKit/LayoutTests/resources/testharness.js

Comment 32 by bugdroid1@chromium.org, Jun 14 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f71c9d3211c9a05c8a3d9046717ed785352f592

commit 2f71c9d3211c9a05c8a3d9046717ed785352f592
Author: Han Leon <leon.han@intel.com>
Date: Wed Jun 14 07:05:01 2017

[ServiceWorker] Enable running wpt test clients-get-cross-origin-frame.html

This CL removes the mark [Skip] for clients-get-cross-origin-frame.html
because it can PASS now.

BUG= 658997 
TEST=blink_tests
external/wpt/service-workers/service-worker/clients-get-cross-origin.https.html

Change-Id: I96738e226ef5dc4cfb5b7b68f18e5e4df1c68d79
Reviewed-on: https://chromium-review.googlesource.com/532854
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#479312}
[modify] https://crrev.com/2f71c9d3211c9a05c8a3d9046717ed785352f592/third_party/WebKit/LayoutTests/TestExpectations

Comment 33 by leon....@intel.com, Jun 16 2017

Blockedon: 595993
external/wpt/service-workers/service-worker/fetch-request-xhr.https.html fails because of crbug.com/595993:
Chrome is not conforming to the spec https://fetch.spec.whatwg.org/#fetching in that it generates the following headers before SW:
  - User-Agent
  - Origin

Comment 34 by bugdroid1@chromium.org, Jun 16 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1c3139b00cd1457c8481eeb29b6f7a9df21150a

commit a1c3139b00cd1457c8481eeb29b6f7a9df21150a
Author: Han Leon <leon.han@intel.com>
Date: Fri Jun 16 09:28:57 2017

[ServiceWorker] Add -expected.txt file for fetch-request-xhr.https.html

Currently fetch-request-xhr.https.html is marked as [ Failure Timeout ],
but actually it always fails because of crbug.com/595993:
Chrome is not conforming to the spec
https://fetch.spec.whatwg.org/#fetching in that it generates the
following headers before SW:
  - User-Agent
  - Origin

This CL removes fetch-request-xhr.https.html from TestExpectations file
and adds corresponding -expected.txt for it.

BUG= 658997 
TEST=blink_tests
external/wpt/service-workers/service-worker/fetch-request-xhr.https.html

Change-Id: I53cc377a8db6cf8c06a6bca2d54c8d0359b2bbd7
Reviewed-on: https://chromium-review.googlesource.com/538080
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#480002}
[modify] https://crrev.com/a1c3139b00cd1457c8481eeb29b6f7a9df21150a/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/a1c3139b00cd1457c8481eeb29b6f7a9df21150a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr.https-expected.txt

Comment 35 by bugdroid1@chromium.org, Jun 19 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/440bc566577b9f185d1cd965c7feec211d7ed8f3

commit 440bc566577b9f185d1cd965c7feec211d7ed8f3
Author: Han Leon <leon.han@intel.com>
Date: Mon Jun 19 05:31:24 2017

[ServiceWorker] Remove [Skip] mark for two wpt tests

This CL removes [Skip] mark for invalid-blobtype.https.html and
invalid-header.https.html, as they can PASS now.

BUG= 658997 
TEST=blink_tests
external/wpt/service-workers/service-worker/invalid-blobtype.https.html
external/wpt/service-workers/service-worker/invalid-header.https.html

Change-Id: I47bed378ff7cd1725d46cf23661846355f4e6cc9
Reviewed-on: https://chromium-review.googlesource.com/538065
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480355}
[modify] https://crrev.com/440bc566577b9f185d1cd965c7feec211d7ed8f3/third_party/WebKit/LayoutTests/TestExpectations

Comment 36 by falken@chromium.org, Aug 3 2017

clients-matchall-client-types.https.html is the final test linking to this bug, and it no longer times out. Created issue 751959 and will close this bug once https://chromium-review.googlesource.com/c/598661 lands.

Comment 37 by bugdroid1@chromium.org, Aug 3 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd2689c47c20ab508deb36033eab4e56b4d1d979

commit cd2689c47c20ab508deb36033eab4e56b4d1d979
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Aug 03 08:16:37 2017

Gardening: Unskip service-worker/clients-matchall-client-types.https.html

This test doesn't timeout anymore. It fails reliably. Add an expected file for
it.

As this was the final test linking to  bug 658997 , we can finally close the
bug.

TBR=shimazu

Bug:  658997 , 751959
Change-Id: I8acb6812a9c9c7824aa14d606a63ffbf7478f23e
Reviewed-on: https://chromium-review.googlesource.com/598661
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491675}
[modify] https://crrev.com/cd2689c47c20ab508deb36033eab4e56b4d1d979/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/cd2689c47c20ab508deb36033eab4e56b4d1d979/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt

Comment 38 by falken@chromium.org, Aug 3 2017

Status: Fixed (was: Assigned)

Comment 39 by bugdroid1@chromium.org, Oct 25 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afa391fc883779ee49c9c92474fb1724b972fd32

commit afa391fc883779ee49c9c92474fb1724b972fd32
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Oct 25 04:52:29 2017

service worker: Remove some unnecessary "chromium." tests.

These tests are duplicates of WPT tests. They were originally needed to
preserve test coverage because the WPT tests were timing out. However the time
outs no longer occur, so we can remove the dupes.

Bug:  658997 
Change-Id: Ib3c76cd32274b5c4fc7838cdec943033420946b4
Reviewed-on: https://chromium-review.googlesource.com/737291
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511373}
[modify] https://crrev.com/afa391fc883779ee49c9c92474fb1724b972fd32/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-event-async-respond-with.html
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-event-respond-with-stops-propagation.html
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-css-base-url.html
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-xhr.html
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-response-xhr.html
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.getregistrations.html
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.referer.html
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-event-async-respond-with-worker.js
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-stops-propagation-worker.js
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-css-base-url-worker.js
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-worker.js
[delete] https://crrev.com/8048987c7f5fa6f31d66930b7b879c2d33cc1a60/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-response-xhr-worker.js

Comment 40 by bugdroid1@chromium.org, Mar 29 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/536a7046e9fbbe6dd1b3acf8a0a6064c15b4bcc7

commit 536a7046e9fbbe6dd1b3acf8a0a6064c15b4bcc7
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Thu Mar 29 08:03:37 2018

Remove create_file_system_file()

This function isn't used.

Bug:  658997 , 402387 
Change-Id: I01d751dfebaafd1580beaeb12ebcd124df132b26
Reviewed-on: https://chromium-review.googlesource.com/984919
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546765}
[modify] https://crrev.com/536a7046e9fbbe6dd1b3acf8a0a6064c15b4bcc7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-xhr-iframe.https.html

Sign in to add a comment