New issue
Advanced search Search tips

Issue 658993 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Detect outdated system Keystone

Project Member Reported by borisv@chromium.org, Oct 25 2016

Issue description

Chrome Version       : 54.0.2840.71
OS version               : 10.11

What steps will reproduce the problem?
(1) Start Chrome with a broken, old system install of Keystone
(2) Launch Chrome (bundled with newer version of Keystone)

What is the expected result?
A warning to the user that Chrome may not be able to update itself and a button to fix it. This already happens if a system ticket is found without Keystone. It should also happen if an outdated Keystone is present.


What happens instead?
No warning displayed.

I just worked with a couple of users in that state. Possibly an older version of Keystone - 1.2.2.428 had lower success rate of system installs and ended up with non-functional installation.
 
Components: Internals>Installer
Owner: borisv@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8064914cafec9166c25773ec203542a9c08c6bf

commit b8064914cafec9166c25773ec203542a9c08c6bf
Author: Boris Vidolov <borisv@chromium.org>
Date: Tue May 08 02:11:07 2018

Check system Keystone version to offer recovery in the UI when system Keystone is broken. Refactored a bit KeystoneGlue implementation. Added unit tests.

Bug:  658993 
Change-Id: I16870fc37e1f71772848240f0ae397d6aa13b2e5
Reviewed-on: https://chromium-review.googlesource.com/1044527
Commit-Queue: Boris Vidolov <borisv@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556647}
[modify] https://crrev.com/b8064914cafec9166c25773ec203542a9c08c6bf/chrome/browser/mac/keystone_glue.mm
[modify] https://crrev.com/b8064914cafec9166c25773ec203542a9c08c6bf/chrome/browser/mac/keystone_glue_unittest.mm

Cc: ellyjo...@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment