New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658989 link

Starred by 6 users
Status: Fixed
Owner:
einbinder@chromium.org
Closed: Mar 2017
Cc:
█ lushnikov@chromium.org
█ kozyatinskiy@chromium.org
l...@chromium.org
jmukthavaram@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Regression] DevTools: The shortkey "Ctrl+Shift+E" for "evalute in console" doesn't work since chrome 54

Reported by qiujiawe...@gmail.com, Oct 25 2016 
UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36

Steps to reproduce the problem:
1. open the web develop tool
2. choose the sources tab
3. select some code and press Ctrl+Shift+E

What is the expected behavior?
the selected code should be evaluted in console

What went wrong?
the selected code didn't be evaluted in console

Did this work before? Yes 53

Chrome version: 54.0.2840.71  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0

Comment 1 by krajshree@chromium.org, Oct 25 2016

Labels: -Type-Bug -Pri-2 hasbisect-per-revison Pri-1 Type-Bug-Regression
Owner: mcasas@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10 using chrome reported version #54.0.2840.71 and latest canary #56.0.2899.0.

Bisect Information:
=====================
Good build: 54.0.2830.0
Bad Build : 54.0.2831.0

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/1728c325de3deb076ca236e29e9295147e2b2737..900fd602c52a2bd986c7230a2fdfacba3294db7c

From the above change log suspecting below change

Review url: https://codereview.chromium.org/2239583002

mcasas@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by krajshree@chromium.org, Oct 25 2016

Labels: OS-Linux OS-Mac

Comment 3 by mcasas@chromium.org, Oct 25 2016

Components: -Platform>DevTools Platform>DevTools>Authoring
Labels: -OS-Linux -OS-Mac Needs-Bisect
Owner: ----
Status: Untriaged (was: Assigned)
The CL in #1 only affects Android users. I'm afraid I have
no idea what could be causing this bug. Also, this seems
to be Win-specific.

Comment 4 by dgozman@chromium.org, Oct 25 2016

Owner: pfeldman@chromium.org
Status: Assigned (was: Untriaged)
Summary: [Regression] DevTools: The shortkey "Ctrl+Shift+E" for "evalute in console" doesn't work since chrome 54 (was: The shortkey "Ctrl+Shift+E" for "evalute in console" doesn't work since chrome 54)
I can repro on ToT. Pavel, this sounds like your regression.

Comment 5 by krajshree@chromium.org, Oct 26 2016

Labels: -Needs-Bisect OS-Linux
Re-bisected the issue on Ubuntu 14.04 and got the below CL:

https://chromium.googlesource.com/chromium/src/+log/79331e5aff1549688db5bcde820812827e6fbd97..c88c2032c2afd035c998da61abc0b92e4253803f

From the above change log suspecting below change

Review-Url: https://codereview.chromium.org/2238003002

pfeldman@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 6 by jmukthavaram@chromium.org, Oct 28 2016

Cc: jmukthavaram@chromium.org
 Issue 659682  has been merged into this issue.

Comment 7 by pfeldman@chromium.org, Nov 21 2016

Owner: einbinder@chromium.org

Comment 8 by einbinder@chromium.org, Dec 6 2016

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/359a23a93846ccadce7435394771ef9d14d0d2c6

commit 359a23a93846ccadce7435394771ef9d14d0d2c6
Author: einbinder <einbinder@chromium.org>
Date: Wed Dec 07 00:54:03 2016

DevTools: Sources: Evaluate selected text should be Ctrl+Shift+E

It was mistakenly assigned to Ctrl+E.

BUG= 658989 

Review-Url: https://codereview.chromium.org/2555003002
Cr-Commit-Position: refs/heads/master@{#436798}

[modify] https://crrev.com/359a23a93846ccadce7435394771ef9d14d0d2c6/third_party/WebKit/Source/devtools/front_end/sources/module.json

Comment 10 by l...@chromium.org, Jan 27 2017

Cc: kozyatinskiy@chromium.org l...@chromium.org lushnikov@chromium.org
 Issue 682297  has been merged into this issue.

Comment 11 by rsesek@chromium.org, Jan 27 2017 

 Issue 685974  has been merged into this issue.

Comment 12 by einbinder@chromium.org, Mar 17 2017

Status: Fixed (was: Started)

Comment 13 by dominik....@gmail.com, Mar 17 2017 

Still does not work in Canary !!!!!!!!

Comment 14 by steck...@gmail.com, Mar 17 2017 

THANK YOU! THANK YOU! THANK YOU!
►

Sign in to add a comment