New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658980 link

Starred by 15 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Sign in to add a comment

Implement Material Design for Bookmarks

Project Member Reported by calamity@chromium.org, Oct 25 2016

Issue description

Tracker bug for implementing a material design web ui for chrome://bookmarks.
 

Comment 1 by dbeam@chromium.org, Oct 25 2016

Labels: -Pri-3 Pri-2

Comment 2 by dpa...@chromium.org, Oct 28 2016

Are there plans to start working on this task soon?

I think it might be worth to have a discussion first on what library/framework should be used to implement the MD look-and-feel of bookmarks (as well as any other WebUI pages that will me MD-ified from now on).

Polymer v1 has served this role very well so far (Downloads, History, and soon Settings), but Polymer v2 is almost out, see [1]. Polymer V2 as advertized is a big improvement over V1 based on many lessons that were learned along the way. Also it seems natural that once V2 is out, it will be the main focus, and therefore much more likely to get the necessary support needed from the Polymer team.

So my suggestion is to have this discussion first, before diving into implementation. Thoughts?

[1] https://www.polymer-project.org/1.0/blog/2016-09-09-polymer-2.0
Cc: dpa...@chromium.org
Work on this will commence late November. There should be time to do some preliminary exploration of what it will take to start this project with Polymer 2.0.

After a glance, my concern would be that we'd need some iron or paper elements that haven't been converted, e.g iron-list and iron-pages. Also, any cr-elements that we want to use need to be at least put into hybrid mode and if they have blocked dependencies, then we'd be in a bind as well.

Polymer 2.0 has also been advertised as easy to migrate so I don't think early adoption is entirely necessary. Migrating an existing WebUI would probably lead to a smoother adoption. At the very least, active feature development won't be blocked every time there's a dependency on the Polymer team.

Comment 4 by dbeam@chromium.org, Oct 31 2016

calamity@: are we sure we want to keep using paper elements on new pages?
The newer, lighter elements ought to be fine. We have a bunch in cr-elements (paper-listbox, paper-icon-button, paper-menu-button, etc) which we'd probably inherit anyway. There are certainly some elements to avoid, but all in all, the convenience elements are convenient.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b560c25322e96b12e72689fbfa7c1cc977e4661c

commit b560c25322e96b12e72689fbfa7c1cc977e4661c
Author: calamity <calamity@chromium.org>
Date: Tue Nov 01 08:30:06 2016

[MD Bookmarks] Add skeleton for Material Design Bookmarks

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2450623002
Cr-Commit-Position: refs/heads/master@{#428961}

[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/app/generated_resources.grd
[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/about_flags.cc
[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/browser_resources.grd
[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/extensions/component_loader.cc
[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/resources/component_extension_resources.grd
[add] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/resources/md_bookmarks/OWNERS
[add] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/resources/md_bookmarks/bookmarks.html
[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[add] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/ui/webui/md_bookmarks/OWNERS
[add] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[add] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h
[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/common/chrome_features.cc
[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/common/chrome_features.h
[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/b560c25322e96b12e72689fbfa7c1cc977e4661c/tools/metrics/histograms/histograms.xml

Blockedon: 665660
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06087bd8b11b6e75ab272fa5522b8eb1e14e4313

commit 06087bd8b11b6e75ab272fa5522b8eb1e14e4313
Author: calamity <calamity@chromium.org>
Date: Thu Nov 17 01:58:49 2016

[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

This CL adds the chrome://bookmarks webui to the allowed users of the
chrome.bookmarks API.

BUG= 658980 

Review-Url: https://codereview.chromium.org/2491773003
Cr-Commit-Position: refs/heads/master@{#432700}

[modify] https://crrev.com/06087bd8b11b6e75ab272fa5522b8eb1e14e4313/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/06087bd8b11b6e75ab272fa5522b8eb1e14e4313/chrome/common/extensions/api/common_extension_api_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64da903e4cfacff1d9b0124bebee39ec3c64ff16

commit 64da903e4cfacff1d9b0124bebee39ec3c64ff16
Author: calamity <calamity@chromium.org>
Date: Wed Dec 14 08:36:10 2016

[MD Bookmarks] Fix segfault when calling chrome.bookmarks.remove().

This CL fixes an issue where a null pointer would get dereferenced when
calling certain bookmarks API functions because they expect a valid
extension. This fails on the new bookmarks page since it is a WebUI and
has no extension. This has been fixed by adding a null check.

BUG= 658980 

Review-Url: https://codereview.chromium.org/2572853004
Cr-Commit-Position: refs/heads/master@{#438463}

[modify] https://crrev.com/64da903e4cfacff1d9b0124bebee39ec3c64ff16/chrome/browser/sync/glue/extensions_activity_monitor.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d4faef71ad94872ee6b3e1e555e00f34203979b

commit 1d4faef71ad94872ee6b3e1e555e00f34203979b
Author: angelayang <angelayang@google.com>
Date: Fri Dec 30 04:08:57 2016

[MD Bookmarks] Add skeleton for MD Bookmarks.

MD Bookmarks is the material redesign for the bookmarks manager.
This CL sets up the skeleton for the UI and data model.
- app.html is the top level element that contains the bookmark manager.
- store.html is the data model that propagates data from the Bookmarks
  API to UI elements.

UI elements will be landed in a follow up patch.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2592293003
Cr-Commit-Position: refs/heads/master@{#441017}

[modify] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/browser_resources.grd
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/resources/md_bookmarks/app.html
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/resources/md_bookmarks/app.js
[modify] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/resources/md_bookmarks/bookmarks.html
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/resources/md_bookmarks/shared_style.html
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/resources/md_bookmarks/shared_vars.html
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/resources/md_bookmarks/store.html
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/resources/md_bookmarks/store.js
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/resources/md_bookmarks/toolbar.html
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/resources/md_bookmarks/toolbar.js
[modify] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/test/BUILD.gn
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/test/data/webui/md_bookmarks/store_test.js
[add] https://crrev.com/1d4faef71ad94872ee6b3e1e555e00f34203979b/chrome/test/data/webui/md_bookmarks/test_util.js

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78c8556e215fe9def6cc73e31d36c8e43a4a157e

commit 78c8556e215fe9def6cc73e31d36c8e43a4a157e
Author: angelayang <angelayang@google.com>
Date: Mon Jan 09 00:19:50 2017

[MD Bookmarks] Add closure compilation to MD Bookmarks.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2616663003
Cr-Commit-Position: refs/heads/master@{#442187}

[add] https://crrev.com/78c8556e215fe9def6cc73e31d36c8e43a4a157e/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/78c8556e215fe9def6cc73e31d36c8e43a4a157e/third_party/closure_compiler/compiled_resources2.gyp

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d7aaa5e27ab5d9d2f2ee42fc52f673ae8b2505d

commit 2d7aaa5e27ab5d9d2f2ee42fc52f673ae8b2505d
Author: angelayang <angelayang@google.com>
Date: Mon Jan 09 04:02:09 2017

[MD Bookmarks] Add a message to empty bookmark lists.

This CL makes sure that empty folders will display an empty bookmarks
list with no card and a message like that in history to indicate no items
should be expected.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2610123004
Cr-Commit-Position: refs/heads/master@{#442194}

[modify] https://crrev.com/2d7aaa5e27ab5d9d2f2ee42fc52f673ae8b2505d/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/2d7aaa5e27ab5d9d2f2ee42fc52f673ae8b2505d/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/2d7aaa5e27ab5d9d2f2ee42fc52f673ae8b2505d/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/2d7aaa5e27ab5d9d2f2ee42fc52f673ae8b2505d/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0

commit 2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0
Author: angelayang <angelayang@google.com>
Date: Fri Jan 13 05:36:53 2017

[MD Bookmarks] Add search.

This CL implements search by sending a query to the existing backend
search and then updating the ui to reflect the search result. The
bookmarks list will now either display the contents of a folder or the
search results.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2614703003
Cr-Commit-Position: refs/heads/master@{#443499}

[modify] https://crrev.com/2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0/chrome/browser/resources/md_bookmarks/app.js
[modify] https://crrev.com/2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0/chrome/browser/resources/md_bookmarks/store.js
[modify] https://crrev.com/2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0/chrome/browser/resources/md_bookmarks/toolbar.js
[modify] https://crrev.com/2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0/chrome/test/data/webui/md_bookmarks/store_test.js

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47247ddf01cec0329fa6ee03e2bf47fa813c540f

commit 47247ddf01cec0329fa6ee03e2bf47fa813c540f
Author: angelayang <angelayang@google.com>
Date: Mon Jan 23 03:52:17 2017

[MD Bookmarks] Add routing.

Implement URLs that go directly to folders and searches.
The URL now reflects the selectedId and the searchTerm in the
parameter list.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2637023002
Cr-Commit-Position: refs/heads/master@{#445318}

[modify] https://crrev.com/47247ddf01cec0329fa6ee03e2bf47fa813c540f/chrome/browser/browser_resources.grd
[modify] https://crrev.com/47247ddf01cec0329fa6ee03e2bf47fa813c540f/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/47247ddf01cec0329fa6ee03e2bf47fa813c540f/chrome/browser/resources/md_bookmarks/folder_node.js
[add] https://crrev.com/47247ddf01cec0329fa6ee03e2bf47fa813c540f/chrome/browser/resources/md_bookmarks/router.html
[add] https://crrev.com/47247ddf01cec0329fa6ee03e2bf47fa813c540f/chrome/browser/resources/md_bookmarks/router.js
[modify] https://crrev.com/47247ddf01cec0329fa6ee03e2bf47fa813c540f/chrome/browser/resources/md_bookmarks/store.html
[modify] https://crrev.com/47247ddf01cec0329fa6ee03e2bf47fa813c540f/chrome/browser/resources/md_bookmarks/store.js
[modify] https://crrev.com/47247ddf01cec0329fa6ee03e2bf47fa813c540f/chrome/browser/resources/md_bookmarks/toolbar.js
[modify] https://crrev.com/47247ddf01cec0329fa6ee03e2bf47fa813c540f/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/47247ddf01cec0329fa6ee03e2bf47fa813c540f/chrome/test/data/webui/md_bookmarks/store_test.js

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3

commit f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3
Author: angelayang <angelayang@google.com>
Date: Mon Jan 23 06:59:47 2017

[MD Bookmarks] Add lines between items and no search results message.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2639893006
Cr-Commit-Position: refs/heads/master@{#445330}

[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/browser/resources/md_bookmarks/bookmarks.html
[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/browser/resources/md_bookmarks/shared_vars.html
[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/browser/resources/md_bookmarks/store.js
[modify] https://crrev.com/f37249e1ef4c5c6bdf2588ebaec7ffa748be33c3/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e3075995e49f524bfe3d7eadeb85bb508c83597

commit 0e3075995e49f524bfe3d7eadeb85bb508c83597
Author: calamity <calamity@chromium.org>
Date: Wed Jan 25 01:20:58 2017

[MD Bookmarks] Add PRESUBMIT.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2657583003
Cr-Commit-Position: refs/heads/master@{#445896}

[add] https://crrev.com/0e3075995e49f524bfe3d7eadeb85bb508c83597/chrome/browser/resources/md_bookmarks/PRESUBMIT.py

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e23ca635bba70477806fa3ba702a240d398239

commit d5e23ca635bba70477806fa3ba702a240d398239
Author: angelayang <angelayang@google.com>
Date: Thu Feb 02 00:23:12 2017

[MD Bookmarks] Remove separator lines between list items.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668893002
Cr-Commit-Position: refs/heads/master@{#447654}

[modify] https://crrev.com/d5e23ca635bba70477806fa3ba702a240d398239/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/d5e23ca635bba70477806fa3ba702a240d398239/chrome/browser/resources/md_bookmarks/shared_vars.html

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feacdc993b7e6657fb5daa957de6e50a0fc6970b

commit feacdc993b7e6657fb5daa957de6e50a0fc6970b
Author: jiaxi <jiaxi@google.com>
Date: Mon Feb 06 05:33:35 2017

[MD Bookmarks] Add Select for Bookmarks.

This CL enables single click to select items in the list.
- Shift select.
- Ctrl select.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2639453002
Cr-Commit-Position: refs/heads/master@{#448209}

[modify] https://crrev.com/feacdc993b7e6657fb5daa957de6e50a0fc6970b/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/feacdc993b7e6657fb5daa957de6e50a0fc6970b/chrome/browser/resources/md_bookmarks/folder_node.js
[modify] https://crrev.com/feacdc993b7e6657fb5daa957de6e50a0fc6970b/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/feacdc993b7e6657fb5daa957de6e50a0fc6970b/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/feacdc993b7e6657fb5daa957de6e50a0fc6970b/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/feacdc993b7e6657fb5daa957de6e50a0fc6970b/chrome/browser/resources/md_bookmarks/sidebar.html
[modify] https://crrev.com/feacdc993b7e6657fb5daa957de6e50a0fc6970b/chrome/browser/resources/md_bookmarks/store.js
[modify] https://crrev.com/feacdc993b7e6657fb5daa957de6e50a0fc6970b/chrome/test/data/webui/md_bookmarks/item_test.js
[modify] https://crrev.com/feacdc993b7e6657fb5daa957de6e50a0fc6970b/chrome/test/data/webui/md_bookmarks/store_test.js
[modify] https://crrev.com/feacdc993b7e6657fb5daa957de6e50a0fc6970b/chrome/test/data/webui/md_bookmarks/test_util.js

Blocking: 689180
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5827f99e6bf79d952a90edc4bc783e7a1c4fa690

commit 5827f99e6bf79d952a90edc4bc783e7a1c4fa690
Author: jiaxi <jiaxi@google.com>
Date: Wed Feb 08 03:59:47 2017

[MD Bookmarks] Double Click

This CL adds double click behaviours for items inside the list.

When item gets clicked, if it's a folder, it will open the
folder. Otherwise it will open the bookmark in a new tab.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668693007
Cr-Commit-Position: refs/heads/master@{#448900}

[modify] https://crrev.com/5827f99e6bf79d952a90edc4bc783e7a1c4fa690/chrome/browser/extensions/extension_tab_util.cc
[modify] https://crrev.com/5827f99e6bf79d952a90edc4bc783e7a1c4fa690/chrome/browser/resources/md_bookmarks/item.js
[modify] https://crrev.com/5827f99e6bf79d952a90edc4bc783e7a1c4fa690/chrome/browser/resources/md_bookmarks/store.js
[modify] https://crrev.com/5827f99e6bf79d952a90edc4bc783e7a1c4fa690/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/5827f99e6bf79d952a90edc4bc783e7a1c4fa690/chrome/test/data/webui/md_bookmarks/store_test.js

Blockedon: 692821
Blockedon: 692827
Blockedon: 692837
Blockedon: 692840
Blockedon: 692843
Blockedon: 692844
Blockedon: 692847
Blockedon: 692848
Blockedon: 692868
For those playing along at home, calamity@ and I are taking over the remaining implementation work on MD Bookmarks. The above bugs more-or-less encompass all the feature work we have on our plates (there's a couple of small things I didn't bother making bugs for).
Project Member

Comment 32 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78cb58e46b5b386904878be7847399b14f0e4d63

commit 78cb58e46b5b386904878be7847399b14f0e4d63
Author: loorongjie <loorongjie@gmail.com>
Date: Wed Feb 22 10:17:55 2017

[MD Bookmarks] Expose chrome.bookmarks.import/export to MD Bookmarks

BUG= 658980 ,  692848 

Review-Url: https://codereview.chromium.org/2700693002
Cr-Commit-Position: refs/heads/master@{#451974}

[modify] https://crrev.com/78cb58e46b5b386904878be7847399b14f0e4d63/chrome/common/extensions/api/_api_features.json

Blockedon: 696823
Project Member

Comment 34 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40f48059f7f123778ac5ae4a746968f60f174f4e

commit 40f48059f7f123778ac5ae4a746968f60f174f4e
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Mar 14 22:16:20 2017

MD Bookmarks: Show pointer cursor on entire bookmark item.

The whole <bookmark-item> element is clickable, but the pointer cursor
was set to only appear on the bookmark title text. This also affects
the touchscreen tap highlight.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2747833003
Cr-Commit-Position: refs/heads/master@{#456861}

[modify] https://crrev.com/40f48059f7f123778ac5ae4a746968f60f174f4e/chrome/browser/resources/md_bookmarks/item.html

Project Member

Comment 35 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1a323946c7ff485c73662eebc30d5f02a070576

commit d1a323946c7ff485c73662eebc30d5f02a070576
Author: calamity <calamity@chromium.org>
Date: Fri Mar 17 01:31:28 2017

[MD Bookmarks] Add draggable sidebar.

This CL adds a draggable splitter which resizes the sidebar. This CL
also repositions the search bar to stay aligned with the main card and
moves the arrows to the left of the folders in the sidebar to allow for
a reasonable overflow behavior.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2745593004
Cr-Commit-Position: refs/heads/master@{#457648}

[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/chrome/browser/resources/md_bookmarks/app.js
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/chrome/browser/resources/md_bookmarks/folder_node.js
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/chrome/browser/resources/md_bookmarks/shared_vars.html
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/chrome/browser/resources/md_bookmarks/sidebar.html
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/chrome/browser/resources/md_bookmarks/toolbar.js
[add] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/ui/webui/resources/html/cr/ui/splitter.html
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/ui/webui/resources/js/cr/ui/compiled_resources2.gyp
[modify] https://crrev.com/d1a323946c7ff485c73662eebc30d5f02a070576/ui/webui/resources/webui_resources.grd

Blockedon: 716243
Blockedon: 708894
Blockedon: 725786
Blockedon: 727174
Blockedon: 729858
Blockedon: 729939
Blockedon: 730905
Blockedon: 731531
Project Member

Comment 44 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228

commit ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228
Author: calamity <calamity@chromium.org>
Date: Thu Jun 22 04:58:22 2017

[MD Bookmarks] Enable by default.

BUG= 658980 

Review-Url: https://codereview.chromium.org/2924383003
Cr-Commit-Position: refs/heads/master@{#481444}

[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/browser/chrome_security_exploit_browsertest.cc
[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/browser/extensions/component_loader_unittest.cc
[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/browser/extensions/extension_url_rewrite_browsertest.cc
[add] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/browser/extensions/view_extension_source_browsertest.cc
[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/browser/tab_contents/view_source_browsertest.cc
[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/browser/ui/webui/bookmarks_ui_browsertest.cc
[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/common/chrome_features.cc
[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/test/BUILD.gn
[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/test/data/chrome_extension_resource.html
[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/test/data/extensions/override_component_extension/manifest.json
[modify] https://crrev.com/ae7fed4fc2b5d2e9732c4b4ed63ca2a639f05228/chrome/test/data/extensions/simple_with_icon/manifest.json

Blockedon: 735808

Comment 46 by dbeam@chromium.org, Jun 22 2017

woohoo! \o/
Blockedon: 737076
Project Member

Comment 48 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4622c187b62c9cec74ff576bd8d02f486cc6f394

commit 4622c187b62c9cec74ff576bd8d02f486cc6f394
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jul 06 06:35:22 2017

MD Bookmarks: Remove '/?id=1' from URL when displaying Bookmarks Bar

This changes the default URL for MD Bookmarks to 'chrome://bookmarks',
like the previous bookmark manager. Upon navigating to a different
folder or performing a search, the URL will update as expected.

BUG= 658980 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2960143002
Cr-Commit-Position: refs/heads/master@{#484481}

[modify] https://crrev.com/4622c187b62c9cec74ff576bd8d02f486cc6f394/chrome/browser/resources/md_bookmarks/constants.js
[modify] https://crrev.com/4622c187b62c9cec74ff576bd8d02f486cc6f394/chrome/browser/resources/md_bookmarks/router.html
[modify] https://crrev.com/4622c187b62c9cec74ff576bd8d02f486cc6f394/chrome/browser/resources/md_bookmarks/router.js
[modify] https://crrev.com/4622c187b62c9cec74ff576bd8d02f486cc6f394/chrome/browser/resources/md_bookmarks/util.js
[modify] https://crrev.com/4622c187b62c9cec74ff576bd8d02f486cc6f394/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/4622c187b62c9cec74ff576bd8d02f486cc6f394/chrome/browser/ui/webui/bookmarks_ui_browsertest.cc
[modify] https://crrev.com/4622c187b62c9cec74ff576bd8d02f486cc6f394/chrome/test/data/webui/md_bookmarks/router_test.js

Blockedon: 746812
Project Member

Comment 50 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f51ed49c3d785f7aa59506be9b32c1bde724fed4

commit f51ed49c3d785f7aa59506be9b32c1bde724fed4
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Fri Jul 21 01:03:51 2017

MD Bookmarks: Disable by default

Bug:  658980 
Change-Id: I6b8bb4d75ac2bf5b122405765a4a4e95d3a7e0d5
Reviewed-on: https://chromium-review.googlesource.com/580009
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488529}
[modify] https://crrev.com/f51ed49c3d785f7aa59506be9b32c1bde724fed4/chrome/common/chrome_features.cc

^ Temporary disable for M61 branch point. We'll re-enable early next week.
Blockedon: -746812
Labels: Merge-Request-61
Looks like we missed the branch point for M61 by one commit (!!). Requesting merge of #50 to M61.
Project Member

Comment 54 by sheriffbot@chromium.org, Jul 24 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 42 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Before we approve merge to CL listed at #50, please answer followings:
* Are you planning to disable MD Bookmarks: Disable by default for M61 permanently?
* Also will it be a safe merge?
Yes to both questions. MD Bookmarks will be disabled for M61 permanently (it is currently slated for M62). The CL at #50 is a 1-line fix that disables the new feature and prevents any new code from running, so it is safe to merge.

Thanks!
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 branch 3163 based on comment #56. Please merge ASAP. Thank you.
Project Member

Comment 58 by bugdroid1@chromium.org, Jul 25 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4e43136206c73e84c4fd03ab3a0fbdc6a0ebce4

commit e4e43136206c73e84c4fd03ab3a0fbdc6a0ebce4
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Tue Jul 25 00:06:26 2017

MD Bookmarks: Disable by default

TBR=tsergeant@chromium.org

(cherry picked from commit f51ed49c3d785f7aa59506be9b32c1bde724fed4)

Bug:  658980 
Change-Id: I6b8bb4d75ac2bf5b122405765a4a4e95d3a7e0d5
Reviewed-on: https://chromium-review.googlesource.com/580009
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488529}
Reviewed-on: https://chromium-review.googlesource.com/583948
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#19}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/e4e43136206c73e84c4fd03ab3a0fbdc6a0ebce4/chrome/common/chrome_features.cc

Blockedon: 748444
Project Member

Comment 60 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dad44f111bd2b68efffc18a7be1e16453c0138bf

commit dad44f111bd2b68efffc18a7be1e16453c0138bf
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Thu Jul 27 03:56:29 2017

MD Bookmarks: Reenable by default

Bug:  658980 
Change-Id: I99d172318c233135d1b5c2f8d433054a09379089
Reviewed-on: https://chromium-review.googlesource.com/585337
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489853}
[modify] https://crrev.com/dad44f111bd2b68efffc18a7be1e16453c0138bf/chrome/common/chrome_features.cc

Project Member

Comment 61 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab16faadfc75665d3243553bec57e9c2da50dbe6

commit ab16faadfc75665d3243553bec57e9c2da50dbe6
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Fri Jul 28 00:48:18 2017

MD Bookmarks: Tweak strings according to UI feedback

This changes strings to avoid titlecase, and shortens some strings in
the bookmark context menu.

Bug:  658980 
Change-Id: Ia173518a481043e8eb79733a5ed0ba9699c4ce22
Reviewed-on: https://chromium-review.googlesource.com/584695
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490166}
[modify] https://crrev.com/ab16faadfc75665d3243553bec57e9c2da50dbe6/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/ab16faadfc75665d3243553bec57e9c2da50dbe6/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc

Project Member

Comment 62 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4fcfbe0e64b61f122d8c3fe2ab538647373cf88

commit c4fcfbe0e64b61f122d8c3fe2ab538647373cf88
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Fri Jul 28 04:33:22 2017

MD Bookmarks: Add a readme file

This readme explains the basics of how the page works, and provides
links to our design documents.

Bug:  658980 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4d57849011b30c471c753b236e0f6b724e6acf1b
Reviewed-on: https://chromium-review.googlesource.com/590390
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490261}
[add] https://crrev.com/c4fcfbe0e64b61f122d8c3fe2ab538647373cf88/chrome/browser/resources/md_bookmarks/README.md

Blockedon: -748444
Project Member

Comment 64 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7e655e34fdb6a6d56b34532fb644032c6f0ef14

commit f7e655e34fdb6a6d56b34532fb644032c6f0ef14
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Aug 30 02:46:26 2017

[MD Bookmarks] Fix some strings.

Bug:  658980 
Change-Id: I911b15895f3d40a6eb7be21cea58ee596084a277
Reviewed-on: https://chromium-review.googlesource.com/634766
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498351}
[modify] https://crrev.com/f7e655e34fdb6a6d56b34532fb644032c6f0ef14/chrome/app/bookmarks_strings.grdp

Project Member

Comment 65 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d9fc4fb14992bd662ea45bc576ba69355dd8030

commit 2d9fc4fb14992bd662ea45bc576ba69355dd8030
Author: calamity <calamity@chromium.org>
Date: Wed Aug 30 08:27:08 2017

MD Bookmarks: Disable by default

Bug:  658980 
Change-Id: I35d600ffbfc5395b25030d19753531d6acd36006
Reviewed-on: https://chromium-review.googlesource.com/642155
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498394}
[modify] https://crrev.com/2d9fc4fb14992bd662ea45bc576ba69355dd8030/chrome/common/chrome_features.cc

Project Member

Comment 66 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/938f8745e3a3a85335413078f28a11b2768cc371

commit 938f8745e3a3a85335413078f28a11b2768cc371
Author: calamity <calamity@chromium.org>
Date: Thu Sep 07 06:21:07 2017

MD Bookmarks: Enable by default

Bug:  658980 
Change-Id: I8e7424ec1720cdcf627acdbc7100794567fb06b5
Reviewed-on: https://chromium-review.googlesource.com/647951
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500233}
[modify] https://crrev.com/938f8745e3a3a85335413078f28a11b2768cc371/chrome/common/chrome_features.cc

Any chance the actual bookmark url can be always visible?

It's hidden under a hover in 61, but in the latest canary, you can only find out a bookmark's url by clicking edit? 

With the advent of tiny tabs, often urls are more meaningful that page titles

Comment 68 by audv...@gmail.com, Dec 6 2017

Can we have the 'Order by name' context menu option back? Right-clicking a menu does not display this option.

This is the only thing preventing me from switching to MD bookmarks.
#67: Running it past people.

#68: You can select a folder, and then press the 3-dot menu in the top right of the page to 'Sort by name'.

Actually going to mark this whole bug as fixed since this is enabled by default now. Please file new issues for any other bugs or feature requests.
Status: Fixed (was: Assigned)

Comment 71 Deleted

Comment 72 by dhw@chromium.org, Dec 8 2017

#67: Created Regression-Bug for cannot see bookmark URL on hover as  Issue 768259 

Sign in to add a comment